openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-22 03:35:29 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #141] [MERGED] Fix/owner sees pending skill #270

New Issue
Closed
opened 2026-02-15 17:16:35 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:35 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/141
Author: @orlyjamie
Created: 2/5/2026
Status: ✅ Merged
Merged: 2/5/2026
Merged by: @orlyjamie

Base: main ← Head: fix/owner-sees-pending-skill

📝 Commits (10+)

  • 9ebe1b6 fix: show pending skill page to owners instead of "Skill not found"
  • 0710b99 fix: show pending skills on owner's dashboard
  • 46faafc fix: show all moderation states to owners with appropriate UI
  • 5ef8526 feat: make malware-blocked skills publicly visible
  • 5cff711 fix: allow owners to view pending scan skills (#136)
  • 9e75090 fix: make deterministic zip date timezone-safe
  • 8d0f324 chore: update convex api types
  • 4ac63c2 fix: update changelog for pending scan visibility (#136) (thanks @orlyjamie)
  • 2d79148 feat: show Code Insight analysis for malicious skills
  • aad1fbe fix: use computed badges in pending skill response

📊 Changes

4 files changed (+70 additions, -10 deletions)

View changed files

📝 convex/skills.ts (+3 -1)
📝 convex/vt.ts (+1 -0)
📝 src/components/SkillDetailPage.tsx (+24 -9)
📝 src/styles.css (+42 -0)

📄 Description

Summary

  • Owners can now see their skills during VT scan (shows "Security scan in progress" banner)
  • Malware-blocked skills visible publicly for transparency (no download button)
  • Code Insight analysis displayed when AI catches malicious patterns
  • Fixed badges bug (using computed badges instead of skill.badges)

Test plan

  • Upload new skill → see pending banner instead of "Skill not found"
  • Check malware-blocked skill shows Code Insight analysis
  • Verify non-owners can't see pending/removed skills
  • Verify non-owners CAN see malware-blocked skills (transparency)
image image

Greptile Overview

Greptile Summary

This PR updates the skills flow to improve visibility during moderation/security scanning: owners can view their own pending.scan skills (both on the skill detail page and on the dashboard list), malware-blocked skills can be shown publicly without download actions, and the UI now surfaces VirusTotal “Code Insight” AI analysis alongside engine stats. It also adjusts badge usage to prefer computed badge maps.

Key touchpoints are convex/skills.ts (new owner-aware behavior in getBySlug and list), convex/vt.ts (returning scan source + AI metadata), and src/components/SkillDetailPage.tsx / src/routes/dashboard.tsx (new banners, scan panel, and download gating).

Confidence Score: 4/5

  • This PR is close to safe to merge once the pending-skill badge mapping is corrected.
  • Changes are largely additive and consistent with existing patterns, but there is one verified logic issue in convex/skills.ts where the pending-skill fallback uses the wrong badge source, which will lead to incorrect UI badge display for owners.
  • convex/skills.ts

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/141 **Author:** [@orlyjamie](https://github.com/orlyjamie) **Created:** 2/5/2026 **Status:** ✅ Merged **Merged:** 2/5/2026 **Merged by:** [@orlyjamie](https://github.com/orlyjamie) **Base:** `main` ← **Head:** `fix/owner-sees-pending-skill` --- ### 📝 Commits (10+) - [`9ebe1b6`](https://github.com/openclaw/clawhub/commit/9ebe1b6da83da784942d370fd92ae3454d86a6b9) fix: show pending skill page to owners instead of "Skill not found" - [`0710b99`](https://github.com/openclaw/clawhub/commit/0710b99ac4391b7e0ac7df33cf5ad1c605b87fbe) fix: show pending skills on owner's dashboard - [`46faafc`](https://github.com/openclaw/clawhub/commit/46faafc413bfcee133ca1c87082662bdac11d8f7) fix: show all moderation states to owners with appropriate UI - [`5ef8526`](https://github.com/openclaw/clawhub/commit/5ef8526874799d92c6fc2764831a712f7073dfec) feat: make malware-blocked skills publicly visible - [`5cff711`](https://github.com/openclaw/clawhub/commit/5cff71104c513a79a9ddded45db5e741d641b910) fix: allow owners to view pending scan skills (#136) - [`9e75090`](https://github.com/openclaw/clawhub/commit/9e75090a3931de99552959780dbc026c5b97176e) fix: make deterministic zip date timezone-safe - [`8d0f324`](https://github.com/openclaw/clawhub/commit/8d0f32443a7fad18a0846ddafddd88fcbd9ed035) chore: update convex api types - [`4ac63c2`](https://github.com/openclaw/clawhub/commit/4ac63c23733334cdef2cdd9985ca706134069d0c) fix: update changelog for pending scan visibility (#136) (thanks @orlyjamie) - [`2d79148`](https://github.com/openclaw/clawhub/commit/2d7914859ce468fa26a24940f1383a3f9aed8bbd) feat: show Code Insight analysis for malicious skills - [`aad1fbe`](https://github.com/openclaw/clawhub/commit/aad1fbe2c4809045190f0df630bd56760e9edda0) fix: use computed badges in pending skill response ### 📊 Changes **4 files changed** (+70 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `convex/skills.ts` (+3 -1) 📝 `convex/vt.ts` (+1 -0) 📝 `src/components/SkillDetailPage.tsx` (+24 -9) 📝 `src/styles.css` (+42 -0) </details> ### 📄 Description ## Summary - Owners can now see their skills during VT scan (shows "Security scan in progress" banner) - Malware-blocked skills visible publicly for transparency (no download button) - Code Insight analysis displayed when AI catches malicious patterns - Fixed badges bug (using computed `badges` instead of `skill.badges`) ## Test plan - [ ] Upload new skill → see pending banner instead of "Skill not found" - [ ] Check malware-blocked skill shows Code Insight analysis - [ ] Verify non-owners can't see pending/removed skills - [ ] Verify non-owners CAN see malware-blocked skills (transparency) <img width="1187" height="481" alt="image" src="https://github.com/user-attachments/assets/8453b582-a852-4c61-ba6e-dac61984ec38" /> <img width="1193" height="573" alt="image" src="https://github.com/user-attachments/assets/7aade4c4-3456-4057-bce0-6114c4b59244" /> <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> This PR updates the skills flow to improve visibility during moderation/security scanning: owners can view their own `pending.scan` skills (both on the skill detail page and on the dashboard list), malware-blocked skills can be shown publicly without download actions, and the UI now surfaces VirusTotal “Code Insight” AI analysis alongside engine stats. It also adjusts badge usage to prefer computed badge maps. Key touchpoints are `convex/skills.ts` (new owner-aware behavior in `getBySlug` and `list`), `convex/vt.ts` (returning scan source + AI metadata), and `src/components/SkillDetailPage.tsx` / `src/routes/dashboard.tsx` (new banners, scan panel, and download gating). <h3>Confidence Score: 4/5</h3> - This PR is close to safe to merge once the pending-skill badge mapping is corrected. - Changes are largely additive and consistent with existing patterns, but there is one verified logic issue in `convex/skills.ts` where the pending-skill fallback uses the wrong badge source, which will lead to incorrect UI badge display for owners. - convex/skills.ts <!-- greptile_other_comments_section --> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=a1d58d20-b4dd-4cbb-973a-9fd7824e1921)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:35 -05:00
yindo closed this issue 2026-02-15 17:16:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#270
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?