openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-21 19:25:25 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #213] [MERGED] chore: fix lint (biome/oxlint) #293

New Issue
Closed
opened 2026-02-15 17:16:42 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:42 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/213
Author: @vignesh07
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @thewilloftheshadow

Base: main ← Head: chore/fix-lint-biome

📝 Commits (1)

📊 Changes

5 files changed (+103 additions, -57 deletions)

View changed files

📝 convex/lib/securityPrompt.ts (+67 -25)
📝 convex/llmEval.ts (+12 -12)
📝 convex/skills.ts (+1 -2)
📝 src/components/SkillDetailPage.tsx (+21 -16)
📝 src/styles.css (+2 -2)

📄 Description

Fixes current CI lint failures so PRs can go green.

  • Apply Biome-safe (and necessary unsafe) autofixes
  • Address oxlint template-expression warnings in securityPrompt.ts by stringifying unknown values safely
  • Remove !important usage in pending banner appeal styles
  • Fix a11y lint: use instead of div role=button
  • Avoid array index keys in findings render

Verified locally:

  • bun run lint
  • bun run test
  • bun run build

Greptile Overview

Greptile Summary

Lint cleanup PR applying Biome/oxlint autofixes: formatting, import sorting, template expression safety via formatScalar, div[role=button] → <button>, array index key elimination, and !important removal.

  • Bug: formatScalar is defined inside assembleEvalUserMessage but referenced in parseLlmEvalResponse — out of scope, will throw ReferenceError at runtime.
  • Regression: Removing !important from .pending-banner-appeal causes .pending-banner-content p to win on specificity, overriding the intended margin-top and font-size values.

Confidence Score: 2/5

  • Contains a scoping bug that will cause a runtime error in production when LLM eval responses include scan findings.
  • The formatScalar function is used outside its defining scope, which will cause a ReferenceError. Additionally, the !important removal introduces a CSS specificity regression. The remaining changes (formatting, import order, a11y, optional chaining) are safe.
  • convex/lib/securityPrompt.ts (scoping bug in parseLlmEvalResponse), src/styles.css (specificity regression on .pending-banner-appeal)

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/213 **Author:** [@vignesh07](https://github.com/vignesh07) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@thewilloftheshadow](https://github.com/thewilloftheshadow) **Base:** `main` ← **Head:** `chore/fix-lint-biome` --- ### 📝 Commits (1) - [`6cb83e8`](https://github.com/openclaw/clawhub/commit/6cb83e874dc329ab415dd787b36daded4363181d) chore: fix lint issues ### 📊 Changes **5 files changed** (+103 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `convex/lib/securityPrompt.ts` (+67 -25) 📝 `convex/llmEval.ts` (+12 -12) 📝 `convex/skills.ts` (+1 -2) 📝 `src/components/SkillDetailPage.tsx` (+21 -16) 📝 `src/styles.css` (+2 -2) </details> ### 📄 Description Fixes current CI lint failures so PRs can go green. - Apply Biome-safe (and necessary unsafe) autofixes - Address oxlint template-expression warnings in securityPrompt.ts by stringifying unknown values safely - Remove !important usage in pending banner appeal styles - Fix a11y lint: use <button> instead of div role=button - Avoid array index keys in findings render Verified locally: - bun run lint - bun run test - bun run build <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> Lint cleanup PR applying Biome/oxlint autofixes: formatting, import sorting, template expression safety via `formatScalar`, `div[role=button]` → `<button>`, array index key elimination, and `!important` removal. - **Bug**: `formatScalar` is defined inside `assembleEvalUserMessage` but referenced in `parseLlmEvalResponse` — out of scope, will throw `ReferenceError` at runtime. - **Regression**: Removing `!important` from `.pending-banner-appeal` causes `.pending-banner-content p` to win on specificity, overriding the intended `margin-top` and `font-size` values. <h3>Confidence Score: 2/5</h3> - Contains a scoping bug that will cause a runtime error in production when LLM eval responses include scan findings. - The `formatScalar` function is used outside its defining scope, which will cause a ReferenceError. Additionally, the `!important` removal introduces a CSS specificity regression. The remaining changes (formatting, import order, a11y, optional chaining) are safe. - `convex/lib/securityPrompt.ts` (scoping bug in `parseLlmEvalResponse`), `src/styles.css` (specificity regression on `.pending-banner-appeal`) <!-- greptile_other_comments_section --> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=a1d58d20-b4dd-4cbb-973a-9fd7824e1921)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:42 -05:00
yindo closed this issue 2026-02-15 17:16:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#293
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?