openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-22 03:35:29 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #255] [MERGED] fix(vt): explicit return types and missing undici dependency #298

New Issue
Closed
opened 2026-02-15 17:16:44 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:44 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/255
Author: @tanujbhaud
Created: 2/13/2026
Status: ✅ Merged
Merged: 2/13/2026
Merged by: @steipete

Base: main ← Head: fix/vt-type-errors

📝 Commits (3)

  • 0ec511c fix(vt): explicit return types and missing undici dependency
  • 0b54d76 Merge remote-tracking branch 'origin/main' into landpr-255-merge
  • 02e0c1e fix: add root undici devDependency for e2e (#255) (thanks @tanujbhaud)

📊 Changes

3 files changed (+10 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 bun.lock (+8 -3)
📝 package.json (+1 -0)

📄 Description

Refactor action handlers in convex/vt.ts to use explicit return types, resolving circular type inference (TS7022). Also add undici to devDependencies for E2E tests.\n\nChanges:\n- Use explicit return types on internal actions in convex/vt.ts\n- Add undici to devDependencies in package.json\n- Fixes TS7022 and TS4023 errors

Greptile Overview

Greptile Summary

This PR updates several Convex action/internalAction handlers in convex/vt.ts to use explicit Promise<...> return types to avoid TypeScript circular inference errors (TS7022/TS4023).

It also claims to add undici for E2E tests, but the only change in the root package.json is removal of the trailing newline; no dependency entry was added. If the intention is to fix a missing dependency at the workspace root, that change is absent and should be included (or the PR description adjusted).

Confidence Score: 4/5

  • Mostly safe to merge, but the dependency change described is missing and there’s a small formatting issue in package.json.
  • The TypeScript return-type changes in convex/vt.ts are straightforward and don’t alter core logic, but the PR’s stated goal of adding undici isn’t reflected in the actual diff, and the root package.json now lacks a trailing newline (can cause CI/format churn).
  • package.json

Last reviewed commit: 0ec511c

(5/5) You can turn off certain types of comments like style here!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/255 **Author:** [@tanujbhaud](https://github.com/tanujbhaud) **Created:** 2/13/2026 **Status:** ✅ Merged **Merged:** 2/13/2026 **Merged by:** [@steipete](https://github.com/steipete) **Base:** `main` ← **Head:** `fix/vt-type-errors` --- ### 📝 Commits (3) - [`0ec511c`](https://github.com/openclaw/clawhub/commit/0ec511c89023c4526c4e9d93721ed30f17f24d86) fix(vt): explicit return types and missing undici dependency - [`0b54d76`](https://github.com/openclaw/clawhub/commit/0b54d7653e52d57cb276ab3b53c365e3f2cef8ce) Merge remote-tracking branch 'origin/main' into landpr-255-merge - [`02e0c1e`](https://github.com/openclaw/clawhub/commit/02e0c1e1d4f76f017cd9785513468455cd2f7f7c) fix: add root undici devDependency for e2e (#255) (thanks @tanujbhaud) ### 📊 Changes **3 files changed** (+10 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `bun.lock` (+8 -3) 📝 `package.json` (+1 -0) </details> ### 📄 Description Refactor action handlers in convex/vt.ts to use explicit return types, resolving circular type inference (TS7022). Also add undici to devDependencies for E2E tests.\n\nChanges:\n- Use explicit return types on internal actions in convex/vt.ts\n- Add undici to devDependencies in package.json\n- Fixes TS7022 and TS4023 errors <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> This PR updates several Convex action/internalAction handlers in `convex/vt.ts` to use explicit `Promise<...>` return types to avoid TypeScript circular inference errors (TS7022/TS4023). It also claims to add `undici` for E2E tests, but the only change in the root `package.json` is removal of the trailing newline; no dependency entry was added. If the intention is to fix a missing dependency at the workspace root, that change is absent and should be included (or the PR description adjusted). <h3>Confidence Score: 4/5</h3> - Mostly safe to merge, but the dependency change described is missing and there’s a small formatting issue in package.json. - The TypeScript return-type changes in convex/vt.ts are straightforward and don’t alter core logic, but the PR’s stated goal of adding `undici` isn’t reflected in the actual diff, and the root package.json now lacks a trailing newline (can cause CI/format churn). - package.json <sub>Last reviewed commit: 0ec511c</sub> <!-- greptile_other_comments_section --> <sub>(5/5) You can turn off certain types of comments like style [here](https://app.greptile.com/review/github)!</sub> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:44 -05:00
yindo closed this issue 2026-02-15 17:16:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?