openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-21 19:25:25 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #309] [MERGED] docs: changelog credit + v1 delete status codes #320

New Issue
Closed
opened 2026-02-15 17:16:53 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:53 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/309
Author: @steipete
Created: 2/14/2026
Status: ✅ Merged
Merged: 2/14/2026
Merged by: @steipete

Base: main ← Head: chore/merge-all

📝 Commits (2)

  • c0a0421 fix: default to CF-only client IP parsing
  • a85faf7 docs: changelog credit + v1 delete status codes

📊 Changes

4 files changed (+30 additions, -10 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 convex/lib/httpRateLimit.test.ts (+16 -6)
📝 convex/lib/httpRateLimit.ts (+3 -2)
📝 docs/http-api.md (+10 -2)

📄 Description

  • Add Unreleased changelog credit for #35 (thanks @sergical)\n- Document v1 skill delete/undelete status codes\n- Include pending main commit: CF-only client IP parsing default\n\nTests: bun run lint; bun run test

Greptile Overview

Greptile Summary

This PR makes three documentation improvements:

  • Adds changelog credit for PR #35 (@sergical) which fixed delete/undelete error handling
  • Documents the v1 API status codes (200, 401, 403, 404, 500) for skill delete/undelete endpoints
  • Updates IP parsing documentation to reflect the security hardening change that defaults to Cloudflare-only client IP detection

The httpRateLimit.ts change improves security by defaulting to CF-only IP parsing (requiring explicit opt-in via TRUST_FORWARDED_IPS=true for other forwarded headers), preventing IP spoofing attacks. Tests were properly updated to reflect the new behavior with correct environment variable cleanup.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are documentation updates and a security hardening improvement (CF-only IP default). The code change is well-tested with proper environment cleanup in tests. The documented status codes accurately match the softDeleteErrorToResponse implementation in convex/httpApiV1.ts.
  • No files require special attention

Last reviewed commit: a85faf7

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/309 **Author:** [@steipete](https://github.com/steipete) **Created:** 2/14/2026 **Status:** ✅ Merged **Merged:** 2/14/2026 **Merged by:** [@steipete](https://github.com/steipete) **Base:** `main` ← **Head:** `chore/merge-all` --- ### 📝 Commits (2) - [`c0a0421`](https://github.com/openclaw/clawhub/commit/c0a04210e97836f66f595f334908a636d83ffb02) fix: default to CF-only client IP parsing - [`a85faf7`](https://github.com/openclaw/clawhub/commit/a85faf76ace3f36339dc451d425d2dd2f7b23e61) docs: changelog credit + v1 delete status codes ### 📊 Changes **4 files changed** (+30 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `convex/lib/httpRateLimit.test.ts` (+16 -6) 📝 `convex/lib/httpRateLimit.ts` (+3 -2) 📝 `docs/http-api.md` (+10 -2) </details> ### 📄 Description - Add Unreleased changelog credit for #35 (thanks @sergical)\n- Document v1 skill delete/undelete status codes\n- Include pending main commit: CF-only client IP parsing default\n\nTests: bun run lint; bun run test <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> This PR makes three documentation improvements: - Adds changelog credit for PR #35 (`@sergical`) which fixed delete/undelete error handling - Documents the v1 API status codes (200, 401, 403, 404, 500) for skill delete/undelete endpoints - Updates IP parsing documentation to reflect the security hardening change that defaults to Cloudflare-only client IP detection The `httpRateLimit.ts` change improves security by defaulting to CF-only IP parsing (requiring explicit opt-in via `TRUST_FORWARDED_IPS=true` for other forwarded headers), preventing IP spoofing attacks. Tests were properly updated to reflect the new behavior with correct environment variable cleanup. <h3>Confidence Score: 5/5</h3> - This PR is safe to merge with minimal risk - All changes are documentation updates and a security hardening improvement (CF-only IP default). The code change is well-tested with proper environment cleanup in tests. The documented status codes accurately match the `softDeleteErrorToResponse` implementation in `convex/httpApiV1.ts`. - No files require special attention <sub>Last reviewed commit: a85faf7</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:53 -05:00
yindo closed this issue 2026-02-15 17:16:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?