openclaw/clawhub
1
0
Fork 0
mirror of https://github.com/openclaw/clawhub.git synced 2026-07-21 19:25:25 -04:00
Code Issues 183 Packages Projects Releases 1 Wiki Activity

[PR #325] [CLOSED] update #328

New Issue
Closed
opened 2026-02-15 17:16:56 -05:00 by yindo · 0 comments
yindo commented 2026-02-15 17:16:56 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/325
Author: @ianalloway
Created: 2/15/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (6)

  • 3f4bb8f fix: sync GitHub profile on login to handle username renames (#303)
  • 19ec3e7 Merge pull request #1 from ianalloway/devin/1771109978-fix-github-username-sync
  • 7ab1862 fix: allow updating skill summary/description on subsequent publishes (#301)
  • 36078ad Merge pull request #2 from ianalloway/devin/1771112524-skill-metadata-update
  • 1d53b25 Merge branch 'main' into main
  • 331ba0d Update convex/users.ts

📊 Changes

2 files changed (+16 additions, -0 deletions)

View changed files

📝 convex/auth.ts (+7 -0)
📝 convex/lib/githubAccount.ts (+9 -0)

📄 Description

Greptile Summary

This PR modifies the GitHub profile sync logic in the auth callback and the syncGitHubProfile action, but both files contain duplicate code blocks that appear to be the result of an incomplete merge or rebase — new code was inserted without removing the original logic it was intended to replace.

  • convex/auth.ts: handleDeletedUserSignIn is called twice per sign-in, and syncGitHubProfileAction is scheduled unconditionally (bypassing the 6-hour rate-limit window) in addition to the existing conditional scheduling. Every sign-in will hit the GitHub API unnecessarily.
  • convex/lib/githubAccount.ts: A new early-update block calls syncGitHubProfileInternal without the required syncedAt argument, which will cause a runtime validation error in Convex. The original correct call below it is still present, making this a duplicate that also breaks execution.

Confidence Score: 1/5

  • This PR introduces a runtime-breaking validation error and duplicate logic that should not be merged as-is.
  • The missing required syncedAt argument in githubAccount.ts will cause a Convex validation error at runtime whenever a user's GitHub username has changed, breaking the profile sync feature. Additionally, the duplicate handleDeletedUserSignIn calls and unconditional scheduler invocations in auth.ts bypass the intended rate-limiting, causing unnecessary GitHub API calls on every sign-in.
  • Both convex/auth.ts and convex/lib/githubAccount.ts need attention — the duplicate code blocks in each file need to be resolved by removing either the old or new version of the logic.

Last reviewed commit: 331ba0d

Context used:

  • Context from dashboard - AGENTS.md (source)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/325 **Author:** [@ianalloway](https://github.com/ianalloway) **Created:** 2/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (6) - [`3f4bb8f`](https://github.com/openclaw/clawhub/commit/3f4bb8f6a23aaef34b72ddb7480aaa7e63b0d7f5) fix: sync GitHub profile on login to handle username renames (#303) - [`19ec3e7`](https://github.com/openclaw/clawhub/commit/19ec3e79217067bbf577367dc543345e6b7d9181) Merge pull request #1 from ianalloway/devin/1771109978-fix-github-username-sync - [`7ab1862`](https://github.com/openclaw/clawhub/commit/7ab186234948b071ccb91e7c2c84ce44e17edc98) fix: allow updating skill summary/description on subsequent publishes (#301) - [`36078ad`](https://github.com/openclaw/clawhub/commit/36078ad54ec065dddcef7a822568718b459a3469) Merge pull request #2 from ianalloway/devin/1771112524-skill-metadata-update - [`1d53b25`](https://github.com/openclaw/clawhub/commit/1d53b25aec6e5d1dc34e2a59e01a8e1c24b2a2f1) Merge branch 'main' into main - [`331ba0d`](https://github.com/openclaw/clawhub/commit/331ba0d705798c8a466bd321b862b388e0ff3afa) Update convex/users.ts ### 📊 Changes **2 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `convex/auth.ts` (+7 -0) 📝 `convex/lib/githubAccount.ts` (+9 -0) </details> ### 📄 Description <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR modifies the GitHub profile sync logic in the auth callback and the `syncGitHubProfile` action, but both files contain **duplicate code blocks** that appear to be the result of an incomplete merge or rebase — new code was inserted without removing the original logic it was intended to replace. - **`convex/auth.ts`**: `handleDeletedUserSignIn` is called twice per sign-in, and `syncGitHubProfileAction` is scheduled unconditionally (bypassing the 6-hour rate-limit window) in addition to the existing conditional scheduling. Every sign-in will hit the GitHub API unnecessarily. - **`convex/lib/githubAccount.ts`**: A new early-update block calls `syncGitHubProfileInternal` without the required `syncedAt` argument, which will cause a **runtime validation error** in Convex. The original correct call below it is still present, making this a duplicate that also breaks execution. <h3>Confidence Score: 1/5</h3> - This PR introduces a runtime-breaking validation error and duplicate logic that should not be merged as-is. - The missing required `syncedAt` argument in `githubAccount.ts` will cause a Convex validation error at runtime whenever a user's GitHub username has changed, breaking the profile sync feature. Additionally, the duplicate `handleDeletedUserSignIn` calls and unconditional scheduler invocations in `auth.ts` bypass the intended rate-limiting, causing unnecessary GitHub API calls on every sign-in. - Both `convex/auth.ts` and `convex/lib/githubAccount.ts` need attention — the duplicate code blocks in each file need to be resolved by removing either the old or new version of the logic. <sub>Last reviewed commit: 331ba0d</sub> <!-- greptile_other_comments_section --> **Context used:** - Context from `dashboard` - AGENTS.md ([source](https://app.greptile.com/review/custom-context?memory=a1d58d20-b4dd-4cbb-973a-9fd7824e1921)) <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:56 -05:00
yindo closed this issue 2026-02-15 17:16:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
yindo
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?