[PR #324] [MERGED] UI: don't toggle Details when selecting scan summary #330

Closed
opened 2026-02-15 17:16:57 -05:00 by yindo · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/openclaw/clawhub/pull/324
Author: @steipete
Created: 2/15/2026
Status: Merged
Merged: 2/15/2026
Merged by: @steipete

Base: mainHead: codex/fix-scan-summary-selection


📝 Commits (1)

  • 786af96 fix(ui): prevent analysis toggle when selecting summary

📊 Changes

3 files changed (+9 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 src/components/SkillDetailPage.tsx (+6 -1)
📝 src/styles.css (+2 -0)

📄 Description

Follow-up to #322.

  • Prevent toggle click when user is selecting text (copy/paste)
  • Make summary cursor indicate selectable text
  • Add changelog thanks for @borisolver

Local: bun run lint; bun run test

Greptile Summary

This PR improves UX by preventing the Details section from toggling when users select the security scan summary text. The implementation checks for an active text selection before toggling, and updates CSS to show a text cursor and enable text selection on the summary.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal, well-targeted, and use standard browser APIs correctly. The window.getSelection() API is widely supported and the isCollapsed check is a standard way to detect active text selection. CSS changes are purely cosmetic and properly scoped.
  • No files require special attention

Last reviewed commit: 786af96


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openclaw/clawhub/pull/324 **Author:** [@steipete](https://github.com/steipete) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@steipete](https://github.com/steipete) **Base:** `main` ← **Head:** `codex/fix-scan-summary-selection` --- ### 📝 Commits (1) - [`786af96`](https://github.com/openclaw/clawhub/commit/786af96fd5c14ca215f638f31a730a75f3504cef) fix(ui): prevent analysis toggle when selecting summary ### 📊 Changes **3 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `src/components/SkillDetailPage.tsx` (+6 -1) 📝 `src/styles.css` (+2 -0) </details> ### 📄 Description Follow-up to #322. - Prevent toggle click when user is selecting text (copy/paste) - Make summary cursor indicate selectable text - Add changelog thanks for @borisolver Local: bun run lint; bun run test <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR improves UX by preventing the Details section from toggling when users select the security scan summary text. The implementation checks for an active text selection before toggling, and updates CSS to show a text cursor and enable text selection on the summary. <h3>Confidence Score: 5/5</h3> - This PR is safe to merge with no risk - The changes are minimal, well-targeted, and use standard browser APIs correctly. The `window.getSelection()` API is widely supported and the `isCollapsed` check is a standard way to detect active text selection. CSS changes are purely cosmetic and properly scoped. - No files require special attention <sub>Last reviewed commit: 786af96</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
yindo added the pull-request label 2026-02-15 17:16:57 -05:00
yindo closed this issue 2026-02-15 17:16:57 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: openclaw/clawhub#330