openharmony/ark_js_runtime
1
0
Fork 0
mirror of https://github.com/openharmony/ark_js_runtime.git synced 2026-08-26 18:06:39 -04:00
Code Issues 1 Packages Projects Releases Wiki Activity

JSON Stringify support BigInt

Browse Source 
add bigint tostring when Stringify a bigint property

issue:https://gitee.com/openharmony/ark_js_runtime/issues/I5DBN9

Signed-off-by: suchongwei <suchongwei@huawei.com>
This commit is contained in:
suchongwei
2022-06-21 14:08:03 +08:00
parent 5d516b05fc
commit a69e71059a
2 changed files with 35 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ecmascript/base/json_stringifier.cpp
+4
View File
@@ -374,6 +374,10 @@ JSTaggedValue JsonStringifier::SerializeJSONProperty(const JSHandle<JSTaggedValu
}
case JSType::SYMBOL:
return JSTaggedValue::Undefined();
case JSType::BIGINT: {
result_ += ConvertToString(*BigInt::ToString(thread_, JSHandle<BigInt>(valHandle)));
return tagValue;
}
default: {
if (!tagValue.IsCallable()) {
JSHClass *jsHclass = tagValue.GetTaggedObject()->GetClass();
ecmascript/builtins/tests/builtins_json_test.cpp
+31 -1
View File
@@ -18,6 +18,7 @@
#include "algorithm"
#include "ecmascript/base/builtins_base.h"
#include "ecmascript/builtins/builtins_bigint.h"
#include "ecmascript/builtins/builtins_errors.h"
#include "ecmascript/builtins/builtins_json.h"
#include "ecmascript/builtins/builtins_proxy.h"
@@ -512,7 +513,7 @@ HWTEST_F_L0(BuiltinsJsonTest, Stringify4) // Test for proxy object
ASSERT_TRUE(EcmaString::StringsAreEqual(*test, EcmaString::Cast(result.GetTaggedObject())));
}
HWTEST_F_L0(BuiltinsJsonTest, Stringify5) // Test for proxy object
HWTEST_F_L0(BuiltinsJsonTest, Stringify5) // Test for typedarray object
{
auto ecmaVM = thread->GetEcmaVM();
ObjectFactory *factory = ecmaVM->GetFactory();
@@ -545,4 +546,33 @@ HWTEST_F_L0(BuiltinsJsonTest, Stringify5) // Test for proxy object
ASSERT_TRUE(result.IsString());
ASSERT_TRUE(EcmaString::StringsAreEqual(*test, EcmaString::Cast(result.GetTaggedObject())));
}
HWTEST_F_L0(BuiltinsJsonTest, Stringify6) // Test for bigint object
{
ObjectFactory *factory = thread->GetEcmaVM()->GetFactory();
JSHandle<JSTaggedValue> numericValue(factory->NewFromASCII("123456789123456789"));
auto ecmaRuntimeCallInfo1 = TestHelper::CreateEcmaRuntimeCallInfo(thread, JSTaggedValue::Undefined(), 6);
ecmaRuntimeCallInfo1->SetFunction(JSTaggedValue::Undefined());
ecmaRuntimeCallInfo1->SetThis(JSTaggedValue::Undefined());
ecmaRuntimeCallInfo1->SetCallArg(0, numericValue.GetTaggedValue());
[[maybe_unused]] auto prev = TestHelper::SetupFrame(thread, ecmaRuntimeCallInfo1.get());
JSTaggedValue result1 = BuiltinsBigInt::BigIntConstructor(ecmaRuntimeCallInfo1.get());
TestHelper::TearDownFrame(thread, prev);
JSHandle<JSTaggedValue> bigIntHandle(thread, result1);
auto ecmaRuntimeCallInfo = TestHelper::CreateEcmaRuntimeCallInfo(thread, JSTaggedValue::Undefined(), 6);
ecmaRuntimeCallInfo->SetFunction(JSTaggedValue::Undefined());
ecmaRuntimeCallInfo->SetThis(JSTaggedValue::Undefined());
ecmaRuntimeCallInfo->SetCallArg(0, bigIntHandle.GetTaggedValue());
prev = TestHelper::SetupFrame(thread, ecmaRuntimeCallInfo.get());
JSTaggedValue result = BuiltinsJson::Stringify(ecmaRuntimeCallInfo.get());
CString str = ConvertToString(EcmaString::Cast(result.GetTaggedObject()));
ASSERT_TRUE(result.IsString());
ASSERT_TRUE(EcmaString::StringsAreEqual(EcmaString::Cast(numericValue.GetTaggedValue().GetTaggedObject()),
EcmaString::Cast(result.GetTaggedObject())));
}
} // namespace panda::test