!7939 [JIT] fix load string length from raw value

Merge pull request !7939 from xiaoweidong/fix_string_len

ecmascript/compiler/number_speculative_retype.cpp

@@ -1414,6 +1414,16 @@ GateRef NumberSpeculativeRetype::VisitLoadStringLength(GateRef gate)
         return SetOutputType(gate, GateType::IntType());
     }
 
+    if (IsConvert()) {
+        GateRef input = acc_.GetValueIn(gate, 0);
+        TypeInfo typeInfo = GetOutputTypeInfo(input);
+        if (typeInfo == TypeInfo::CHAR) {
+            acc_.ReplaceValueIn(gate, ConvertToTagged(input), 0);
+        } else if (typeInfo != TypeInfo::TAGGED) {
+            LOG_COMPILER(FATAL) << "should be tagged type";
+            UNREACHABLE();
+        }
+    }
     return Circuit::NullGate();
 }
 

test/jittest/BUILD.gn

@@ -23,6 +23,7 @@ group("ark_jit_ts_test") {
     "construct_with_normal_function",
     "addition_assignment",
     "catch_with_osr",
+    "string_length",
     "ts_inline",
   ]
 

test/jittest/ldobjbyname/BUILD.gn

@@ -1,4 +1,4 @@
-# Copyright (c) 2021 Huawei Device Co., Ltd.
+# Copyright (c) 2024 Huawei Device Co., Ltd.
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at

test/jittest/ldobjbyname/ldobjbyname.ts

@@ -14,9 +14,9 @@
  */
 
 class Rectangle {
-  constructor(height, width) {
-    this.height = height;
-    this.width = width;
+    constructor(height, width) {
+        this.height = height;
+        this.width = width;
   }
 }
 

test/jittest/string_length/BUILD.gn

@@ -0,0 +1,18 @@
+# Copyright (c) 2024 Huawei Device Co., Ltd.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import("//arkcompiler/ets_runtime/test/test_helper.gni")
+
+host_jit_test_action("string_length") {
+  deps = []
+}

test/jittest/string_length/expect_output.txt

@@ -0,0 +1,15 @@
+# Copyright (c) 2024 Huawei Device Co., Ltd.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+true
+97

test/jittest/string_length/string_length.ts

@@ -0,0 +1,31 @@
+/*
+ * Copyright (c) 2024 Huawei Device Co., Ltd.
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+function f(arg) {
+    let v = arg[0];
+    let c = v.charCodeAt(0);
+    return v.length > 0 ? c : ".";
+}
+
+let ss = "abcdefg"
+for (let i = 0; i < 20; i++) {
+    f(ss)
+}
+
+ArkTools.jitCompileAsync(f);
+let res = ArkTools.waitJitCompileFinish(f);
+print(res)
+
+print(f(ss))