openharmony/arkcompiler_ets_runtime
1
0
Fork 0
mirror of https://gitee.com/openharmony/arkcompiler_ets_runtime synced 2024-11-23 10:09:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

!2 Adapt new isTrue/False instruction

Browse Source 
Merge pull request !2 from yycc/istrue

Change-Id: I738f134baf83d74a23083848a67fe33a4efccbb8
This commit is contained in:
jiangmengyang 2024-05-23 13:37:24 +00:00
commit 6f457ac079
20 changed files with 316 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
ecmascript/compiler/baseline/baseline_call_signature.cpp
View File

@ -4165,6 +4165,38 @@ DEF_CALL_SIGNATURE(BaselineCallRuntimeLdSendableClassPrefImm16)
BASELINE_STUB_CALL_SIGNATURE_COMMON_SET();
}
DEF_CALL_SIGNATURE(BaselineCallRuntimeIstruePrefImm8)
{
// 4 : 4 input parameters
CallSignature signature("BaselineCallRuntimeIstruePrefImm8", 0, 4,
ArgumentsOrder::DEFAULT_ORDER, VariableType::JS_ANY());
*callSign = signature;
// 4 : 4 input parameters
std::array<VariableType, 4> params = {
VariableType::NATIVE_POINTER(),
VariableType::NATIVE_POINTER(),
VariableType::JS_ANY(),
VariableType::INT8(),
};
BASELINE_STUB_CALL_SIGNATURE_COMMON_SET();
}
DEF_CALL_SIGNATURE(BaselineCallRuntimeIsfalsePrefImm8)
{
// 4 : 4 input parameters
CallSignature signature("BaselineCallRuntimeIsfalsePrefImm8", 0, 4,
ArgumentsOrder::DEFAULT_ORDER, VariableType::JS_ANY());
*callSign = signature;
// 4 : 4 input parameters
std::array<VariableType, 4> params = {
VariableType::NATIVE_POINTER(),
VariableType::NATIVE_POINTER(),
VariableType::JS_ANY(),
VariableType::INT8(),
};
BASELINE_STUB_CALL_SIGNATURE_COMMON_SET();
}
// GLUE, ACC, SP
DEF_CALL_SIGNATURE(BaselineReturnundefined)
{

4
ecmascript/compiler/baseline/baseline_call_signature.h
View File

@ -593,6 +593,10 @@ DEFINE_PARAMETER_INDEX(BaselineCallRuntimeDefineSendableClassPrefImm16Id16Id16Im
GLUE, SP, METHOD_ID, LITERAL_ID, LENGTH, V0)
DEFINE_PARAMETER_INDEX(BaselineCallRuntimeLdSendableClassPrefImm16,
GLUE, SP, ACC, LEVEL)
DEFINE_PARAMETER_INDEX(BaselineCallRuntimeIstruePrefImm8,
GLUE, SP, ACC, V0)
DEFINE_PARAMETER_INDEX(BaselineCallRuntimeIsfalsePrefImm8,
GLUE, SP, ACC, V0)
DEFINE_PARAMETER_INDEX(BaselineReturnundefined, GLUE, ACC, SP)
DEFINE_PARAMETER_INDEX(BaselineExceptionHandler,
GLUE, ACC, SP, PROFILE_TYPE_INFO, HOTNESS_COUNTER, FRAME)

31
ecmascript/compiler/baseline/baseline_compiler.cpp
View File

@ -3166,6 +3166,21 @@ BYTECODE_BASELINE_HANDLER_IMPLEMENT(ISTRUE)
GetBaselineAssembler().SaveResultIntoAcc();
}
BYTECODE_BASELINE_HANDLER_IMPLEMENT(CALLRUNTIME_ISTRUE_PREF_IMM8)
{
(void)bytecodeArray;
auto *thread = vm->GetAssociatedJSThread();
Address builtinAddress =
thread->GetBaselineStubEntry(BaselineStubCSigns::BaselineCallRuntimeIstruePrefImm8);
LOG_INST() << " BaselineCallRuntimeIstruePrefImm8 Address: " << std::hex << builtinAddress;
std::vector<BaselineParameter> parameters;
parameters.emplace_back(BaselineSpecialParameter::ACC);
GetBaselineAssembler().CallBuiltin(builtinAddress, parameters);
GetBaselineAssembler().SaveResultIntoAcc();
}
BYTECODE_BASELINE_HANDLER_IMPLEMENT(ISFALSE)
{
(void)bytecodeArray;
@ -3180,6 +3195,22 @@ BYTECODE_BASELINE_HANDLER_IMPLEMENT(ISFALSE)
GetBaselineAssembler().CallBuiltin(builtinAddress, parameters);
GetBaselineAssembler().SaveResultIntoAcc();
}
BYTECODE_BASELINE_HANDLER_IMPLEMENT(CALLRUNTIME_ISFALSE_PREF_IMM8)
{
(void)bytecodeArray;
auto *thread = vm->GetAssociatedJSThread();
Address builtinAddress =
thread->GetBaselineStubEntry(BaselineStubCSigns::BaselineCallRuntimeIsfalsePrefImm8);
LOG_INST() << " BaselineCallRuntimeIsfalsePrefImm8 Address: " << std::hex << builtinAddress;
std::vector<BaselineParameter> parameters;
parameters.emplace_back(BaselineSpecialParameter::ACC);
GetBaselineAssembler().CallBuiltin(builtinAddress, parameters);
GetBaselineAssembler().SaveResultIntoAcc();
}
// ------- End parse bytecodes about comparison -------
// ------- parse bytecodes about control flow -------

2
ecmascript/compiler/baseline/baseline_compiler_builtins.h
View File

@ -282,6 +282,8 @@ namespace panda::ecmascript::kungfu {
V(BaselineCallRuntimeCallInitPrefImm8V8) \
V(BaselineCallRuntimeDefineSendableClassPrefImm16Id16Id16Imm16V8) \
V(BaselineCallRuntimeLdSendableClassPrefImm16) \
V(BaselineCallRuntimeIstruePrefImm8) \
V(BaselineCallRuntimeIsfalsePrefImm8) \
V(BaselineReturnundefined) \
V(BaselineExceptionHandler) \
V(BaselineUpdateHotness) \

19
ecmascript/compiler/baseline/baseline_stubs.cpp
View File

@ -1181,6 +1181,15 @@ void BaselineIstrueStubBuilder::GenerateCircuit()
Return(*varAcc);
}
void BaselineCallRuntimeIstruePrefImm8StubBuilder::GenerateCircuit()
{
GateRef acc = TaggedArgument(PARAM_INDEX(BaselineCallRuntimeIstruePrefImm8, ACC));
DEFVARIABLE(varAcc, VariableType::JS_ANY(), acc);
varAcc = FastToBooleanBaseline(*varAcc, true);
Return(*varAcc);
}
void BaselineIsfalseStubBuilder::GenerateCircuit()
{
GateRef acc = TaggedArgument(PARAM_INDEX(BaselineIsfalse, ACC));
@ -1190,6 +1199,16 @@ void BaselineIsfalseStubBuilder::GenerateCircuit()
Return(*varAcc);
}
void BaselineCallRuntimeIsfalsePrefImm8StubBuilder::GenerateCircuit()
{
GateRef acc = TaggedArgument(PARAM_INDEX(BaselineCallRuntimeIsfalsePrefImm8, ACC));
DEFVARIABLE(varAcc, VariableType::JS_ANY(), acc);
varAcc = FastToBooleanBaseline(*varAcc, false);
Return(*varAcc);
}
void BaselineCallthis3Imm8V8V8V8V8StubBuilder::GenerateCircuit()
{
GateRef glue = PtrArgument(PARAM_INDEX(BaselineCallthis3Imm8V8V8V8V8, GLUE));

8
ecmascript/compiler/bc_call_signature.h
View File

@ -390,7 +390,9 @@ namespace panda::ecmascript::kungfu {
T(HandleCallRuntimeStSendableVarImm16Imm16) \
T(HandleCallRuntimeLdSendableVarImm4Imm4) \
T(HandleCallRuntimeLdSendableVarImm8Imm8) \
T(HandleCallRuntimeLdSendableVarImm16Imm16)
T(HandleCallRuntimeLdSendableVarImm16Imm16) \
T(HandleCallRuntimeIstruePrefImm8) \
T(HandleCallRuntimeIsfalsePrefImm8)
#define ASM_INTERPRETER_BC_HELPER_STUB_LIST(V) \
V(SingleStepDebugging) \
@ -465,7 +467,9 @@ namespace panda::ecmascript::kungfu {
APPEND_SUFFIX(HandleGreatereqImm8V8, V) \
APPEND_SUFFIX(HandleStrictnoteqImm8V8, V) \
APPEND_SUFFIX(HandleStricteqImm8V8, V) \
APPEND_SUFFIX(HandleTonumericImm8, V)
APPEND_SUFFIX(HandleTonumericImm8, V) \
APPEND_SUFFIX_IMM8_SECONDBC(HandleCallRuntimeIstruePrefImm8, V) \
APPEND_SUFFIX_IMM8_SECONDBC(HandleCallRuntimeIsfalsePrefImm8, V) \
#define ASM_INTERPRETER_BC_FUNC_HOT_PROFILER_STUB_LIST(V) \
APPEND_SUFFIX(HandleJmpImm8, V) \

8
ecmascript/compiler/bytecodes.cpp
View File

@ -42,6 +42,8 @@ BytecodeMetaData BytecodeMetaData::InitBytecodeMetaData(const uint8_t *pc)
case EcmaOpcode::WIDE_GETMODULENAMESPACE_PREF_IMM16:
case EcmaOpcode::ISTRUE:
case EcmaOpcode::ISFALSE:
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8:
case EcmaOpcode::LDGLOBALVAR_IMM16_ID16:
case EcmaOpcode::LDOBJBYINDEX_IMM8_IMM16:
case EcmaOpcode::LDOBJBYINDEX_IMM16_IMM16:
@ -122,6 +124,8 @@ BytecodeMetaData BytecodeMetaData::InitBytecodeMetaData(const uint8_t *pc)
case EcmaOpcode::TYPEOF_IMM16:
case EcmaOpcode::ISTRUE:
case EcmaOpcode::ISFALSE:
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8:
case EcmaOpcode::JEQZ_IMM8:
case EcmaOpcode::JEQZ_IMM16:
case EcmaOpcode::JEQZ_IMM32:
@ -231,6 +235,8 @@ BytecodeMetaData BytecodeMetaData::InitBytecodeMetaData(const uint8_t *pc)
case EcmaOpcode::TONUMERIC_IMM8:
case EcmaOpcode::ISTRUE:
case EcmaOpcode::ISFALSE:
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8:
case EcmaOpcode::INC_IMM8:
case EcmaOpcode::DEC_IMM8:
case EcmaOpcode::NEG_IMM8:
@ -1829,6 +1835,8 @@ void BytecodeInfo::InitBytecodeInfo(BytecodeCircuitBuilder *builder,
case EcmaOpcode::DEBUGGER:
case EcmaOpcode::ISTRUE:
case EcmaOpcode::ISFALSE:
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8:
case EcmaOpcode::NOP:
case EcmaOpcode::GETITERATOR_IMM8:
case EcmaOpcode::GETITERATOR_IMM16:

2
ecmascript/compiler/bytecodes.h
View File

@ -282,7 +282,7 @@ public:
static constexpr uint32_t LAST_THROW_OPCODE =
static_cast<uint32_t>(EcmaOpcode::THROW_UNDEFINEDIFHOLEWITHNAME_PREF_ID16);
static constexpr uint32_t LAST_CALLRUNTIME_OPCODE =
static_cast<uint32_t>(EcmaOpcode::CALLRUNTIME_WIDELDSENDABLEVAR_PREF_IMM16_IMM16);
static_cast<uint32_t>(EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8);
static_assert(CALLRUNTIME_PREFIX_OPCODE_INDEX ==
static_cast<uint32_t>(EcmaOpcode::CALLRUNTIME_NOTIFYCONCURRENTRESULT_PREF_NONE));

2
ecmascript/compiler/ecma_opcode_des.h
View File

@ -338,6 +338,8 @@ namespace panda::ecmascript::kungfu {
V(CALLRUNTIME_LDSENDABLEVAR_PREF_IMM4_IMM4) \
V(CALLRUNTIME_LDSENDABLEVAR_PREF_IMM8_IMM8) \
V(CALLRUNTIME_WIDELDSENDABLEVAR_PREF_IMM16_IMM16) \
V(CALLRUNTIME_ISTRUE_PREF_IMM8) \
V(CALLRUNTIME_ISFALSE_PREF_IMM8) \
inline std::string GetEcmaOpcodeStr(EcmaOpcode opcode)
{

14
ecmascript/compiler/interpreter_stub.cpp
View File

@ -3130,6 +3130,13 @@ DECLARE_ASM_HANDLER(HandleIstrue)
DISPATCH_WITH_ACC(ISTRUE);
}
DECLARE_ASM_HANDLER(HandleCallRuntimeIstruePrefImm8)
{
DEFVARIABLE(varAcc, VariableType::JS_ANY(), acc);
varAcc = FastToBooleanWithProfile(*varAcc, callback, true);
DISPATCH_WITH_ACC(CALLRUNTIME_ISTRUE_PREF_IMM8);
}
DECLARE_ASM_HANDLER(HandleIsfalse)
{
DEFVARIABLE(varAcc, VariableType::JS_ANY(), acc);
@ -3137,6 +3144,13 @@ DECLARE_ASM_HANDLER(HandleIsfalse)
DISPATCH_WITH_ACC(ISFALSE);
}
DECLARE_ASM_HANDLER(HandleCallRuntimeIsfalsePrefImm8)
{
DEFVARIABLE(varAcc, VariableType::JS_ANY(), acc);
varAcc = FastToBooleanWithProfile(*varAcc, callback, false);
DISPATCH_WITH_ACC(CALLRUNTIME_ISFALSE_PREF_IMM8);
}
DECLARE_ASM_HANDLER(HandleTonumberImm8)
{
auto env = GetEnvironment();

2
ecmascript/compiler/slowpath_lowering.cpp
View File

@ -510,9 +510,11 @@ void SlowPathLowering::Lower(GateRef gate)
LowerSuperCallSpread(gate);
break;
case EcmaOpcode::ISTRUE:
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
LowerIsTrueOrFalse(gate, true);
break;
case EcmaOpcode::ISFALSE:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8:
LowerIsTrueOrFalse(gate, false);
break;
case EcmaOpcode::GETNEXTPROPNAME_V8:

120
ecmascript/compiler/stub_builder.cpp
View File

@ -5903,6 +5903,126 @@ GateRef StubBuilder::FastToBooleanBaseline(GateRef value, bool flag)
return ret;
}
GateRef StubBuilder::FastToBooleanWithProfile(GateRef value, ProfileOperation callback, bool flag)
{
auto env = GetEnvironment();
Label entry(env);
env->SubCfgEntry(&entry);
DEFVARIABLE(result, VariableType::JS_ANY(), Hole());
Label exit(env);
Label isSpecial(env);
Label notSpecial(env);
Label isNumber(env);
Label isInt(env);
Label isDouble(env);
Label notNumber(env);
Label notNan(env);
Label isString(env);
Label notString(env);
Label isBigint(env);
Label lengthIsOne(env);
Label returnTrue(env);
Label returnFalse(env);
Label isTrue(env);
Label isNotTrue(env);
Label isFalse(env);
Label isNotFalse(env);
BRANCH(TaggedIsSpecial(value), &isSpecial, &notSpecial);
Bind(&isSpecial);
{
BRANCH(TaggedIsTrue(value), &isTrue, &isNotTrue);
Bind(&isTrue);
{
callback.ProfileOpType(Int32(PGOSampleType::BooleanType()));
Jump(&returnTrue);
}
Bind(&isNotTrue);
{
BRANCH(TaggedIsFalse(value), &isFalse, &isNotFalse);
Bind(&isFalse);
{
callback.ProfileOpType(Int32(PGOSampleType::BooleanType()));
Jump(&returnFalse);
}
}
Bind(&isNotFalse);
Jump(&returnFalse);
}
Bind(&notSpecial);
{
BRANCH(TaggedIsNumber(value), &isNumber, &notNumber);
Bind(&notNumber);
{
BRANCH(IsString(value), &isString, &notString);
Bind(&isString);
{
auto len = GetLengthFromString(value);
BRANCH(Int32Equal(len, Int32(0)), &returnFalse, &returnTrue);
}
Bind(&notString);
BRANCH(TaggedObjectIsBigInt(value), &isBigint, &returnTrue);
Bind(&isBigint);
{
auto len = Load(VariableType::INT32(), value, IntPtr(BigInt::LENGTH_OFFSET));
BRANCH(Int32Equal(len, Int32(1)), &lengthIsOne, &returnTrue);
Bind(&lengthIsOne);
{
auto data = PtrAdd(value, IntPtr(BigInt::DATA_OFFSET));
auto data0 = Load(VariableType::INT32(), data, Int32(0));
BRANCH(Int32Equal(data0, Int32(0)), &returnFalse, &returnTrue);
}
}
}
Bind(&isNumber);
{
callback.ProfileOpType(Int32(PGOSampleType::NumberType()));
BRANCH(TaggedIsInt(value), &isInt, &isDouble);
Bind(&isInt);
{
auto intValue = GetInt32OfTInt(value);
BRANCH(Int32Equal(intValue, Int32(0)), &returnFalse, &returnTrue);
}
Bind(&isDouble);
{
auto doubleValue = GetDoubleOfTDouble(value);
BRANCH(DoubleIsNAN(doubleValue), &returnFalse, &notNan);
Bind(&notNan);
BRANCH(DoubleEqual(doubleValue, Double(0.0)), &returnFalse, &returnTrue);
}
}
}
if (flag == 1) {
Bind(&returnTrue);
{
result = TaggedTrue();
Jump(&exit);
}
Bind(&returnFalse);
{
result = TaggedFalse();
Jump(&exit);
}
} else {
Bind(&returnFalse);
{
result = TaggedTrue();
Jump(&exit);
}
Bind(&returnTrue);
{
result = TaggedFalse();
Jump(&exit);
}
}
Bind(&exit);
auto ret = *result;
env->SubCfgExit();
return ret;
}
GateRef StubBuilder::FastDiv(GateRef left, GateRef right, ProfileOperation callback)
{
auto env = GetEnvironment();

1
ecmascript/compiler/stub_builder.h
View File

@ -736,6 +736,7 @@ public:
GateRef FastSub(GateRef glue, GateRef left, GateRef right, ProfileOperation callback);
GateRef FastToBoolean(GateRef value, bool flag = true);
GateRef FastToBooleanBaseline(GateRef value, bool flag = true);
GateRef FastToBooleanWithProfile(GateRef value, ProfileOperation callback, bool flag = true);
// Add SpecialContainer
GateRef GetContainerProperty(GateRef glue, GateRef receiver, GateRef index, GateRef jsType);

15
ecmascript/compiler/typed_bytecode_lowering.cpp
View File

@ -229,9 +229,11 @@ void TypedBytecodeLowering::Lower(GateRef gate)
LowerTypedEqOrNotEq<TypedBinOp::TYPED_STRICTEQ>(gate);
break;
case EcmaOpcode::ISTRUE:
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
LowerTypedIsTrueOrFalse(gate, true);
break;
case EcmaOpcode::ISFALSE:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8:
LowerTypedIsTrueOrFalse(gate, false);
break;
case EcmaOpcode::CALLTHIS3_IMM8_V8_V8_V8_V8:
@ -1366,13 +1368,22 @@ void TypedBytecodeLowering::LowerTypedStObjByValue(GateRef gate)
}
}
bool TypedBytecodeLowering::IsTrueOrFalseHasProfileType(GateRef gate) const
{
ASSERT(acc_.GetOpCode(gate) == OpCode::JS_BYTECODE);
return acc_.GetByteCodeOpcode(gate) == EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8 ||
acc_.GetByteCodeOpcode(gate) == EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8;
}
void TypedBytecodeLowering::LowerTypedIsTrueOrFalse(GateRef gate, bool flag)
{
UnOpTypeInfoAccessor tacc(compilationEnv_, circuit_, gate);
ParamType paramType;
if (TypeInfoAccessor::IsTrustedBooleanType(acc_, tacc.GetValue())) {
if (TypeInfoAccessor::IsTrustedBooleanType(acc_, tacc.GetValue()) ||
(IsTrueOrFalseHasProfileType(gate) && tacc.IsBooleanType())) {
paramType = ParamType::BooleanType();
} else if (TypeInfoAccessor::IsTrustedNumberType(acc_, tacc.GetValue())) {
} else if (TypeInfoAccessor::IsTrustedNumberType(acc_, tacc.GetValue()) ||
(IsTrueOrFalseHasProfileType(gate) && tacc.HasNumberType())) {
paramType = ParamType::NumberType();
} else {
return;

1
ecmascript/compiler/typed_bytecode_lowering.h
View File

@ -215,6 +215,7 @@ private:
bool TryLowerNewBuiltinConstructor(GateRef gate);
bool TryLowerTypedLdobjBynameFromGloablBuiltin(GateRef gate);
bool CheckIsInOptBCIgnoreRange(int32_t index, EcmaOpcode ecmaOpcode);
bool IsTrueOrFalseHasProfileType(GateRef gate) const;
int32_t GetEcmaOpCodeListIndex(EcmaOpcode ecmaOpCode);
void ParseOptBytecodeRange();

20
ecmascript/interpreter/interpreter-inl.cpp
View File

@ -1019,7 +1019,7 @@ NO_UB_SANITIZE void EcmaInterpreter::RunInternal(JSThread *thread, const uint8_t
constexpr size_t numOps = 0x100;
constexpr size_t numThrowOps = 10;
constexpr size_t numWideOps = 20;
constexpr size_t numCallRuntimeOps = 19;
constexpr size_t numCallRuntimeOps = 21;
constexpr size_t numDeprecatedOps = 47;
static std::array<const void *, numOps> instDispatchTable {
@ -3817,6 +3817,15 @@ NO_UB_SANITIZE void EcmaInterpreter::RunInternal(JSThread *thread, const uint8_t
}
DISPATCH(ISTRUE);
}
HANDLE_OPCODE(CALLRUNTIME_ISTRUE_PREF_IMM8) {
LOG_INST() << "intrinsics::callruntime.istrue";
if (GET_ACC().ToBoolean()) {
SET_ACC(JSTaggedValue::True());
} else {
SET_ACC(JSTaggedValue::False());
}
DISPATCH(CALLRUNTIME_ISTRUE_PREF_IMM8);
}
HANDLE_OPCODE(ISFALSE) {
LOG_INST() << "intrinsics::isfalse";
if (!GET_ACC().ToBoolean()) {
@ -3826,6 +3835,15 @@ NO_UB_SANITIZE void EcmaInterpreter::RunInternal(JSThread *thread, const uint8_t
}
DISPATCH(ISFALSE);
}
HANDLE_OPCODE(CALLRUNTIME_ISFALSE_PREF_IMM8) {
LOG_INST() << "intrinsics::callruntime.isfalse";
if (!GET_ACC().ToBoolean()) {
SET_ACC(JSTaggedValue::True());
} else {
SET_ACC(JSTaggedValue::False());
}
DISPATCH(CALLRUNTIME_ISFALSE_PREF_IMM8);
}
NOPRINT_HANDLE_OPCODE(EXCEPTION) {
FrameHandler frameHandler(thread);
uint32_t pcOffset = panda_file::INVALID_OFFSET;

32
ecmascript/interpreter/interpreter_assembly.cpp
View File

@ -2960,19 +2960,45 @@ void InterpreterAssembly::HandleIstrue(
DISPATCH(ISTRUE);
}
void InterpreterAssembly::HandleCallRuntimeIstruePrefImm8(
JSThread *thread, const uint8_t *pc, JSTaggedType *sp, JSTaggedValue constpool, JSTaggedValue profileTypeInfo,
JSTaggedValue acc, int16_t hotnessCounter)
{
LOG_INST() << "intrinsics::callruntimeistrueprefimm8";
if (GET_ACC().ToBoolean()) {
SET_ACC(JSTaggedValue::True());
} else {
SET_ACC(JSTaggedValue::False());
}
DISPATCH(CALLRUNTIME_ISTRUE_PREF_IMM8);
}
void InterpreterAssembly::HandleIsfalse(
JSThread *thread, const uint8_t *pc, JSTaggedType *sp, JSTaggedValue constpool, JSTaggedValue profileTypeInfo,
JSTaggedValue acc, int16_t hotnessCounter)
{
LOG_INST() << "intrinsics::isfalse";
if (!GET_ACC().ToBoolean()) {
SET_ACC(JSTaggedValue::True());
} else {
if (GET_ACC().ToBoolean()) {
SET_ACC(JSTaggedValue::False());
} else {
SET_ACC(JSTaggedValue::True());
}
DISPATCH(ISFALSE);
}
void InterpreterAssembly::HandleCallRuntimeIsfalsePrefImm8(
JSThread *thread, const uint8_t *pc, JSTaggedType *sp, JSTaggedValue constpool, JSTaggedValue profileTypeInfo,
JSTaggedValue acc, int16_t hotnessCounter)
{
LOG_INST() << "intrinsics::callruntimeisfalseprefimm8";
if (GET_ACC().ToBoolean()) {
SET_ACC(JSTaggedValue::False());
} else {
SET_ACC(JSTaggedValue::True());
}
DISPATCH(CALLRUNTIME_ISFALSE_PREF_IMM8);
}
void InterpreterAssembly::HandleTypeofImm16(
JSThread *thread, const uint8_t *pc, JSTaggedType *sp, JSTaggedValue constpool, JSTaggedValue profileTypeInfo,
JSTaggedValue acc, int16_t hotnessCounter)

4
ecmascript/interpreter/templates/call_runtime_instruction_dispatch.inl
View File

@ -31,4 +31,6 @@
&&HANDLE_CALLRUNTIME_WIDESTSENDABLEVAR_PREF_IMM16_IMM16,
&&HANDLE_CALLRUNTIME_LDSENDABLEVAR_PREF_IMM4_IMM4,
&&HANDLE_CALLRUNTIME_LDSENDABLEVAR_PREF_IMM8_IMM8,
&&HANDLE_CALLRUNTIME_WIDELDSENDABLEVAR_PREF_IMM16_IMM16,
&&HANDLE_CALLRUNTIME_WIDELDSENDABLEVAR_PREF_IMM16_IMM16,
&&HANDLE_CALLRUNTIME_ISTRUE_PREF_IMM8,
&&HANDLE_CALLRUNTIME_ISFALSE_PREF_IMM8,

7
ecmascript/pgo_profiler/pgo_profiler.cpp
View File

@ -698,6 +698,13 @@ void PGOProfiler::ProfileBytecode(ApEntityId abcId, const CString &recordName, J
DumpOpType(abcId, recordName, methodId, bcOffset, slotId, profileTypeInfo);
break;
}
case EcmaOpcode::CALLRUNTIME_ISTRUE_PREF_IMM8:
case EcmaOpcode::CALLRUNTIME_ISFALSE_PREF_IMM8: {
uint8_t slotId = READ_INST_8_1();
CHECK_SLOTID_BREAK(slotId);
DumpOpType(abcId, recordName, methodId, bcOffset, slotId, profileTypeInfo);
break;
}
// Call
case EcmaOpcode::CALLARG0_IMM8:
case EcmaOpcode::CALLARG1_IMM8_V8:

3
test/aottest/definefieldbyname/definefieldbyname.js
View File

@ -28,6 +28,7 @@ const b = new B();
print(b.x);
for (let i = 0; i < 400; i ++){
for (let i = 0; i < 400; i++){
// warm up profile type info
}
print(new B().x);