openharmony/arkcompiler_runtime_core
1
0
Fork 0
mirror of https://gitee.com/openharmony/arkcompiler_runtime_core synced 2024-11-24 07:10:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

!324 Fix failed to operate file of length over 260 issue on Windows

Browse Source 
Merge pull request !324 from huangyu/fix_win_long_path_squash
This commit is contained in:
openharmony_ci 2023-01-09 07:41:20 +00:00 committed by Gitee
commit 206af6c653
No known key found for this signature in database
GPG Key ID: 173E9B9CA92EEF8F
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
platforms/windows/libpandabase/file.h
View File

@ -30,6 +30,10 @@
namespace panda::os::windows::file { namespace panda::os::windows::file {
// In windows API, the length of a path has a limitation of MAX_PATH, which is defined as 260 characters,
// the "\\?\" prefix is used to specify an extended-length path for a maximum length of 32,767 characters.
static const std::string PREFIX_FOR_LONG_PATH = "\\\\?\\";
class File { class File {
public: public:
explicit File(int fd) : fd_(fd) {} explicit File(int fd) : fd_(fd) {}
@ -112,7 +116,8 @@ public:
static Expected<std::string, Error> GetAbsolutePath(std::string_view relative_path) static Expected<std::string, Error> GetAbsolutePath(std::string_view relative_path)
{ {
std::array<char, _MAX_PATH> buffer = {0}; constexpr size_t MAX_PATH_LEN = 2048;
std::array<char, MAX_PATH_LEN> buffer = {0};
auto fp = _fullpath(buffer.data(), relative_path.data(), buffer.size() - 1); auto fp = _fullpath(buffer.data(), relative_path.data(), buffer.size() - 1);
if (fp == nullptr) { if (fp == nullptr) {
return Unexpected(Error(errno)); return Unexpected(Error(errno));
@ -121,6 +126,15 @@ public:
return std::string(fp); return std::string(fp);
} }
static const std::string GetExtendedLengthStylePath(const std::string &path)
{
// PREFIX_FOR_LONG_PATH is added to specify it's an extended-length path,
// and the path needs to be composed of names seperated by backslashes
std::string extendedPath = PREFIX_FOR_LONG_PATH + path;
std::replace(extendedPath.begin(), extendedPath.end(), '/', '\\');
return extendedPath;
}
static bool IsDirectory(const std::string &path) static bool IsDirectory(const std::string &path)
{ {
return HasStatMode(path, _S_IFDIR); return HasStatMode(path, _S_IFDIR);
@ -177,7 +191,11 @@ private:
{ {
struct _stat s = {}; struct _stat s = {};
if (_stat(path.c_str(), &s) != 0) { std::string tmp_path = path;
if (UNLIKELY(path.length() >= _MAX_PATH)) {
tmp_path = GetExtendedLengthStylePath(path);
}
if (_stat(tmp_path.c_str(), &s) != 0) {
return false; return false;
} }