openharmony/arkcompiler_runtime_core
1
0
Fork 0
mirror of https://gitee.com/openharmony/arkcompiler_runtime_core synced 2025-02-25 17:43:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Codestyle] Fixed commented code and other things

Browse Source 
Issue: #I8RW9U

Testing: ninja all tests

Signed-off-by: Konstantin Grebenschikov <grebenschikov.konstantin@huawei.com>
This commit is contained in:
Konstantin Grebenschikov 2024-01-11 16:53:06 +03:00 committed by Petrov Igor
parent b7ff74f5e5
commit 29a051c51f
7 changed files with 142 additions and 129 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
static_core/libpandafile/file_items.cpp
View File

@ -167,7 +167,7 @@ StringItem::StringItem(File::StringData data)
size_t StringItem::CalculateSize() const
{
size_t n = str_.size();
return leb128::UnsignedEncodingSize(utf16Length_ << 1U | isAscii_) + n;
return leb128::UnsignedEncodingSize((utf16Length_ << 1U) | isAscii_) + n;
}
bool StringItem::Write(Writer *writer)
@ -179,7 +179,7 @@ bool StringItem::Write(Writer *writer)
return false;
}
if (!writer->WriteUleb128(utf16Length_ << 1U | isAscii_)) {
if (!writer->WriteUleb128((utf16Length_ << 1U) | isAscii_)) {
return false;
}

2
static_core/libziparchive/tests/libziparchive_tests.cpp
View File

@ -466,7 +466,7 @@ static void UnzipFileCheckInDirectory(const char *archivename, char *filename, c
os::mem::UnmapRaw(mem, sizeToMmap);
CloseCurrentFile(zipfile);
CloseArchive(zipfile);
ASSERT_EQ(1, 0) << "ExtractToMemory() failed!, uncompressed_length is " << uncompressedLength - 1
ASSERT_EQ(1, 0) << "ExtractToMemory() failed!, uncompressed_length is " << (uncompressedLength - 1)
<< ", original strlen is " << dlen;
return;
}

6
static_core/platforms/windows/libpandabase/mem.cpp
View File

@ -230,12 +230,14 @@ static size_t GetCacheLineSizeFromOs()
SYSTEM_LOGICAL_PROCESSOR_INFORMATION *buffer = 0;
GetLogicalProcessorInformation(0, &bufferSize);
/* if (bufferSize == 0) {
#ifdef ENABLE_THIS_CODE_IN_FUTURE
if (bufferSize == 0) {
// malloc behavior for zero bytes is implementation defined
// So, check it here
LOG_IF(lineSize == 0, FATAL, RUNTIME) << "Can't get cache line size from OS";
UNREACHABLE();
} */
}
#endif // ENABLE_THIS_CODE_IN_FUTURE
buffer = (SYSTEM_LOGICAL_PROCESSOR_INFORMATION *)malloc(bufferSize);
GetLogicalProcessorInformation(&buffer[0], &bufferSize);

198
static_core/plugins/ets/tests/mock/accessing_objects_fields_test_3.cpp
View File

@ -58,15 +58,15 @@ TEST_F(AccessingObjectsFieldsTest, GetFieldID2)
ASSERT_NE(memberId, nullptr);
}
// NOTE(m.morozov): uncomment this test when inheritance will be implemented
// TEST_F(AccessingObjectsFieldsTest, GetBaseFieldID2)
// {
// ets_class cls = env->FindClass("F_sub");
// ASSERT_NE(cls, nullptr);
// NOTE(m.morozov): enable this test when inheritance will be implemented
TEST_F(AccessingObjectsFieldsTest, DISABLED_GetBaseFieldID2)
{
ets_class cls = env_->FindClass("F_sub");
ASSERT_NE(cls, nullptr);
// ets_field member_id = env->Getp_field(cls, "member4", "I");
// ASSERT_NE(member_id, nullptr);
// }
ets_field member_id = env_->Getp_field(cls, "member4", "I");
ASSERT_NE(member_id, nullptr);
}
TEST_F(AccessingObjectsFieldsTest, GetTypeField)
{
@ -355,48 +355,48 @@ TEST_F(AccessingObjectsFieldsTestDeath, GetStaticTypeFieldDeathTests)
}
}
// NOTE(m.morozov): uncomment this test when inheritance will be implemented
// TEST_F(AccessingObjectsFieldsTest, GetStaticTypeFieldBase)
// {
// ets_class cls = env->FindClass("F_static_sub");
// ASSERT_NE(cls, nullptr);
// NOTE(m.morozov): enable this test when inheritance will be implemented
TEST_F(AccessingObjectsFieldsTest, DISABLED_GetStaticTypeFieldBase)
{
ets_class cls = env_->FindClass("F_static_sub");
ASSERT_NE(cls, nullptr);
// ets_field member0_id = env->GetStaticp_field(cls, "member0", "Z");
// ASSERT_NE(member0_id, nullptr);
// ets_field member1_id = env->GetStaticp_field(cls, "member1", "B");
// ASSERT_NE(member1_id, nullptr);
// ets_field member2_id = env->GetStaticp_field(cls, "member2", "C");
// ASSERT_NE(member2_id, nullptr);
// ets_field member3_id = env->GetStaticp_field(cls, "member3", "S");
// ASSERT_NE(member3_id, nullptr);
// ets_field member4_id = env->GetStaticp_field(cls, "member4", "I");
// ASSERT_NE(member4_id, nullptr);
// ets_field member5_id = env->GetStaticp_field(cls, "member5", "J");
// ASSERT_NE(member5_id, nullptr);
// ets_field member6_id = env->GetStaticp_field(cls, "member6", "F");
// ASSERT_NE(member6_id, nullptr);
// ets_field member7_id = env->GetStaticp_field(cls, "member7", "D");
// ASSERT_NE(member7_id, nullptr);
// ets_field member8_id = env->GetStaticp_field(cls, "member8", "LA;");
// ASSERT_NE(member8_id, nullptr);
ets_field member0_id = env_->GetStaticp_field(cls, "member0", "Z");
ASSERT_NE(member0_id, nullptr);
ets_field member1_id = env_->GetStaticp_field(cls, "member1", "B");
ASSERT_NE(member1_id, nullptr);
ets_field member2_id = env_->GetStaticp_field(cls, "member2", "C");
ASSERT_NE(member2_id, nullptr);
ets_field member3_id = env_->GetStaticp_field(cls, "member3", "S");
ASSERT_NE(member3_id, nullptr);
ets_field member4_id = env_->GetStaticp_field(cls, "member4", "I");
ASSERT_NE(member4_id, nullptr);
ets_field member5_id = env_->GetStaticp_field(cls, "member5", "J");
ASSERT_NE(member5_id, nullptr);
ets_field member6_id = env_->GetStaticp_field(cls, "member6", "F");
ASSERT_NE(member6_id, nullptr);
ets_field member7_id = env_->GetStaticp_field(cls, "member7", "D");
ASSERT_NE(member7_id, nullptr);
ets_field member8_id = env_->GetStaticp_field(cls, "member8", "LA;");
ASSERT_NE(member8_id, nullptr);
// EXPECT_EQ(env->GetStaticBooleanField(cls, member0_id), static_cast<ets_boolean>(1));
// EXPECT_EQ(env->GetStaticByteField(cls, member1_id), static_cast<ets_byte>(2_I));
// EXPECT_EQ(env->GetStaticCharField(cls, member2_id), static_cast<ets_char>(3U));
// EXPECT_EQ(env->GetStaticShortField(cls, member3_id), static_cast<ets_short>(4_I));
// EXPECT_EQ(env->GetStaticIntField(cls, member4_id), static_cast<ets_int>(5_I));
// EXPECT_EQ(env->GetStaticLongField(cls, member5_id), static_cast<ets_long>(6L));
// EXPECT_FLOAT_EQ(env->GetStaticFloatField(cls, member6_id), static_cast<ets_float>(7.0F));
// EXPECT_DOUBLE_EQ(env->GetStaticDoubleField(cls, member7_id), static_cast<ets_double>(8.0_D));
EXPECT_EQ(env_->GetStaticBooleanField(cls, member0_id), static_cast<ets_boolean>(1));
EXPECT_EQ(env_->GetStaticByteField(cls, member1_id), static_cast<ets_byte>(2_I));
EXPECT_EQ(env_->GetStaticCharField(cls, member2_id), static_cast<ets_char>(3U));
EXPECT_EQ(env_->GetStaticShortField(cls, member3_id), static_cast<ets_short>(4_I));
EXPECT_EQ(env_->GetStaticIntField(cls, member4_id), static_cast<ets_int>(5_I));
EXPECT_EQ(env_->GetStaticLongField(cls, member5_id), static_cast<ets_long>(6L));
EXPECT_FLOAT_EQ(env_->GetStaticFloatField(cls, member6_id), static_cast<ets_float>(7.0F));
EXPECT_DOUBLE_EQ(env_->GetStaticDoubleField(cls, member7_id), static_cast<ets_double>(8.0_D));
// ets_class a_cls = env->FindClass("A");
// ASSERT_NE(a_cls, nullptr);
// ets_field a_member_id = env->Getp_field(a_cls, "member", "I");
// ASSERT_NE(a_member_id, nullptr);
// ets_object a_obj = env->GetStaticObjectField(cls, member8_id);
// ASSERT_NE(a_obj, nullptr);
// EXPECT_EQ(env->GetIntField(a_obj, a_member_id), static_cast<ets_int>(1));
// }
ets_class a_cls = env_->FindClass("A");
ASSERT_NE(a_cls, nullptr);
ets_field a_member_id = env_->Getp_field(a_cls, "member", "I");
ASSERT_NE(a_member_id, nullptr);
ets_object a_obj = env_->GetStaticObjectField(cls, member8_id);
ASSERT_NE(a_obj, nullptr);
EXPECT_EQ(env_->GetIntField(a_obj, a_member_id), static_cast<ets_int>(1));
}
TEST_F(AccessingObjectsFieldsTestDeath, SetStaticTypeFieldDeathTests)
{
@ -439,64 +439,64 @@ TEST_F(AccessingObjectsFieldsTestDeath, SetStaticTypeFieldDeathTests)
}
}
// NOTE(m.morozov): uncomment this test when inheritance will be implemented
// TEST_F(AccessingObjectsFieldsTest, SetStaticFieldBase)
// {
// ets_class cls = env->FindClass("F_static_sub");
// ASSERT_NE(cls, nullptr);
// NOTE(m.morozov): enable this test when inheritance will be implemented
TEST_F(AccessingObjectsFieldsTest, DISABLED_SetStaticFieldBase)
{
ets_class cls = env_->FindClass("F_static_sub");
ASSERT_NE(cls, nullptr);
// ets_field member0_id = env->GetStaticp_field(cls, "member0", "Z");
// ASSERT_NE(member0_id, nullptr);
// ets_field member1_id = env->GetStaticp_field(cls, "member1", "B");
// ASSERT_NE(member1_id, nullptr);
// ets_field member2_id = env->GetStaticp_field(cls, "member2", "C");
// ASSERT_NE(member2_id, nullptr);
// ets_field member3_id = env->GetStaticp_field(cls, "member3", "S");
// ASSERT_NE(member3_id, nullptr);
// ets_field member4_id = env->GetStaticp_field(cls, "member4", "I");
// ASSERT_NE(member4_id, nullptr);
// ets_field member5_id = env->GetStaticp_field(cls, "member5", "J");
// ASSERT_NE(member5_id, nullptr);
// ets_field member6_id = env->GetStaticp_field(cls, "member6", "F");
// ASSERT_NE(member6_id, nullptr);
// ets_field member7_id = env->GetStaticp_field(cls, "member7", "D");
// ASSERT_NE(member7_id, nullptr);
// ets_field member8_id = env->GetStaticp_field(cls, "member8", "LA;");
// ASSERT_NE(member8_id, nullptr);
ets_field member0_id = env_->GetStaticp_field(cls, "member0", "Z");
ASSERT_NE(member0_id, nullptr);
ets_field member1_id = env_->GetStaticp_field(cls, "member1", "B");
ASSERT_NE(member1_id, nullptr);
ets_field member2_id = env_->GetStaticp_field(cls, "member2", "C");
ASSERT_NE(member2_id, nullptr);
ets_field member3_id = env_->GetStaticp_field(cls, "member3", "S");
ASSERT_NE(member3_id, nullptr);
ets_field member4_id = env_->GetStaticp_field(cls, "member4", "I");
ASSERT_NE(member4_id, nullptr);
ets_field member5_id = env_->GetStaticp_field(cls, "member5", "J");
ASSERT_NE(member5_id, nullptr);
ets_field member6_id = env_->GetStaticp_field(cls, "member6", "F");
ASSERT_NE(member6_id, nullptr);
ets_field member7_id = env_->GetStaticp_field(cls, "member7", "D");
ASSERT_NE(member7_id, nullptr);
ets_field member8_id = env_->GetStaticp_field(cls, "member8", "LA;");
ASSERT_NE(member8_id, nullptr);
// ets_class a_cls = env->FindClass("A");
// ASSERT_NE(a_cls, nullptr);
// ets_field a_member_id = env->Getp_field(a_cls, "member", "I");
// ASSERT_NE(a_member_id, nullptr);
// ets_object a_obj = env->GetStaticObjectField(cls, member8_id);
// ASSERT_NE(a_obj, nullptr);
ets_class a_cls = env_->FindClass("A");
ASSERT_NE(a_cls, nullptr);
ets_field a_member_id = env_->Getp_field(a_cls, "member", "I");
ASSERT_NE(a_member_id, nullptr);
ets_object a_obj = env_->GetStaticObjectField(cls, member8_id);
ASSERT_NE(a_obj, nullptr);
// env->SetIntField(a_obj, a_member_id, static_cast<ets_int>(5_I));
env_->SetIntField(a_obj, a_member_id, static_cast<ets_int>(5_I));
// env->SetStaticBooleanField(cls, member0_id, static_cast<ets_boolean>(1));
// env->SetStaticByteField(cls, member1_id, static_cast<ets_byte>(10_I));
// env->SetStaticCharField(cls, member2_id, static_cast<ets_char>(20U));
// env->SetStaticShortField(cls, member3_id, static_cast<ets_short>(30_I));
// env->SetStaticIntField(cls, member4_id, static_cast<ets_int>(40_I));
// env->SetStaticLongField(cls, member5_id, static_cast<ets_long>(50L));
// env->SetStaticFloatField(cls, member6_id, static_cast<ets_float>(60.0F));
// env->SetStaticDoubleField(cls, member7_id, static_cast<ets_double>(70.0F));
// env->SetStaticObjectField(cls, member8_id, a_obj);
env_->SetStaticBooleanField(cls, member0_id, static_cast<ets_boolean>(1));
env_->SetStaticByteField(cls, member1_id, static_cast<ets_byte>(10_I));
env_->SetStaticCharField(cls, member2_id, static_cast<ets_char>(20U));
env_->SetStaticShortField(cls, member3_id, static_cast<ets_short>(30_I));
env_->SetStaticIntField(cls, member4_id, static_cast<ets_int>(40_I));
env_->SetStaticLongField(cls, member5_id, static_cast<ets_long>(50L));
env_->SetStaticFloatField(cls, member6_id, static_cast<ets_float>(60.0F));
env_->SetStaticDoubleField(cls, member7_id, static_cast<ets_double>(70.0F));
env_->SetStaticObjectField(cls, member8_id, a_obj);
// EXPECT_EQ(env->GetStaticBooleanField(cls, member0_id), static_cast<ets_boolean>(1));
// EXPECT_EQ(env->GetStaticByteField(cls, member1_id), static_cast<ets_byte>(10_I));
// EXPECT_EQ(env->GetStaticCharField(cls, member2_id), static_cast<ets_char>(20U));
// EXPECT_EQ(env->GetStaticShortField(cls, member3_id), static_cast<ets_short>(30_I));
// EXPECT_EQ(env->GetStaticIntField(cls, member4_id), static_cast<ets_int>(40_I));
// EXPECT_EQ(env->GetStaticLongField(cls, member5_id), static_cast<ets_long>(50L));
// EXPECT_FLOAT_EQ(env->GetStaticFloatField(cls, member6_id), static_cast<ets_float>(60.0F));
// EXPECT_DOUBLE_EQ(env->GetStaticDoubleField(cls, member7_id), static_cast<ets_double>(70.0F));
EXPECT_EQ(env_->GetStaticBooleanField(cls, member0_id), static_cast<ets_boolean>(1));
EXPECT_EQ(env_->GetStaticByteField(cls, member1_id), static_cast<ets_byte>(10_I));
EXPECT_EQ(env_->GetStaticCharField(cls, member2_id), static_cast<ets_char>(20U));
EXPECT_EQ(env_->GetStaticShortField(cls, member3_id), static_cast<ets_short>(30_I));
EXPECT_EQ(env_->GetStaticIntField(cls, member4_id), static_cast<ets_int>(40_I));
EXPECT_EQ(env_->GetStaticLongField(cls, member5_id), static_cast<ets_long>(50L));
EXPECT_FLOAT_EQ(env_->GetStaticFloatField(cls, member6_id), static_cast<ets_float>(60.0F));
EXPECT_DOUBLE_EQ(env_->GetStaticDoubleField(cls, member7_id), static_cast<ets_double>(70.0F));
// ets_object set_a_obj = env->GetStaticObjectField(cls, member8_id);
// ASSERT_NE(set_a_obj, nullptr);
// EXPECT_EQ(env->IsInstanceOf(set_a_obj, a_cls), ETS_TRUE);
// EXPECT_EQ(env->GetIntField(set_a_obj, a_member_id), static_cast<ets_int>(5_I));
// }
ets_object set_a_obj = env_->GetStaticObjectField(cls, member8_id);
ASSERT_NE(set_a_obj, nullptr);
EXPECT_EQ(env_->IsInstanceOf(set_a_obj, a_cls), ETS_TRUE);
EXPECT_EQ(env_->GetIntField(set_a_obj, a_member_id), static_cast<ets_int>(5_I));
}
} // namespace panda::ets::test

51
static_core/plugins/ets/tests/mock/calling_methods_test_6.cpp
View File

@ -231,8 +231,8 @@ TEST_F(MethodsTest, CallMethodsTestGeneral6)
static_cast<ets_int>(121_I)),
static_cast<ets_double>(0.0));
// NOTE(m.morozov): Uncomment this test, when virtual calls will be implemented
/*
// NOTE(m.morozov): enable this test, when virtual calls will be implemented
#ifdef ENABLE_THIS_CODE_IN_FUTURE
// Call<type>Method part
env->CallVoidMethod(obj, void_id, static_cast<ets_int>(11), static_cast<ets_int>(121_I));
EXPECT_EQ(env->GetIntField(obj, d_member_id), static_cast<ets_int>(11));
@ -243,15 +243,20 @@ TEST_F(MethodsTest, CallMethodsTestGeneral6)
EXPECT_EQ(env->GetIntField(obj, d_member_id), static_cast<ets_int>(42_I));
EXPECT_EQ(env->CallBooleanMethod(obj, boolean_id, static_cast<ets_boolean>(1), static_cast<ets_int>(121_I)),
static_cast<ets_boolean>(1)); EXPECT_EQ(env->CallByteMethod(obj, byte_id, static_cast<ets_byte>(1),
static_cast<ets_int>(121_I)), static_cast<ets_byte>(1)); EXPECT_EQ(env->CallCharMethod(obj, char_id,
static_cast<ets_char>(1), static_cast<ets_int>(121_I)), static_cast<ets_char>(1));
static_cast<ets_boolean>(1));
EXPECT_EQ(env->CallByteMethod(obj, byte_id, static_cast<ets_byte>(1), static_cast<ets_int>(121_I)),
static_cast<ets_byte>(1));
EXPECT_EQ(env->CallCharMethod(obj, char_id, static_cast<ets_char>(1), static_cast<ets_int>(121_I)),
static_cast<ets_char>(1));
EXPECT_EQ(env->CallShortMethod(obj, short_id, static_cast<ets_short>(1), static_cast<ets_int>(121_I)),
static_cast<ets_short>(1)); EXPECT_EQ(env->CallIntMethod(obj, int_id), static_cast<ets_int>(1));
static_cast<ets_short>(1));
EXPECT_EQ(env->CallIntMethod(obj, int_id), static_cast<ets_int>(1));
EXPECT_EQ(env->CallLongMethod(obj, long_id, static_cast<ets_long>(1), static_cast<ets_int>(121_I)),
static_cast<ets_long>(1)); EXPECT_EQ(env->CallFloatMethod(obj, float_id, static_cast<ets_float>(1.0F),
static_cast<ets_int>(121_I)), static_cast<ets_float>(1.0F)); EXPECT_EQ(env->CallDoubleMethod(obj, double_id,
static_cast<ets_double>(1.0), static_cast<ets_int>(121_I)), static_cast<ets_double>(1.0));
static_cast<ets_long>(1));
EXPECT_EQ(env->CallFloatMethod(obj, float_id, static_cast<ets_float>(1.0F), static_cast<ets_int>(121_I)),
static_cast<ets_float>(1.0F));
EXPECT_EQ(env->CallDoubleMethod(obj, double_id, static_cast<ets_double>(1.0), static_cast<ets_int>(121_I)),
static_cast<ets_double>(1.0));
// Call<type>MethodArray part
env->CallVoidMethodArray(obj, void_id, void_args.data());
@ -280,18 +285,24 @@ TEST_F(MethodsTest, CallMethodsTestGeneral6)
EXPECT_EQ(env->IsInstanceOf(a_obj_from_List_direct_calls, a_cls), ETS_TRUE);
EXPECT_EQ(env->GetIntField(obj, d_member_id), static_cast<ets_int>(42_I));
EXPECT_EQ(CallBooleanMethodListHelper(env, obj, boolean_id, static_cast<ets_boolean>(1),
static_cast<ets_int>(121_I)), static_cast<ets_boolean>(1)); EXPECT_EQ(CallByteMethodListHelper(env, obj, byte_id,
static_cast<ets_byte>(1), static_cast<ets_int>(121_I)), static_cast<ets_byte>(1));
EXPECT_EQ(
CallBooleanMethodListHelper(env, obj, boolean_id, static_cast<ets_boolean>(1), static_cast<ets_int>(121_I)),
static_cast<ets_boolean>(1));
EXPECT_EQ(CallByteMethodListHelper(env, obj, byte_id, static_cast<ets_byte>(1), static_cast<ets_int>(121_I)),
static_cast<ets_byte>(1));
EXPECT_EQ(CallCharMethodListHelper(env, obj, char_id, static_cast<ets_char>(1), static_cast<ets_int>(121_I)),
static_cast<ets_char>(1)); EXPECT_EQ(CallShortMethodListHelper(env, obj, short_id, static_cast<ets_short>(1),
static_cast<ets_int>(121_I)), static_cast<ets_short>(1)); EXPECT_EQ(CallIntMethodListHelper(env, obj, int_id),
static_cast<ets_int>(1)); EXPECT_EQ(CallLongMethodListHelper(env, obj, long_id, static_cast<ets_long>(1),
static_cast<ets_int>(121_I)), static_cast<ets_long>(1)); EXPECT_EQ(CallFloatMethodListHelper(env, obj, float_id,
static_cast<ets_float>(1.0F), static_cast<ets_int>(121_I)), static_cast<ets_float>(1.0F));
EXPECT_EQ(CallDoubleMethodListHelper(env, obj, double_id, static_cast<ets_double>(1.0),
static_cast<ets_int>(121_I)), static_cast<ets_double>(1.0));
*/
static_cast<ets_char>(1));
EXPECT_EQ(CallShortMethodListHelper(env, obj, short_id, static_cast<ets_short>(1), static_cast<ets_int>(121_I)),
static_cast<ets_short>(1));
EXPECT_EQ(CallIntMethodListHelper(env, obj, int_id), static_cast<ets_int>(1));
EXPECT_EQ(CallLongMethodListHelper(env, obj, long_id, static_cast<ets_long>(1), static_cast<ets_int>(121_I)),
static_cast<ets_long>(1));
EXPECT_EQ(CallFloatMethodListHelper(env, obj, float_id, static_cast<ets_float>(1.0F), static_cast<ets_int>(121_I)),
static_cast<ets_float>(1.0F));
EXPECT_EQ(
CallDoubleMethodListHelper(env, obj, double_id, static_cast<ets_double>(1.0), static_cast<ets_int>(121_I)),
static_cast<ets_double>(1.0));
#endif // ENABLE_THIS_CODE_IN_FUTURE
}
TEST_F(MethodsTestDeath, CallMethodsTestGeneralDeath6)

2
static_core/runtime/mem/region_allocator.h
View File

@ -51,7 +51,7 @@ static inline Region *ObjectToRegion(const ObjectHeader *object)
static inline bool IsSameRegion(const void *o1, const void *o2, size_t regionSizeBits)
{
return ((ToUintPtr(o1) ^ ToUintPtr(o2)) >> regionSizeBits == 0);
return (((ToUintPtr(o1) ^ ToUintPtr(o2)) >> regionSizeBits) == 0);
}
/// Return the region which corresponds to the address.

8
static_core/runtime/tests/stack_walker_test.cpp
View File

@ -197,7 +197,7 @@ TEST_F(StackWalkerTest, ModifyVreg)
HOOK_ASSERT(walker.IsCFrame(), return 1);
success = walker.IterateVRegsWithInfo([&walker](const auto &regInfo, const auto &reg) {
if (!regInfo.IsAccumulator()) {
HOOK_ASSERT(reg.GetLong() == 27L, return true;);
HOOK_ASSERT(reg.GetLong() == 27L, return true);
walker.SetVRegValue(regInfo, FRAME_VALUES[2U]);
}
return true;
@ -207,7 +207,7 @@ TEST_F(StackWalkerTest, ModifyVreg)
HOOK_ASSERT(!walker.IsCFrame(), return 1);
success = walker.IterateVRegsWithInfo([](const auto &regInfo, const auto &reg) {
if (!regInfo.IsAccumulator()) {
HOOK_ASSERT(reg.GetLong() == bit_cast<int64_t>(FRAME_VALUES[0]), return true;);
HOOK_ASSERT(reg.GetLong() == bit_cast<int64_t>(FRAME_VALUES[0]), return true);
}
return true;
});
@ -217,7 +217,7 @@ TEST_F(StackWalkerTest, ModifyVreg)
HOOK_ASSERT(walker.IsCFrame(), return 1);
success = walker.IterateVRegsWithInfo([](const auto &regInfo, const auto &reg) {
if (!regInfo.IsAccumulator()) {
HOOK_ASSERT(reg.GetLong() == bit_cast<int64_t>(FRAME_VALUES[1]), return true;);
HOOK_ASSERT(reg.GetLong() == bit_cast<int64_t>(FRAME_VALUES[1]), return true);
}
return true;
});
@ -227,7 +227,7 @@ TEST_F(StackWalkerTest, ModifyVreg)
HOOK_ASSERT(walker.IsCFrame(), return 1);
success = walker.IterateVRegsWithInfo([](const auto &regInfo, const auto &reg) {
if (!regInfo.IsAccumulator()) {
HOOK_ASSERT(reg.GetLong() == bit_cast<int64_t>(FRAME_VALUES[2U]), return true;);
HOOK_ASSERT(reg.GetLong() == bit_cast<int64_t>(FRAME_VALUES[2U]), return true);
}
return true;
});