From e2cbf6d4ba2abf90953692538c042682fce90f68 Mon Sep 17 00:00:00 2001 From: shilei Date: Sat, 24 Sep 2022 15:01:03 +0800 Subject: [PATCH] fix cppcheck Signed-off-by: shilei Change-Id: If53ed42faca8ea27e6ef183ab2b2a6c5e7fcc004 --- frameworks/bundle_lite/src/bundle_manager.cpp | 2 +- .../bundlemgr_lite/src/bundle_installer.cpp | 11 ++++------- .../bundlemgr_lite/src/gt_bundle_extractor.cpp | 2 +- .../bundlemgr_lite/src/gt_bundle_installer.cpp | 6 +----- .../src/gt_bundle_manager_service.cpp | 17 +++++++++++++---- 5 files changed, 20 insertions(+), 18 deletions(-) diff --git a/frameworks/bundle_lite/src/bundle_manager.cpp b/frameworks/bundle_lite/src/bundle_manager.cpp index 50be38d..da16a97 100644 --- a/frameworks/bundle_lite/src/bundle_manager.cpp +++ b/frameworks/bundle_lite/src/bundle_manager.cpp @@ -172,7 +172,7 @@ static uint8_t DeserializeInnerBundleName(IOwner owner, IpcIo *reply) info->resultCode = ERR_APPEXECFWK_DESERIALIZATION_FAILED; return ERR_APPEXECFWK_DESERIALIZATION_FAILED; } - if (length < 0 || length > MAX_BUNDLE_NAME) { + if (length > MAX_BUNDLE_NAME) { info->resultCode = ERR_APPEXECFWK_DESERIALIZATION_FAILED; return ERR_APPEXECFWK_DESERIALIZATION_FAILED; } diff --git a/services/bundlemgr_lite/src/bundle_installer.cpp b/services/bundlemgr_lite/src/bundle_installer.cpp index c902c12..c401c5d 100755 --- a/services/bundlemgr_lite/src/bundle_installer.cpp +++ b/services/bundlemgr_lite/src/bundle_installer.cpp @@ -330,13 +330,10 @@ bool BundleInstaller::MatchPermissions(const std::vector & restrict int32_t size = realRestrictedPermissions.size(); for (int32_t i = 0; i < size; i++) { - bool isMatched = false; - for (const auto & restrictedPermission : restrictedPermissions) { - if (realRestrictedPermissions[i] == restrictedPermission) { - isMatched = true; - break; - } - } + bool isMatched = std::any_of(restrictedPermissions.begin(), restrictedPermissions.end(), + [realRestrictedPermissions, i](const auto & restrictedPermission)->bool { + return realRestrictedPermissions[i] == restrictedPermission; + }); if (!isMatched) { HILOG_WARN(HILOG_MODULE_APP, "provisionPermissions is not match the bundle reqPermissions!"); return false; diff --git a/services/bundlemgr_lite/src/gt_bundle_extractor.cpp b/services/bundlemgr_lite/src/gt_bundle_extractor.cpp index cfc0de1..650e58b 100755 --- a/services/bundlemgr_lite/src/gt_bundle_extractor.cpp +++ b/services/bundlemgr_lite/src/gt_bundle_extractor.cpp @@ -109,7 +109,7 @@ char *GtBundleExtractor::ExtractHapProfile(int32_t fp, uint32_t totalFileSize) } int32_t fileNameLen = strlen(fileName); - if (pathLen == 0 && (fileName != nullptr && strcmp(fileName, PROFILE_NAME) == 0)) { + if (pathLen == 0 && (strcmp(fileName, PROFILE_NAME) == 0)) { UI_Free(fileName); fileName = nullptr; fileData = reinterpret_cast(AdapterMalloc(fileSize * sizeof(char))); diff --git a/services/bundlemgr_lite/src/gt_bundle_installer.cpp b/services/bundlemgr_lite/src/gt_bundle_installer.cpp index 1c1bfb3..3392dce 100755 --- a/services/bundlemgr_lite/src/gt_bundle_installer.cpp +++ b/services/bundlemgr_lite/src/gt_bundle_installer.cpp @@ -109,8 +109,7 @@ uint8_t GtBundleInstaller::VerifySignature(const char *path, SignatureInfo &sign VerifyResult verifyResult; // verify signature (void) APPVERI_SetDebugMode(true); - int32_t ret = (bundleStyle == THIRD_APP_FLAG) ? APPVERI_AppVerify(path, &verifyResult) : - APPVERI_AppVerify(path, &verifyResult); + int32_t ret = APPVERI_AppVerify(path, &verifyResult); HILOG_INFO(HILOG_MODULE_AAFWK, "[BMS] APPVERI_AppVerify is %d", ret); uint8_t errorCode = SwitchErrorCode(ret); if (errorCode != ERR_OK) { @@ -523,9 +522,6 @@ uint8_t GtBundleInstaller::UpdateBundleInfo(uint8_t bundleStyle, uint32_t labelI if (bundleStyle == SYSTEM_APP_FLAG) { bundleInfo->isSystemApp = true; GtManagerService::GetInstance().AddBundleInfo(bundleInfo); - } else if (bundleStyle == THIRD_SYSTEM_APP_FLAG) { - bundleInfo->isSystemApp = false; - GtManagerService::GetInstance().AddBundleInfo(bundleInfo); } else { bundleInfo->isSystemApp = false; GtManagerService::GetInstance().AddBundleInfo(bundleInfo); diff --git a/services/bundlemgr_lite/src/gt_bundle_manager_service.cpp b/services/bundlemgr_lite/src/gt_bundle_manager_service.cpp index 19d6bd0..2d35f6f 100755 --- a/services/bundlemgr_lite/src/gt_bundle_manager_service.cpp +++ b/services/bundlemgr_lite/src/gt_bundle_manager_service.cpp @@ -414,10 +414,12 @@ void GtManagerService::RemoveSystemAppPathList(List *systemP for (auto node = systemPathList->Begin(); node != systemPathList->End(); node = node->next_) { ToBeInstalledApp *toBeInstalledApp = node->value_; - AdapterFree(toBeInstalledApp->installedPath); - AdapterFree(toBeInstalledApp->path); - AdapterFree(toBeInstalledApp->appId); - UI_Free(toBeInstalledApp); + if (toBeInstalledApp != nullptr) { + AdapterFree(toBeInstalledApp->installedPath); + AdapterFree(toBeInstalledApp->path); + AdapterFree(toBeInstalledApp->appId); + UI_Free(toBeInstalledApp); + } } } @@ -702,6 +704,9 @@ void GtManagerService::RemoveBundleResList(const char *bundleName) for (auto node = bundleResList_->Begin(); node != bundleResList_->End(); node = node->next_) { BundleRes *res = node->value_; + if (res == nullptr) { + return; + } if (res->bundleName != nullptr && strcmp(bundleName, res->bundleName) == 0) { AdapterFree(res->abilityRes); AdapterFree(res); @@ -1003,6 +1008,9 @@ void GtManagerService::APP_QueryAppInfo(const char *appDir, AppInfoList *list) return; } char *fileName = reinterpret_cast(AdapterMalloc(MAX_NAME_LEN + 1)); + if (fileName == nullptr) { + return; + } while ((ent = readdir(dir)) != nullptr) { if (memset_s(fileName, MAX_NAME_LEN + 1, 0, MAX_NAME_LEN + 1) != EOK) { break; @@ -1035,6 +1043,7 @@ void GtManagerService::APP_QueryAppInfo(const char *appDir, AppInfoList *list) APP_InsertAppInfo(appPath, (AppInfoList *)&list->appDoubleList); AdapterFree(appPath); } + closedir(dir); AdapterFree(fileName); }