process code review

Signed-off-by: zgit2021 <zhaowenqiang14@huawei.com>
This commit is contained in:
zgit2021 2022-03-23 10:12:37 +00:00
parent e163555bce
commit dfdc104724
9 changed files with 9 additions and 9 deletions

View File

@ -105,7 +105,7 @@ public:
sptr<DBinderServiceStub> MakeRemoteBinder(const std::u16string &serviceName,
const std::string &deviceID, binder_uintptr_t binderObject, uint64_t pid = 0);
bool RegisterRemoteProxy(std::u16string serviceName, sptr<IRemoteObject> binderObject);
bool RegisterRemoteProxy(std::u16string serviceName, int32_t systemAbilityId);
bool RegisterRemoteProxy(std::u16string serviceName, int32_t systemAbilityId);
bool OnRemoteMessageTask(const struct DHandleEntryTxRx *message);
std::shared_ptr<struct SessionInfo> QuerySessionObject(binder_uintptr_t stub);
bool DetachDeathRecipient(sptr<IRemoteObject> object);

View File

@ -12,7 +12,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "access_token_adapter.h"
#include <fcntl.h>
#include <stdio.h>
@ -50,7 +50,7 @@ uint64_t RpcGetSelfTokenID(void)
if (fd < 0) {
return INVAL_TOKEN_ID;
}
int ret =ioctl(fd, ACCESS_TOKENID_GET_TOKENID, &token);
int ret = ioctl(fd, ACCESS_TOKENID_GET_TOKENID, &token);
if (ret) {
close(fd);
return INVAL_TOKEN_ID;

View File

@ -382,4 +382,4 @@ napi_value NAPIAshmem::Ashmem_JS_Constructor(napi_env env, napi_callback_info in
NAPI_ASSERT(env, status == napi_ok, "wrap js Ashmem and native holder failed");
return thisVar;
}
}
} // namespace OHOS

View File

@ -100,7 +100,7 @@ void NAPIDeathRecipient::OnRemoteDied(const wptr<IRemoteObject> &object)
if (work == nullptr) {
DBINDER_LOGE("failed to new uv_work_t");
return;
};
}
OnRemoteDiedParam *param = new OnRemoteDiedParam {
.env = env_,
.deathRecipientRef = deathRecipientRef_

View File

@ -22,7 +22,6 @@
#include "test_service_command.h"
#include "test_service_client.h"
#include "ipc_test_helper.h"
#include "iservice_registry.h"
#include "if_system_ability_manager.h"
#include "iservice_registry.h"
#include "system_ability_definition.h"

View File

@ -970,7 +970,7 @@ HWTEST_F(UtilsSerializerTest, test_serializer_WriteAndRead_threshold_001, TestSi
IpcIoInit(&io, buffer, SMALL_BUFFER_SIZE, 0);
const char* strwrite ="test for write string threshold********************************************************\
#####################################################";
bool result = WriteString(&io, strwrite);
EXPECT_EQ(result, false);
}

View File

@ -87,7 +87,7 @@ public:
static void SetUpTestCase();
static void TearDownTestCase();
virtual void SetUp();
virtual void TearDown() {};
virtual void TearDown() {}
std::string IpToDeviceId(const std::string &localIp);
bool GetRemoteDeviceId();
};

View File

@ -29,5 +29,5 @@ int main(int argc __attribute__((unused)), char **argv __attribute__((unused)))
HiLog::Info(LG_LABEL, "DBinderTestService-main call StartThreadPool");
while (1) {};
while (1) {}
}

View File

@ -15,6 +15,7 @@
#include "rpc_session_handle.h"
#include <stdlib.h>
#include <errno.h>
#include <sys/time.h>