!167 kora告警清理

Merge pull request !167 from xiangjiaming/master

device/base/include/logging.h

@@ -144,6 +144,7 @@ static inline std::string StringFormat(const char* fmt, ...)
 
     va_start(vargs, fmt);
     if (vsnprintf_s(buf, sizeof(buf), sizeof(buf) - 1, format.c_str(), vargs) < 0) {
+        va_end(vargs);
         return "";
     }
 

device/plugins/cpu_plugin/src/test_main.cpp

@@ -91,6 +91,7 @@ int main(int agrc, char* agrv[])
 
         PluginModuleStruct* cpuPlugin = (PluginModuleStruct*)dlsym(handle, "g_pluginModule");
         if (cpuPlugin == nullptr) {
+            dlclose(handle);
             return 0;
         }
 
@@ -120,6 +121,7 @@ int main(int agrc, char* agrv[])
             }
         }
         cpuPlugin->callbacks->onPluginSessionStop();
+        dlclose(handle);
     }
 
     sleep(PROCESS_SLEEP_TIME);

device/plugins/diskio_plugin/src/test_main.cpp

@@ -37,13 +37,17 @@ void IoTest()
     // 一次写100K数据，写10次
     int count = 0;
     FILE* writeFp = fopen(writeFile.c_str(),"w");
+    if (writeFp == nullptr) {
+        printf("fopen() error");
+        return;
+    }
     while (count < g_testCount) {
-        fwrite(const_cast<char*>(str.c_str()), 1, BLOCK_LEN, writeFp);
+        (void)fwrite(const_cast<char*>(str.c_str()), 1, BLOCK_LEN, writeFp);
         fflush(writeFp);
         fsync(fileno(writeFp));
         count++;
     }
-    fclose(writeFp);
+    (void)fclose(writeFp);
 
     // delete file
     std::string command = "rm " + writeFile;
@@ -85,7 +89,8 @@ int main(int agrc, char* agrv[])
         std::vector<uint8_t> dataBuffer(diskioPlugin->resultBufferSizeHint);
         diskioPlugin->callbacks->onPluginSessionStart(configBuffer.data(), configLength);
         while (g_testCount--) {
-            int len = diskioPlugin->callbacks->onPluginReportResult(dataBuffer.data(), diskioPlugin->resultBufferSizeHint);
+            int len = diskioPlugin->callbacks->onPluginReportResult(dataBuffer.data(),
+                                                                    diskioPlugin->resultBufferSizeHint);
             std::cout << "test:filler buffer length = " << len << std::endl;
 
             if (len > 0) {
@@ -107,6 +112,7 @@ int main(int agrc, char* agrv[])
             sleep(1);
         }
         diskioPlugin->callbacks->onPluginSessionStop();
+        dlclose(handle);
     }
 
     return 0;

device/plugins/hilog_plugin/src/hilog_plugin.cpp

@@ -431,7 +431,8 @@ bool HilogPlugin::TimeStringToNS(const char* data, struct timespec *tsTime)
     if (snprintf_s(buff, sizeof(buff), sizeof(buff) - 1, "%ld.%09u\n", timetTime, nsec) < 0) {
         HILOG_ERROR(LOG_CORE, "%s:snprintf_s error", __func__);
     }
-    for (size_t i = 0; i < strlen(buff) && protoConfig_.need_record(); i++) {
+    size_t buffSize = strlen(buff);
+    for (size_t i = 0; i < buffSize && protoConfig_.need_record(); i++) {
         dataBuffer_.push_back(buff[i]);
     }
 

device/plugins/native_daemon/src/elf_file.cpp

@@ -131,6 +131,8 @@ bool ElfFile::ParsePrgHeaders()
     }
     ret = read(fd_, phdrsBuf, phdrSize * numPhdrs);
     if (ret != static_cast<int64_t>(phdrSize * numPhdrs)) {
+        delete[] phdrsBuf;
+        phdrsBuf = nullptr;
         return false;
     }
     char *phdrBuf = phdrsBuf;

hidebug/interfaces/js/kits/napi/napi_hidebug.cpp

@@ -165,6 +165,7 @@ static uint64_t GetProcessMeminfo(const std::string& matchingItem)
         char* flag = fgets(line, sizeof(line), smapsRollupInfo);
         if (flag == nullptr) {
             HiLog::Error(LABEL, "The parameter was not found.");
+            (void)fclose(smapsRollupInfo);
             return 0;
         }
         uint64_t meminfo = 0;