Gao Xiang
f20eef4d06
lib/lz4: explicitly support in-place decompression
...
commit 89b158635ad79574bde8e94d45dad33f8cf09549 upstream.
LZ4 final literal copy could be overlapped when doing
in-place decompression, so it's unsafe to just use memcpy()
on an optimized memcpy approach but memmove() instead.
Upstream LZ4 has updated this years ago [1] (and the impact
is non-sensible [2] plus only a few bytes remain), this commit
just synchronizes LZ4 upstream code to the kernel side as well.
It can be observed as EROFS in-place decompression failure
on specific files when X86_FEATURE_ERMS is unsupported,
memcpy() optimization of commit 59daa706fbec ("x86, mem:
Optimize memcpy by avoiding memory false dependece") will
be enabled then.
Currently most modern x86-CPUs support ERMS, these CPUs just
use "rep movsb" approach so no problem at all. However, it can
still be verified with forcely disabling ERMS feature...
arch/x86/lib/memcpy_64.S:
ALTERNATIVE_2 "jmp memcpy_orig", "", X86_FEATURE_REP_GOOD, \
- "jmp memcpy_erms", X86_FEATURE_ERMS
+ "jmp memcpy_orig", X86_FEATURE_ERMS
We didn't observe any strange on arm64/arm/x86 platform before
since most memcpy() would behave in an increasing address order
("copy upwards" [3]) and it's the correct order of in-place
decompression but it really needs an update to memmove() for sure
considering it's an undefined behavior according to the standard
and some unique optimization already exists in the kernel.
[1] 33cb8518ac
[2] https://github.com/lz4/lz4/pull/717#issuecomment-497818921
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=12518
Link: https://lkml.kernel.org/r/20201122030749.2698994-1-hsiangkao@redhat.com
Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
Reviewed-by: Nick Terrell <terrelln@fb.com>
Cc: Yann Collet <yann.collet.73@gmail.com>
Cc: Miao Xie <miaoxie@huawei.com>
Cc: Chao Yu <yuchao0@huawei.com>
Cc: Li Guifu <bluce.liguifu@huawei.com>
Cc: Guo Xuenan <guoxuenan@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-10 13:39:29 +02:00
..
2020-08-10 01:32:59 +09:00
2021-05-14 09:50:13 +02:00
2020-08-24 14:17:44 -07:00
2020-11-03 10:51:34 +01:00
2020-10-18 14:45:59 -07:00
2020-08-09 14:10:26 -07:00
2021-06-10 13:39:29 +02:00
2020-08-10 01:32:59 +09:00
2021-04-10 13:36:10 +02:00
2020-10-16 11:11:20 -07:00
2020-07-28 17:07:06 -07:00
2021-01-19 18:27:25 +01:00
2020-08-10 01:32:59 +09:00
2020-08-06 10:57:30 +02:00
2020-08-24 14:17:44 -07:00
2020-08-10 01:32:59 +09:00
2021-01-06 14:56:51 +01:00
2020-08-10 01:32:59 +09:00
2020-08-24 14:17:44 -07:00
2020-03-25 11:50:48 +01:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-08-24 14:17:44 -07:00
2020-08-24 14:17:44 -07:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-24 20:48:11 +02:00
2020-10-16 13:25:14 -06:00
2020-10-16 11:11:19 -07:00
2019-05-21 10:50:45 +02:00
2020-09-21 21:50:09 -04:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-05-14 09:50:32 +02:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2020-08-24 14:17:44 -07:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-10-18 15:01:57 +02:00
2021-02-17 11:02:24 +01:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2020-08-12 10:58:00 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-05-19 15:47:21 +02:00
2020-10-01 16:13:54 +02:00
2018-06-12 23:33:24 +02:00
2020-10-16 11:11:19 -07:00
2020-01-31 10:30:40 -08:00
2019-06-19 17:09:55 +02:00
2020-08-12 10:58:00 -07:00
2019-05-24 17:37:53 +02:00
2020-09-03 10:13:09 +02:00
2020-07-31 11:49:08 +02:00
2020-09-10 18:30:01 +02:00
2019-07-10 18:43:43 -07:00
2020-06-09 09:39:13 -07:00
2021-05-11 14:47:11 +02:00
2020-10-16 11:11:20 -07:00
2020-10-16 11:11:20 -07:00
2019-10-17 16:23:25 +02:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2020-10-16 11:11:19 -07:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-01-12 20:18:16 +01:00
2019-10-14 15:04:00 -07:00
2020-08-24 14:17:44 -07:00
2020-10-16 11:11:19 -07:00
2019-05-13 11:07:33 +02:00
2020-10-20 14:39:37 -07:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2021-02-17 11:02:28 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2020-10-06 11:18:04 +02:00
2021-04-21 13:00:54 +02:00
2020-10-13 18:38:32 -07:00
2020-08-24 15:09:58 -07:00
2020-09-28 12:14:08 +01:00
2020-10-16 11:11:22 -07:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-05-19 10:13:18 +02:00
2020-09-07 11:24:17 +02:00
2020-08-12 10:58:00 -07:00
2017-11-02 11:10:55 +01:00
2020-10-16 11:11:19 -07:00
2020-05-11 11:55:28 +01:00
2018-04-11 10:28:35 -07:00
2019-06-20 14:07:34 -06:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-08-26 12:42:08 +02:00
2019-06-07 13:15:06 -07:00
2021-03-17 17:06:25 +01:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2020-12-11 14:02:14 -08:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-05-19 10:13:08 +02:00
2020-08-24 14:24:25 -07:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2017-11-04 09:26:51 +09:00
2020-06-28 20:45:27 -07:00
2019-06-19 17:09:06 +02:00
2018-01-26 11:45:16 -06:00
2020-10-16 11:11:20 -07:00
2019-05-21 10:50:45 +02:00
2020-10-09 12:32:06 -06:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2020-10-20 14:39:37 -07:00
2020-10-24 20:21:57 +02:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2019-11-25 09:15:32 +01:00
2020-07-28 17:09:49 -07:00
2020-07-01 10:53:00 -06:00
2020-10-29 08:55:45 -06:00
2020-06-15 18:22:43 -07:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2020-05-08 15:32:17 +10:00
2019-09-24 15:54:09 -07:00
2020-08-24 14:17:44 -07:00
2020-06-11 15:14:36 +02:00
2019-11-14 13:15:11 -05:00
2021-05-22 11:40:55 +02:00
2019-05-30 11:26:32 -07:00
2020-09-30 10:50:30 +02:00
2020-09-26 10:33:57 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2020-12-03 09:52:44 -08:00
2020-09-08 22:21:33 -04:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2020-07-16 20:52:43 +02:00
2019-05-21 10:50:45 +02:00
2020-10-05 13:37:04 +02:00
2020-06-29 10:02:23 +02:00
2020-10-13 18:38:33 -07:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2020-07-10 16:24:28 -03:00
2020-10-16 11:11:20 -07:00
2018-10-15 16:31:29 -04:00
2020-10-13 18:38:32 -07:00
2021-05-19 10:13:11 +02:00
2020-08-12 10:58:01 -07:00
2020-05-08 18:18:12 +01:00
2019-05-21 10:50:45 +02:00
2020-08-12 10:58:00 -07:00
2018-10-16 13:45:44 +02:00
2019-12-04 19:44:13 -08:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2020-06-07 10:53:36 -07:00
2020-09-20 14:10:06 -07:00
2019-05-21 10:50:45 +02:00
2020-04-07 10:43:43 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2019-03-07 18:32:00 -08:00
2019-10-16 14:56:21 +02:00
2020-06-29 11:59:26 -07:00
2021-04-16 11:43:21 +02:00
2020-07-15 12:45:06 +03:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2020-08-12 10:58:00 -07:00
2020-08-24 14:17:44 -07:00
2020-04-07 10:43:43 -07:00
2021-02-17 11:02:24 +01:00
2021-02-17 11:02:24 +01:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2020-10-16 11:11:22 -07:00
2020-03-23 17:01:47 +01:00
2021-05-11 14:47:40 +02:00
2017-11-02 11:10:55 +01:00
2021-04-16 11:43:21 +02:00
2020-08-12 10:58:00 -07:00