From d08ef863feae14e4710bf2026404e6c6e06db2be Mon Sep 17 00:00:00 2001 From: zhanchengbin Date: Mon, 10 Oct 2022 16:56:58 +0800 Subject: [PATCH] misc/fsck.c: Processes may kill other processes. I find a error in misc/fsck.c, if run the fsck -N command, processes don't execute, just show what would be done. However, the pid whose value is -1 is added to the instance_list list in the execute function,if the kill_all function is called later, kill(-1, signum) is executed, Signals are sent to all processes except the number one process and itself. Other processes will be killed if they use the default signal processing function. Signed-off-by: zhanchengbin Signed-off-by: Lukas Czerner Reviewed-by: Zhiqiang Liu Reviewed-by: Darrick J. Wong Reviewed-by: Lukas Czerner Signed-off-by: Theodore Ts'o --- misc/fsck.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/misc/fsck.c b/misc/fsck.c index 1f6ec7d9..1769a106 100644 --- a/misc/fsck.c +++ b/misc/fsck.c @@ -547,6 +547,8 @@ static int kill_all(int signum) for (inst = instance_list; inst; inst = inst->next) { if (inst->flags & FLAG_DONE) continue; + if (inst->pid <= 0) + continue; kill(inst->pid, signum); n++; } -- 2.38.1