Go to file
Theodore Ts'o e7822c1f40 fix cross-compilation support
Commit 2500ebfc89 (util: fix make dependencies for subst) broke cross
compilation because it unconditionally used config.h without setting a
includes path so that the config.h file could be found.

The proposed fix of adding the include path (such as was proposed at
http://patchwork.ozlabs.org/patch/355662/ or in Debian Bug #753375)
isn't really the right way to go, since the information in config.h is
for the target environment, and not the build environment.  So using
config.h when building helper programs used as part of the build can
potentially cause more problems than it solves.

In general, build helpers must be written to be as portable as
possible, and to not require any autoconf defined #ifdef's whenever
possible.  The subst program broke this rule to (1) address a Coverity
security complaint by using futimes(2) instad of utimes(2) if present,
and (2) to preserve the nanosecond portion of the file timestamp.

Oh, well.  We won't be able to do the latter when cross compiling, and
as to the former, if an attacker has write access to your build tree
while you are building programs that will be run as root, you've got
bigger problems.  :-)

Fix the problem that commit 2500ebfc89 was trying to address by
explicitly adding @DEFS@ to CFLAGS, so that -DHAVE_CONFIG_H is passed
to make depend.  This fixes up the make depend without forcing the use
of config.h when cross-compiling.

Addresses-Debian-Bug: #753375
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Tested-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: Helmut Grohne <helmut@subdivi.de>
Cc: 753375@bugs.debian.org
2014-07-05 20:49:52 -04:00
config Update to latest version of config.* files 2014-07-04 23:49:39 -04:00
contrib tests: avoid using mktemp -t 2014-07-04 16:39:49 -04:00
debian Update release notes, etc. for final 1.42.10 release 2014-05-18 22:55:16 -04:00
debugfs debugfs: add support setting the error_count and associated sb fields 2014-07-04 16:39:49 -04:00
doc Update release notes, etc. for final 1.42.10 release 2014-05-18 22:55:16 -04:00
e2fsck e2fsck: fix last mount time and last write time in preen mode 2014-07-04 23:59:45 -04:00
ext2ed Add coverage testing using gcov 2014-02-23 00:17:09 -05:00
include/nonunix Remove trailing whitespace for the entire source tree 2008-08-27 23:07:54 -04:00
install-utils Remove Changelog files since they're not used after the git migration 2007-07-08 08:50:41 -04:00
intl Add coverage testing using gcov 2014-02-23 00:17:09 -05:00
lib blkid,ext2fs: avoid name clash with __u{8,16,32,64} 2014-07-04 23:59:45 -04:00
misc e2fsprogs: add mount options to ext4.5 2014-07-04 23:59:45 -04:00
po po: describe more precisely the %B expansion 2014-06-03 21:59:31 -04:00
resize resize2fs: don't attempt to calculate minimum size on fs with errors 2014-06-09 09:52:22 -04:00
tests tests: avoid using mktemp -t 2014-07-04 16:39:49 -04:00
util fix cross-compilation support 2014-07-05 20:49:52 -04:00
.gitignore misc: quiet minor build warnings, ignore generated files 2014-07-04 16:39:44 -04:00
.hgignore Ignore quilt work files 2005-07-19 08:41:27 -05:00
.missing-copyright Many files: 1997-04-29 16:15:03 +00:00
.release-checklist Update release checklist to include reminder to update translation 2008-07-10 17:25:22 -04:00
ABOUT-NLS Update to gettext 0.11.5. We now enable NLS support by default. 2003-05-03 16:35:17 -04:00
acinclude.m4 move e2fsprogs-specific macros from aclocal.m4 to acinclude.m4 2014-07-04 16:39:49 -04:00
aclocal.m4 aclocal.m4: update to newer versions of autoconf macros 2014-07-04 23:49:23 -04:00
configure configure.in: fix external libblkid test for static link 2014-07-05 00:30:35 -04:00
configure.in configure.in: fix external libblkid test for static link 2014-07-05 00:30:35 -04:00
COPYING Clarify the copyright licenses used by the various libraries in COPYING 2007-06-23 01:04:53 -04:00
depfix.sed Update Release Notes, Changelogs, version.h, etc. for 1.42 release 2011-11-29 16:48:14 -05:00
e2fsprogs.lsm Update release notes, etc. for final 1.42.10 release 2014-05-18 22:55:16 -04:00
e2fsprogs.spec.in misc: clean up compiler warnings 2011-06-11 10:58:25 -04:00
INSTALL Add a comment in INSTALL regarding --disable-tls on older systems 2008-07-10 09:08:44 -04:00
INSTALL.elfbin ChangeLog, INSTALL.elfbin: 1999-01-02 04:15:29 +00:00
Makefile.in tst_libext2fs: add new debug program which used for libext2fs unit tests 2014-05-27 12:14:27 -04:00
MCONFIG.in fix cross-compilation support 2014-07-05 20:49:52 -04:00
README Update release notes, etc. for final 1.42.10 release 2014-05-18 22:55:16 -04:00
README.subset Update release notes, version files for 1.40.4 release 2008-01-01 00:35:17 -05:00
RELEASE-NOTES Update release notes, etc. for final 1.42.10 release 2014-05-18 22:55:16 -04:00
SHLIBS Many files: 1997-04-29 16:15:03 +00:00
SUBMITTING-PATCHES Added SUBMITTING-PATCHES file 2005-07-05 22:30:13 -05:00
TODO Update TODO to remove item which is already completed. 2006-05-13 09:28:04 -04:00
version.h Update release notes, etc. for final 1.42.10 release 2014-05-18 22:55:16 -04:00
wordwrap.pl Fix wordwrap.pl so it is more portable 2012-09-21 12:50:04 -04:00

	This is the new version (1.42.10) of the second extended file
system management programs.

	From time to time, I release new versions of e2fsprogs, to fix
bugs and to make the utilities more robust.  You can always find
information about the latest version at the the e2fsprogs web page,
which is:

	http://e2fsprogs.sourceforge.net

	The INSTALL file has instructions on building and installing
e2fsprogs.  Provisions for building Red Hat RPMs and Debian dpkg files
are supplied as well.

	In case of bugs in these programs, please contact Ted Ts'o at
tytso@mit.edu or tytso@alum.mit.edu.  See the e2fsck man page for
suggestions of what sort of information to include when submitting bug
reports for these programs.