From 0c1ffd0aa55c6cef6dffe2b736786c6cb86d8a3d Mon Sep 17 00:00:00 2001 From: James Almer Date: Sun, 1 Oct 2017 23:31:12 -0300 Subject: [PATCH] avdevice/decklink_dec: use av_packet_add_side_data() It uses the existing buffer instead of allocating a new one. Reviewed-by: Marton Balint Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 8a14094474..9d12d0fed0 100644 --- a/libavdevice/decklink_dec.cpp +++ b/libavdevice/decklink_dec.cpp @@ -390,10 +390,8 @@ uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf, size_t width, clear_parity_bits(buf, len); data = vanc_to_cc(avctx, buf, width, data_len); if (data) { - uint8_t *pkt_cc = av_packet_new_side_data(pkt, AV_PKT_DATA_A53_CC, data_len); - if (pkt_cc) - memcpy(pkt_cc, data, data_len); - av_free(data); + if (av_packet_add_side_data(pkt, AV_PKT_DATA_A53_CC, data, data_len) < 0) + av_free(data); } } else { av_log(avctx, AV_LOG_DEBUG, "Unknown meta data DID = 0x%.2x SDID = 0x%.2x\n",