From 52814990825f9cb8814300d8164a7e2672bb19dc Mon Sep 17 00:00:00 2001 From: Alviro Iskandar Setiawan Date: Tue, 18 Oct 2022 20:35:16 +0700 Subject: [PATCH 1/3] man/io_uring_buf_ring_advance.3: Fix return type This function doesn't return anything, the return type should be void. Fixes: df18600a0dc125dbf2fe5c62f111e300f646180f ("Add man pages for shared provided buffer rings") Signed-off-by: Alviro Iskandar Setiawan Signed-off-by: Ammar Faizi --- man/io_uring_buf_ring_advance.3 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/io_uring_buf_ring_advance.3 b/man/io_uring_buf_ring_advance.3 index 29a35784..f2dc90b5 100644 --- a/man/io_uring_buf_ring_advance.3 +++ b/man/io_uring_buf_ring_advance.3 @@ -9,8 +9,8 @@ io_uring_buf_ring_advance \- advance index of provided buffer in buffer ring .nf .B #include .PP -.BI "int io_uring_buf_ring_advance(struct io_uring_buf_ring *" br ", -.BI " int " count ");" +.BI "void io_uring_buf_ring_advance(struct io_uring_buf_ring *" br ", +.BI " int " count ");" .fi .SH DESCRIPTION .PP From 4cd69d79e78fd769aa7536f75b8f77b896c2dc6b Mon Sep 17 00:00:00 2001 From: Alviro Iskandar Setiawan Date: Tue, 18 Oct 2022 20:36:22 +0700 Subject: [PATCH 2/3] man/io_uring_buf_ring_cq_advance.3: Fix return type This function doesn't return anything, the return type should be void. Fixes: df18600a0dc125dbf2fe5c62f111e300f646180f ("Add man pages for shared provided buffer rings") Signed-off-by: Alviro Iskandar Setiawan Signed-off-by: Ammar Faizi --- man/io_uring_buf_ring_cq_advance.3 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/man/io_uring_buf_ring_cq_advance.3 b/man/io_uring_buf_ring_cq_advance.3 index caf882f8..4967a845 100644 --- a/man/io_uring_buf_ring_cq_advance.3 +++ b/man/io_uring_buf_ring_cq_advance.3 @@ -9,9 +9,9 @@ io_uring_buf_ring_cq_advance \- advance index of provided buffer and CQ ring .nf .B #include .PP -.BI "int io_uring_buf_ring_cq_advance(struct io_uring *" ring ", -.BI " struct io_uring_buf_ring *" br ", -.BI " int " count ");" +.BI "void io_uring_buf_ring_cq_advance(struct io_uring *" ring ", +.BI " struct io_uring_buf_ring *" br ", +.BI " int " count ");" .fi .SH DESCRIPTION .PP From 4fe3c560f3b6d3605c27921dfbd14f178e1f18a7 Mon Sep 17 00:00:00 2001 From: Ammar Faizi Date: Wed, 19 Oct 2022 04:43:10 +0700 Subject: [PATCH 3/3] test/helpers: Fix clang warning Building with clang v13.0.1 yields the following warning: ./helpers.h:29:42: warning: declaration of 'struct sockaddr_in' \ will not be visible outside of this function [-Wvisibility] int t_bind_ephemeral_port(int fd, struct sockaddr_in *addr); ^ This is because at that point struct sockaddr_in has not been declared yet. Fix this by including in helpers.h. Fixes: 1e63b19a5ebfdc9f383840398c9612df88219473 ("test/helpers: Add `t_bind_ephemeral_port()` function") Signed-off-by: Ammar Faizi --- test/helpers.h | 1 + 1 file changed, 1 insertion(+) diff --git a/test/helpers.h b/test/helpers.h index 5e9bb261..4375a9e4 100644 --- a/test/helpers.h +++ b/test/helpers.h @@ -10,6 +10,7 @@ extern "C" { #endif #include "liburing.h" +#include enum t_setup_ret { T_SETUP_OK = 0,