t/recv-msgall: Don't use a static port number

Don't use a static port number. It might already be in use, resulting
in a test failure. Use an ephemeral port to make this test reliable.

Cc: Dylan Yudaken <dylany@fb.com>
Cc: Facebook Kernel Team <kernel-team@fb.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>
Reviewed-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Tested-by: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Link: https://lore.kernel.org/r/20220902071153.3168814-11-ammar.faizi@intel.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Ammar Faizi
2022-09-02 14:15:03 +07:00
committed by Jens Axboe
parent d1d9388856
commit e6bf9923ed
+4 -6
View File
@@ -16,9 +16,8 @@
#include "helpers.h"
#define MAX_MSG 128
#define PORT 10201
#define HOST "127.0.0.1"
static __be16 bind_port;
static int recv_prep(struct io_uring *ring, struct iovec *iov, int *sock,
int use_recvmsg)
@@ -31,7 +30,6 @@ static int recv_prep(struct io_uring *ring, struct iovec *iov, int *sock,
memset(&saddr, 0, sizeof(saddr));
saddr.sin_family = AF_INET;
saddr.sin_addr.s_addr = htonl(INADDR_ANY);
saddr.sin_port = htons(PORT);
sockfd = socket(AF_INET, SOCK_DGRAM, 0);
if (sockfd < 0) {
@@ -42,11 +40,11 @@ static int recv_prep(struct io_uring *ring, struct iovec *iov, int *sock,
val = 1;
setsockopt(sockfd, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val));
ret = bind(sockfd, (struct sockaddr *)&saddr, sizeof(saddr));
if (ret < 0) {
if (t_bind_ephemeral_port(sockfd, &saddr)) {
perror("bind");
goto err;
}
bind_port = saddr.sin_port;
sqe = io_uring_get_sqe(ring);
if (!use_recvmsg) {
@@ -165,7 +163,7 @@ static int do_send(void)
memset(&saddr, 0, sizeof(saddr));
saddr.sin_family = AF_INET;
saddr.sin_port = htons(PORT);
saddr.sin_port = bind_port;
inet_pton(AF_INET, HOST, &saddr.sin_addr);
sockfd = socket(AF_INET, SOCK_DGRAM, 0);