From d43a2a421cdc19862c1e4393edea6e796b574116 Mon Sep 17 00:00:00 2001 From: Arseny Kapoulkine Date: Mon, 22 May 2017 20:31:33 -0700 Subject: [PATCH] posttransformanalyzer: Cleanup statistics Remove redundant fields, rename misses to vertices_transformed. --- src/meshoptimizer.hpp | 5 ++--- src/posttransformanalyzer.cpp | 11 +++-------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/meshoptimizer.hpp b/src/meshoptimizer.hpp index d273f9d8..03e6184b 100644 --- a/src/meshoptimizer.hpp +++ b/src/meshoptimizer.hpp @@ -45,8 +45,7 @@ void optimizePreTransform(void* destination, const void* vertices, unsigned int* struct PostTransformCacheStatistics { - unsigned int hits, misses; - float hit_percent, miss_percent; + unsigned int vertices_transformed; float acmr; // transformed vertices / triangle count; best case 0.5, worst case 3.0, optimum depends on topology float atvr; // transformed vertices / vertex count; best case 1.0, worse case 6.0, optimum is 1.0 (each vertex is transformed once) }; @@ -61,7 +60,7 @@ struct OverdrawStatistics { unsigned int pixels_covered; unsigned int pixels_shaded; - float overdraw; + float overdraw; // shaded pixels / covered pixels; best case 1.0 }; // Overdraw analyzer diff --git a/src/posttransformanalyzer.cpp b/src/posttransformanalyzer.cpp index e562e604..72f4b47d 100644 --- a/src/posttransformanalyzer.cpp +++ b/src/posttransformanalyzer.cpp @@ -20,17 +20,12 @@ namespace { // cache miss cache_time_stamps[index] = time_stamp++; - result.misses++; + result.vertices_transformed++; } } - result.hits = static_cast(index_count) - result.misses; - - result.hit_percent = 100 * static_cast(result.hits) / index_count; - result.miss_percent = 100 * static_cast(result.misses) / index_count; - - result.acmr = static_cast(result.misses) / (index_count / 3); - result.atvr = static_cast(result.misses) / vertex_count; + result.acmr = static_cast(result.vertices_transformed) / (index_count / 3); + result.atvr = static_cast(result.vertices_transformed) / vertex_count; return result; }