Commit Graph

653 Commits

Author SHA1 Message Date
Ashley Mannix
ee8c6cd426 respect fmt trait and flags in Value 2020-06-04 21:12:31 +10:00
Ashley Mannix
c5c8e48f35
Merge pull request #398 from dtolnay/ra_hir_def
Resolve possible inference disruption by removing unneeded From impl
2020-06-04 14:05:51 +10:00
David Tolnay
f3cce30dff
Resolve possible inference disruption by removing unneeded From impl
This impl breaks some code in rust-analyzer's ra_hir_def crate.

1dba84019e/crates/ra_hir_def/src/path.rs (L273-L307)

    $ cargo check --manifest-path crates/ra_hir_def/Cargo.toml
        Checking ra_hir_def v0.1.0
        Finished dev [unoptimized] target(s) in 0.75s

    $ cargo check --manifest-path crates/ra_hir_def/Cargo.toml --features log/kv_unstable
        Checking ra_hir_def v0.1.0
    error[E0282]: type annotations needed for the closure `fn(&str) -> std::result::Result<(), _>`
       --> crates/ra_hir_def/src/path.rs:278:17
        |
    278 |                 f.write_str("::")?;
        |                 ^^^^^^^^^^^^^^^^^^ cannot infer type
        |
    help: give this closure an explicit return type without `_` placeholders
        |
    276 |         let mut add_segment = |s| -> std::result::Result<(), _> {
        |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2020-06-03 19:00:52 -07:00
Steven Fackler
4fb398b68e
Merge pull request #393 from sivadeilra/doc_update
Add reference to win_dbg_logger
2020-04-21 13:08:29 -04:00
Arlie Davis
f7a14e41f2 Add reference to win_dbg_logger
win_dbg_logger is logger for use with Windows debuggers.

Windows allows applications to output a string directly to debuggers. This is
very useful in situations where other forms of logging are not available.
For example, stderr is not available for GUI apps.

This crate can be compiled and used on non-Windows platforms, but it does
nothing. This is intended to minimize the impact on code that takes a
dependency on this crate.
2020-04-21 09:38:17 -07:00
Steven Fackler
3c83704e7a
Merge pull request #392 from jyn514/master
Document use of mem::transmute
2020-04-18 09:40:55 -04:00
Joshua Nelson
51562abb06 Document why transmute is sound 2020-04-10 13:23:03 -04:00
Joshua Nelson
0b0a78ccf2 Reduce the scope of unsafe blocks 2020-04-10 13:15:17 -04:00
Steven Fackler
bbf4843fcf
Merge pull request #389 from Mark-Simulacrum/to-triagebot
Add triagebot configuration
2020-03-31 16:56:46 -04:00
Mark Rousskov
1e0fb89636 Add triagebot configuration
This enables assignment through triagebot on this repository, in preparation for
the migration from highfive to triagebot for PR assignment.
2020-03-31 16:39:34 -04:00
Steven Fackler
e8730e9493
Merge pull request #384 from nblumhardt/patch-1
Show master branch build status in README
2020-03-09 15:52:28 -04:00
Nicholas Blumhardt
2018d75955 Show master branch build status in README 2020-03-09 15:53:22 +10:00
Ashley Mannix
8d3d2eacb0
Merge pull request #380 from vallentin/master
Fixed misspelling
2020-02-17 07:39:18 +10:00
vallentin
cf1b35aef8 Fixed misspelling 2020-02-11 21:18:50 +01:00
Ashley Mannix
d54317e47a
Merge pull request #379 from KodrAus/feat/value-coercion
Support coercing structured Values into primitive types
2020-02-03 09:43:11 +10:00
Ashley Mannix
66af8f2d0c refactor coerce into cast
revert to to_ inherent methods
support downcasting erased values
2020-02-03 09:27:54 +10:00
Ashley Mannix
76cb179dec make the get test use borrowed data 2020-01-31 17:33:43 +10:00
Ashley Mannix
098e0b2cd6 refactor value module layout 2020-01-31 17:28:30 +10:00
Ashley Mannix
6743f4a0d2 make value internal visitor support borrowing 2020-01-31 16:51:44 +10:00
Ashley Mannix
ddb118e466 support coercing Values into primitive types 2020-01-31 12:53:40 +10:00
Alex Crichton
e876aecb00 Update CI installation of Rust on macos 2020-01-28 00:43:46 -08:00
Steven Fackler
a24d531ff2
Merge pull request #377 from helaan/fix/remove-atomic-usize-init
Remove ATOMIC_USIZE_INIT
2020-01-17 16:51:02 -05:00
Henk van der Laan
b2c1b31268 Remove ATOMIC_USIZE_INIT
MSRV is now high enough that AtomicUsize::new is available
2020-01-17 22:43:21 +01:00
Ashley Mannix
f06a18d010
Merge pull request #374 from KodrAus/fix/kv_macro
Revert the macro implementation
2019-12-19 10:46:21 +10:00
Ashley Mannix
c3a9a14c58 revert to old macro impl for now 2019-12-19 07:15:14 +10:00
Ashley Mannix
bb0224c120 add test for named format args 2019-12-19 07:11:56 +10:00
Ashley Mannix
1c73af5d30
Merge pull request #373 from AnderEnder/remove-deprecated-error-description
Remove deprecated Error::description
2019-12-19 07:04:31 +10:00
Andrii Radyk
0d71764051 remove deprecated Error::description 2019-12-17 09:26:46 +01:00
Ashley Mannix
4e196f927d
Merge pull request #371 from KodrAus/cargo/0.4.10
Prepare for 0.4.10 release
2019-12-16 15:31:55 +10:00
Ashley Mannix
fbd138acb5 prepare for 0.4.10 release 2019-12-16 12:00:14 +10:00
Ashley Mannix
bf0d075fc5 make macro style consistent 2019-12-16 11:57:55 +10:00
Ashley Mannix
62c0975cf7
Merge pull request #370 from KodrAus/fix/macro-expr-context
fix up macro use in expr context
2019-12-16 11:51:15 +10:00
Ashley Mannix
1a7ffda379 fix up macro use in expr context 2019-12-16 10:09:37 +10:00
Ashley Mannix
87fc152d40
Merge pull request #368 from KodrAus/cargo/0.4.9
Prepare for 0.4.9 release
2019-12-16 08:28:56 +10:00
Ashley Mannix
e0816a2e4c add missing link to changelog 2019-12-12 08:41:59 +10:00
Ashley Mannix
0c0eaa304e prepare for 0.4.9 release 2019-12-12 08:36:02 +10:00
Ashley Mannix
efcc39c521
Merge pull request #367 from TethysSvensson/master
Miscellaneous cleanup
2019-12-11 17:24:53 +10:00
Mathias Svensson
4f5de62a79 The 'static lifetime is inferred in the definition of static items 2019-12-10 11:43:12 +01:00
Mathias Svensson
454b3079d5 Run cargo fix 2019-12-10 11:41:36 +01:00
Mathias Svensson
299d1d5c16 Use Box::leak to get rid of some unsafe code 2019-12-10 11:36:36 +01:00
Ashley Mannix
4597769adc
Merge pull request #366 from sfackler/lit-code-size
Add a separate path for messages with no format arguments
2019-12-09 16:23:57 +10:00
Ashley Mannix
b01adcd960 fix up macro 2019-12-09 16:19:17 +10:00
Ashley Mannix
4a082a7e56 Merge branch 'master' of https://github.com/rust-lang-nursery/log into lit-code-size 2019-12-09 16:14:39 +10:00
Ashley Mannix
03aba1db2a
Merge pull request #353 from yoshuawuyts/kv-support
kv macro support
2019-12-09 16:00:44 +10:00
Steven Fackler
1dfae503d2 Add a separate path for messages with no format arguments
This cuts the size of

```rust
fn main() {
    log::warn!("hello world");
}
```

from 95 bytes:

```asm
00000000000042f0 <_ZN3foo4main17h91a1e0cbbd2d1746E>:
    42f0:       48 83 ec 38             sub    $0x38,%rsp
    42f4:       48 8d 05 55 dd 02 00    lea    0x2dd55(%rip),%rax        # 32050 <_ZN3log20MAX_LOG_LEVEL_FILTER17h8b54f41fea648f5cE>
    42fb:       48 8b 00                mov    (%rax),%rax
    42fe:       48 83 f8 03             cmp    $0x3,%rax
    4302:       72 47                   jb     434b <_ZN3foo4main17h91a1e0cbbd2d1746E+0x5b>
    4304:       48 8d 05 1d bd 02 00    lea    0x2bd1d(%rip),%rax        # 30028 <anon.7cf0325160a81106a62a3eb77a18e0e0.0.llvm.16433780892884680004+0x30>
    430b:       48 89 44 24 08          mov    %rax,0x8(%rsp)
    4310:       48 c7 44 24 10 01 00    movq   $0x1,0x10(%rsp)
    4317:       00 00
    4319:       48 c7 44 24 18 00 00    movq   $0x0,0x18(%rsp)
    4320:       00 00
    4322:       48 c7 44 24 28 08 00    movq   $0x8,0x28(%rsp)
    4329:       00 00
    432b:       48 c7 44 24 30 00 00    movq   $0x0,0x30(%rsp)
    4332:       00 00
    4334:       48 8d 15 fd bc 02 00    lea    0x2bcfd(%rip),%rdx        # 30038 <anon.7cf0325160a81106a62a3eb77a18e0e0.0.llvm.16433780892884680004+0x40>
    433b:       48 8d 7c 24 08          lea    0x8(%rsp),%rdi
    4340:       be 03 00 00 00          mov    $0x3,%esi
    4345:       ff 15 0d db 02 00       callq  *0x2db0d(%rip)        # 31e58 <_GLOBAL_OFFSET_TABLE_+0x4d8>
    434b:       48 83 c4 38             add    $0x38,%rsp
    434f:       c3                      retq
```

to 45 bytes:

```asm
00000000000042f0 <_ZN3foo4main17h91a1e0cbbd2d1746E>:
    42f0:       48 8d 05 59 dd 02 00    lea    0x2dd59(%rip),%rax        # 32050 <_ZN3log20MAX_LOG_LEVEL_FILTER17h8b54f41fea648f5cE>
    42f7:       48 8b 00                mov    (%rax),%rax
    42fa:       48 83 f8 03             cmp    $0x3,%rax
    42fe:       72 1e                   jb     431e <_ZN3foo4main17h91a1e0cbbd2d1746E+0x2e>
    4300:       48 8d 3d f9 0c 02 00    lea    0x20cf9(%rip),%rdi        # 25000 <_fini+0xe44>
    4307:       48 8d 0d 1a bd 02 00    lea    0x2bd1a(%rip),%rcx        # 30028 <anon.7cf0325160a81106a62a3eb77a18e0e0.0.llvm.16433780892884680004+0x30>
    430e:       be 0b 00 00 00          mov    $0xb,%esi
    4313:       ba 03 00 00 00          mov    $0x3,%edx
    4318:       ff 25 5a d8 02 00       jmpq   *0x2d85a(%rip)        # 31b78 <_GLOBAL_OFFSET_TABLE_+0x1f8>
    431e:       c3                      retq
```

Closes #365
2019-11-24 13:35:09 -08:00
Steven Fackler
2774e4aa7a
Merge pull request #362 from KodrAus/ci/msrv
Use explicit version of cfg-if in msrv build
2019-11-24 16:35:06 -05:00
Steven Fackler
26c72b68b1
Update lib.rs 2019-11-24 16:29:23 -05:00
Ashley Mannix
ae59aa14de 1.31.0 it is then 2019-11-24 14:52:05 +10:00
Ashley Mannix
e0ec20f814 try just before each commannd 2019-11-24 13:44:26 +10:00
Ashley Mannix
967b716b5e try use cargo update again 2019-11-24 13:31:23 +10:00