mirror of
https://github.com/openharmony/third_party_rust_tower.git
synced 2026-07-21 04:15:22 -04:00
Eliza Weisman
1d7341f647
Tower has test and check jobs on CI that run on a build matrix including a number of Rust versions. By default, GitHub Actions has fail-fast semantics for matrix jobs, so if any matrix job fails, the rest are cancelled and the build is failed. This is intended to help builds complete faster. This isn't really the ideal behavior for testing across multiple Rust versions. When a build fails on a particular toolchain version, we would ideally like to know whether the failure is localized to that version or exists on _all_ Rust versions. This is particularly important for builds on nightly Rust, as the nightly toolchain is more likely to contain compiler regressions that might not be our fault at all. Similarly, we might want to know if a change only broke the build on our MSRV, or if it broke the build everywhere --- such an issue would be fixed differently. This also currently means that the nightly test run failing will prevent PRs from being merged, even if the failure is due to a nightly compiler regression. We currently only *require* the stable and MSRV test runs to pass in order to merge a PR, but because the fail-fast behavior will cancel them if the nightly build fails, this means that nightly failing will effectively prevent merging PRs...which, given that it's not marked as required, seems different from what we intended. Therefore, this PR changes the CI workflow to disable fail-fast behavior on the cross-version test jobs. Signed-off-by: Eliza Weisman <eliza@buoyant.io>