openharmony/third_party_spirv-tools
1
0
Fork 0
mirror of https://gitee.com/openharmony/third_party_spirv-tools synced 2024-11-23 07:20:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't mention VS2013 in PR review instructions (#4384)

Browse Source 
Visual Studio 2013 is not supported anymore.
This commit is contained in:
Jakub Kuderski 2021-07-16 12:19:06 -04:00 committed by GitHub
parent 7320b9acd2
commit 5427d5cf01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CONTRIBUTING.md
View File

@ -98,13 +98,6 @@ should pay particular attention to:
scenarios? The respective SPIR-V dialects are slightly different.
* Changes are made to a container while iterating through it. You have to be
careful that iterators are not invalidated or that elements are not skipped.
* C++11 and VS2013. We generally assume that we have a C++11 compliant
compiler. However, on Windows, we still support Visual Studio 2013, which is
not fully C++11 compliant. See
[here](https://msdn.microsoft.com/en-us/library/hh567368.aspx). In
particular, note that it does not provide default move-constructors or
move-assignments for classes. In general, r-value references do not work the
way you might assume they do.
* For SPIR-V transforms: The module is changed, but the analyses are not
updated. For example, a new instruction is added, but the def-use manager is
not updated. Later on, it is possible that the def-use manager will be used,