openharmony/third_party_spirv-tools
1
0
Fork 0
mirror of https://gitee.com/openharmony/third_party_spirv-tools synced 2025-02-20 06:42:05 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Add a default virtual dtor to Pass and check for missing virtual dtors

Browse Source
This commit is contained in:
Jean-Francois Roy 2017-02-28 11:34:18 -08:00 committed by David Neto
parent 0e9c24fdd1
commit 6a2b514826
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CMakeLists.txt
View File

@ -50,7 +50,7 @@ if(("${CMAKE_CXX_COMPILER_ID}" MATCHES "GNU") OR ("${CMAKE_CXX_COMPILER_ID}" MAT
set(COMPILER_IS_LIKE_GNU TRUE)
endif()
if(${COMPILER_IS_LIKE_GNU})
set(SPIRV_WARNINGS -Wall -Wextra -Wno-missing-field-initializers)
set(SPIRV_WARNINGS -Wall -Wextra -Wnon-virtual-dtor -Wno-missing-field-initializers)
option(SPIRV_WARN_EVERYTHING "Enable -Weverything" ${SPIRV_WARN_EVERYTHING})
if(${SPIRV_WARN_EVERYTHING})

3
source/opt/pass.h
View File

@ -44,6 +44,9 @@ class Pass {
// one if messages are of concern.
Pass() : consumer_(nullptr) {}
// Destructs the pass.
virtual ~Pass() = default;
// Returns a descriptive name for this pass.
virtual const char* name() const = 0;