openharmony/third_party_spirv-tools
1
0
Fork 0
mirror of https://gitee.com/openharmony/third_party_spirv-tools synced 2024-11-23 15:30:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix use of Logf to avoid format security warning (#2498)

Browse Source 
When -Wformat-security is enabled, we are getting an error.  I do not
claim to fully understand when the warning is triggered or not, but this
one can be avoided by calling "Log" instead of "Logf" because the
formating string is not needed.
This commit is contained in:
Steven Perron 2019-04-08 11:06:48 -04:00 committed by GitHub
parent 0cb2d4079e
commit 7ce37d66a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
source/opt/optimizer.cpp
View File

@ -526,10 +526,12 @@ bool Optimizer::Run(const uint32_t* original_binary,
binary_changed = true;
} else if (status == opt::Pass::Status::SuccessWithoutChange) {
if (optimized_binary->size() != original_binary_size ||
(memcmp(optimized_binary->data(), original_binary, original_binary_size) != 0)) {
(memcmp(optimized_binary->data(), original_binary,
original_binary_size) != 0)) {
binary_changed = true;
Logf(consumer(), SPV_MSG_WARNING, nullptr, {},
"Binary unexpectedly changed despite optimizer saying there was no change");
Log(consumer(), SPV_MSG_WARNING, nullptr, {},
"Binary unexpectedly changed despite optimizer saying there was no "
"change");
}
}