openharmony/third_party_spirv-tools
1
0
Fork 0
mirror of https://gitee.com/openharmony/third_party_spirv-tools synced 2024-11-23 07:20:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix symbol exports check, for Android build cases (#4342)

Browse Source 
- Ignore symbols marked as .hidden
- Ignore weakly linked thunks (_ZT prefix)

Without this, the exports check fails on the Android NDK build.
This commit is contained in:
David Neto 2021-06-23 12:03:34 -04:00 committed by GitHub
parent 0c21e50922
commit e992c96c89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
utils/check_symbol_exports.py
View File

@ -70,6 +70,12 @@ def check_library(library):
symbol_allowlist_pattern = re.compile(r'_Z[0-9]+(InitDefaults|AddDescriptors)_spvtoolsfuzz_2eprotov') symbol_allowlist_pattern = re.compile(r'_Z[0-9]+(InitDefaults|AddDescriptors)_spvtoolsfuzz_2eprotov')
symbol_is_new_or_delete = re.compile(r'^(_Zna|_Znw|_Zdl|_Zda)') symbol_is_new_or_delete = re.compile(r'^(_Zna|_Znw|_Zdl|_Zda)')
# Compilaion for Arm has various thunks for constructors, destructors, vtables.
# They are weak.
symbol_is_thunk = re.compile(r'^_ZT')
# This occurs in NDK builds.
symbol_is_hidden = re.compile(r'^\.hidden ')
seen = set() seen = set()
result = 0 result = 0
@ -82,9 +88,12 @@ def check_library(library):
seen.add(symbol) seen.add(symbol)
#print("look at '{}'".format(symbol)) #print("look at '{}'".format(symbol))
if not (symbol_is_new_or_delete.match(symbol) and linkage == 'w'): if not (symbol_is_new_or_delete.match(symbol) and linkage == 'w'):
if not (symbol_allowlist_pattern.match(symbol) or symbol_ok_pattern.match(symbol)): if not (symbol_is_thunk.match(symbol) and linkage == 'w'):
print('{}: error: Unescaped exported symbol: {}'.format(PROG, symbol)) if not (symbol_allowlist_pattern.match(symbol) or
result = 1 symbol_ok_pattern.match(symbol) or
symbol_is_hidden.match(symbol)):
print('{}: error: Unescaped exported symbol: {}'.format(PROG, symbol))
result = 1
return result return result