!590 [Codecheck] Fix codecheck for "Opt function"

Merge pull request !590 from ironrain/work_0210_None_forEachChild_p2

lib/tsserver.js

@@ -194285,6 +194285,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };
@@ -198342,6 +198343,7 @@ var ts;
                         if (scopeContainsThisVisitor(child)) {
                             return true;
                         }
+                        return undefined;
                     });
                     return !!isContain;
                 }
@@ -200007,6 +200009,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };

lib/tsserverlibrary.js

@@ -194030,6 +194030,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };
@@ -198087,6 +198088,7 @@ var ts;
                         if (scopeContainsThisVisitor(child)) {
                             return true;
                         }
+                        return undefined;
                     });
                     return !!isContain;
                 }
@@ -199752,6 +199754,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };

lib/typescript.js

@@ -183124,6 +183124,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };
@@ -187181,6 +187182,7 @@ var ts;
                         if (scopeContainsThisVisitor(child)) {
                             return true;
                         }
+                        return undefined;
                     });
                     return !!isContain;
                 }
@@ -188846,6 +188848,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };

lib/typescriptServices.js

@@ -183124,6 +183124,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };
@@ -187181,6 +187182,7 @@ var ts;
                         if (scopeContainsThisVisitor(child)) {
                             return true;
                         }
+                        return undefined;
                     });
                     return !!isContain;
                 }
@@ -188846,6 +188848,7 @@ var ts;
                     if (_this.checkAnyOrUnknownChildNode(child)) {
                         return true;
                     }
+                    return undefined;
                 });
                 return !!isAnyOrUnknown;
             };

src/linter/ArkTSLinter_1_0/TypeScriptLinter.ts

@@ -1917,7 +1917,8 @@ export class TypeScriptLinter {
       if (this.checkAnyOrUnknownChildNode(child)) {
         return true;
       }
-    })
+      return undefined;
+    });
     return !!isAnyOrUnknown;
   }
 

src/linter/ArkTSLinter_1_1/TypeScriptLinter.ts

@@ -402,7 +402,8 @@ export class TypeScriptLinter {
         if (scopeContainsThisVisitor(child)) {
           return true;
         }
-      })
+        return undefined;
+      });
       return !!isContain;
     }
 
@@ -2299,7 +2300,8 @@ export class TypeScriptLinter {
       if (this.checkAnyOrUnknownChildNode(child)) {
         return true;
       }
-    })
+      return undefined;
+    });
     return !!isAnyOrUnknown;
   }
 

tests/arkTSTest/testcase/multi-rule-consistency/function-ut-consistency-1.ets

@@ -4,7 +4,7 @@
 // are doing; otherwise, do not change the test results.
 
 class Shape {}
-class Circle extends Shape {x: unknown = 5}
+class Circle extends Shape { public x: unknown = 5}
 interface Paralle {
   pi: string
 }
@@ -17,5 +17,5 @@ let varIsObjAndRefAlias = varIsObjAndRef
 let vShape = createShape({ pi: { x: (varIsObjAndRefAlias as Circle).x as unknown } as any })
 let vShape2 = (vShape2Param?:(pp2:string)=>{})=>{}
 class CShape3 {
-  pShape3a1 = createShape({ pi: { x: (varIsObjAndRefAlias as Circle).x as unknown } as any })
+  public pShape3a1 = createShape({ pi: { x: (varIsObjAndRefAlias as Circle).x as unknown } as any })
 }

tests/arkTSTest/testcase/multi-rule-consistency/function-ut-consistency-1.json

@@ -4,7 +4,7 @@
       "messageText": "Use explicit types instead of \"any\", \"unknown\" (arkts-no-any-unknown)",
       "expectLineAndCharacter": {
         "line": 7,
-        "character": 32
+        "character": 40
       }
     },
     {
@@ -39,21 +39,21 @@
       "messageText": "Object literal must correspond to some explicitly declared class or interface (arkts-no-untyped-obj-literals)",
       "expectLineAndCharacter": {
         "line": 20,
-        "character": 27
+        "character": 34
       }
     },
     {
       "messageText": "Use explicit types instead of \"any\", \"unknown\" (arkts-no-any-unknown)",
       "expectLineAndCharacter": {
         "line": 20,
-        "character": 75
+        "character": 82
       }
     },
     {
       "messageText": "Use explicit types instead of \"any\", \"unknown\" (arkts-no-any-unknown)",
       "expectLineAndCharacter": {
         "line": 20,
-        "character": 88
+        "character": 95
       }
     }
   ],
@@ -62,7 +62,7 @@
       "messageText": "Use explicit types instead of \"any\", \"unknown\" (arkts-no-any-unknown)",
       "expectLineAndCharacter": {
         "line": 7,
-        "character": 32
+        "character": 40
       }
     },
     {
@@ -90,14 +90,14 @@
       "messageText": "Use explicit types instead of \"any\", \"unknown\" (arkts-no-any-unknown)",
       "expectLineAndCharacter": {
         "line": 20,
-        "character": 75
+        "character": 82
       }
     },
     {
       "messageText": "Use explicit types instead of \"any\", \"unknown\" (arkts-no-any-unknown)",
       "expectLineAndCharacter": {
         "line": 20,
-        "character": 88
+        "character": 95
       }
     }
   ]