openharmony/third_party_vulkan-loader
1
0
Fork 0
mirror of https://gitee.com/openharmony/third_party_vulkan-loader synced 2025-02-17 06:07:51 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Apply code review comments from @charles-lunarg

Browse Source
This commit is contained in:
Mark Young 2022-03-25 14:56:25 -06:00
parent d72909ee28
commit b383c5131e
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
loader/loader_linux.c
View File

@ -237,7 +237,7 @@ VkResult linux_read_sorted_physical_devices(struct loader_instance *inst, uint32
struct loader_physical_device_term **sorted_device_term) {
VkResult res = VK_SUCCESS;
bool app_is_vulkan_1_1 = false;
if (inst->app_api_major_version >= 1 && inst->app_api_minor_version >= 1) {
if (inst->app_api_major_version > 1 || inst->app_api_minor_version >= 1) {
app_is_vulkan_1_1 = true;
}
@ -249,8 +249,7 @@ VkResult linux_read_sorted_physical_devices(struct loader_instance *inst, uint32
}
memset(sorted_device_info, 0, inst->total_gpu_count * sizeof(struct LinuxSortedDeviceInfo));
loader_log(inst, VULKAN_LOADER_INFO_BIT | VULKAN_LOADER_DRIVER_BIT, 0,
"linux_read_sorted_physical_devices: (App Version %d.%d)", inst->app_api_major_version, inst->app_api_minor_version);
loader_log(inst, VULKAN_LOADER_INFO_BIT | VULKAN_LOADER_DRIVER_BIT, 0, "linux_read_sorted_physical_devices:");
loader_log(inst, VULKAN_LOADER_INFO_BIT | VULKAN_LOADER_DRIVER_BIT, 0, " Original order:");
// Grab all the necessary info we can about each device

4
tests/framework/icd/test_icd.cpp
View File

@ -73,13 +73,13 @@ bool CheckLayer(std::vector<LayerDefinition>& layers, std::string layerName) {
bool IsInstanceExtensionSupported(const char* extension_name) {
return icd.instance_extensions.end() !=
std::find_if(icd.instance_extensions.begin(), icd.instance_extensions.end(),
[extension_name](Extension const& ext) { return ext.extensionName == extension_name; });
[extension_name](Extension const& ext) { return string_eq(&ext.extensionName[0], extension_name); });
}
bool IsInstanceExtensionEnabled(const char* extension_name) {
return icd.enabled_instance_extensions.end() !=
std::find_if(icd.enabled_instance_extensions.begin(), icd.enabled_instance_extensions.end(),
[extension_name](Extension const& ext) { return ext.extensionName == extension_name; });
[extension_name](Extension const& ext) { return string_eq(&ext.extensionName[0], extension_name); });
}
bool IsPhysicalDeviceExtensionAvailable(const char* extension_name) {