openharmony/third_party_vulkan-loader
1
0
Fork 0
mirror of https://github.com/openharmony/third_party_vulkan-loader.git synced 2026-07-20 20:15:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

Guard loader.instances access with mutex.

Browse Source 
While the adding and removing of data from this global linked list
was guarded, GetInstanceProcAddr & GetDeviceProcAddr did not have
such guards. This results in race conditions that were detected with
thread sanitizer. This commit adds a mutex solely for the
loader.instances global variable.
This commit is contained in:
Charles Giessen
2022-05-20 12:18:41 -06:00
committed by Charles Giessen
parent 5d7a40f42d
commit f0fc8cf491
10 changed files with 118 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/loader_alloc_callback_tests.cpp
+2 -1
View File
@@ -468,6 +468,7 @@ TEST(Allocation, DriverEnvVarIntentionalAllocFail) {
ASSERT_TRUE(tracker.empty());
fail_index++;
}
remove_env_var("VK_DRIVER_FILES");
}
// Test failure during vkCreateDevice to make sure we don't leak memory if
@@ -484,7 +485,7 @@ TEST(Allocation, CreateDeviceIntentionalAllocFail) {
driver.physical_devices.emplace_back("physical_device_1");
driver.physical_devices[1].add_queue_family_properties({{VK_QUEUE_GRAPHICS_BIT, 1, 0, {1, 1, 1}}, false});
const char* layer_name = "VkLayerImplicit0";
const char* layer_name = "VK_LAYER_VkLayerImplicit0";
env.add_implicit_layer(ManifestLayer{}.add_layer(ManifestLayer::LayerDescription{}
.set_name(layer_name)
.set_lib_path(TEST_LAYER_PATH_EXPORT_VERSION_2)