mirror of
https://github.com/openharmony/third_party_vulkan-loader.git
synced 2026-07-21 20:45:25 -04:00
f0fc8cf491
While the adding and removing of data from this global linked list was guarded, GetInstanceProcAddr & GetDeviceProcAddr did not have such guards. This results in race conditions that were detected with thread sanitizer. This commit adds a mutex solely for the loader.instances global variable.
150 lines
7.9 KiB
C++
150 lines
7.9 KiB
C++
/*
|
|
* Copyright (c) 2021 The Khronos Group Inc.
|
|
* Copyright (c) 2021 Valve Corporation
|
|
* Copyright (c) 2021 LunarG, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and/or associated documentation files (the "Materials"), to
|
|
* deal in the Materials without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Materials, and to permit persons to whom the Materials are
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice(s) and this permission notice shall be included in
|
|
* all copies or substantial portions of the Materials.
|
|
*
|
|
* THE MATERIALS ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
*
|
|
* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE MATERIALS OR THE
|
|
* USE OR OTHER DEALINGS IN THE MATERIALS.
|
|
*
|
|
* Author: Charles Giessen <charles@lunarg.com>
|
|
*/
|
|
|
|
#include "test_environment.h"
|
|
|
|
#include <mutex>
|
|
#include <thread>
|
|
#include <atomic>
|
|
|
|
void create_destroy_instance_loop_with_function_queries(FrameworkEnvironment* env, uint32_t num_loops_create_destroy_instance,
|
|
uint32_t num_loops_try_get_instance_proc_addr,
|
|
uint32_t num_loops_try_get_device_proc_addr) {
|
|
for (uint32_t i = 0; i < num_loops_create_destroy_instance; i++) {
|
|
InstWrapper inst{env->vulkan_functions};
|
|
inst.CheckCreate();
|
|
PFN_vkEnumeratePhysicalDevices enum_pd = nullptr;
|
|
for (uint32_t j = 0; j < num_loops_try_get_instance_proc_addr; j++) {
|
|
enum_pd = inst.load("vkEnumeratePhysicalDevices");
|
|
ASSERT_NE(enum_pd, nullptr);
|
|
}
|
|
VkPhysicalDevice phys_dev = inst.GetPhysDev();
|
|
|
|
DeviceWrapper dev{inst};
|
|
dev.create_info.add_device_queue(DeviceQueueCreateInfo{}.add_priority(1.0));
|
|
dev.CheckCreate(phys_dev);
|
|
for (uint32_t j = 0; j < num_loops_try_get_device_proc_addr; j++) {
|
|
PFN_vkCmdBindPipeline p = dev.load("vkCmdBindPipeline");
|
|
p(VK_NULL_HANDLE, VkPipelineBindPoint::VK_PIPELINE_BIND_POINT_GRAPHICS, VK_NULL_HANDLE);
|
|
}
|
|
}
|
|
}
|
|
|
|
void create_destroy_device_loop(FrameworkEnvironment* env, uint32_t num_loops_create_destroy_device,
|
|
uint32_t num_loops_try_get_proc_addr) {
|
|
InstWrapper inst{env->vulkan_functions};
|
|
inst.CheckCreate();
|
|
VkPhysicalDevice phys_dev = inst.GetPhysDev();
|
|
for (uint32_t i = 0; i < num_loops_create_destroy_device; i++) {
|
|
DeviceWrapper dev{inst};
|
|
dev.create_info.add_device_queue(DeviceQueueCreateInfo{}.add_priority(1.0));
|
|
dev.CheckCreate(phys_dev);
|
|
|
|
for (uint32_t j = 0; j < num_loops_try_get_proc_addr; j++) {
|
|
PFN_vkCmdBindPipeline p = dev.load("vkCmdBindPipeline");
|
|
PFN_vkCmdBindDescriptorSets d = dev.load("vkCmdBindDescriptorSets");
|
|
PFN_vkCmdBindVertexBuffers vb = dev.load("vkCmdBindVertexBuffers");
|
|
PFN_vkCmdBindIndexBuffer ib = dev.load("vkCmdBindIndexBuffer");
|
|
PFN_vkCmdDraw c = dev.load("vkCmdDraw");
|
|
p(VK_NULL_HANDLE, VkPipelineBindPoint::VK_PIPELINE_BIND_POINT_GRAPHICS, VK_NULL_HANDLE);
|
|
d(VK_NULL_HANDLE, VkPipelineBindPoint::VK_PIPELINE_BIND_POINT_GRAPHICS, VK_NULL_HANDLE, 0, 0, nullptr, 0, nullptr);
|
|
vb(VK_NULL_HANDLE, 0, 0, nullptr, nullptr);
|
|
ib(VK_NULL_HANDLE, 0, 0, VkIndexType::VK_INDEX_TYPE_UINT16);
|
|
c(VK_NULL_HANDLE, 0, 0, 0, 0);
|
|
}
|
|
}
|
|
}
|
|
VKAPI_ATTR void VKAPI_CALL test_vkCmdBindPipeline(VkCommandBuffer cmd_buf, VkPipelineBindPoint pipelineBindPoint,
|
|
VkPipeline pipeline) {}
|
|
VKAPI_ATTR void VKAPI_CALL test_vkCmdBindDescriptorSets(VkCommandBuffer cmd_buf, VkPipelineBindPoint pipelineBindPoint,
|
|
VkPipelineLayout layout, uint32_t firstSet, uint32_t descriptorSetCount,
|
|
const VkDescriptorSet* pDescriptorSets, uint32_t dynamicOffsetCount,
|
|
const uint32_t* pDynamicOffsets) {}
|
|
VKAPI_ATTR void VKAPI_CALL test_vkCmdBindVertexBuffers(VkCommandBuffer cmd_buf, uint32_t firstBinding, uint32_t bindingCount,
|
|
const VkBuffer* pBuffers, const VkDeviceSize* pOffsets) {}
|
|
VKAPI_ATTR void VKAPI_CALL test_vkCmdBindIndexBuffer(VkCommandBuffer cmd_buf, uint32_t firstBinding, uint32_t bindingCount,
|
|
const VkBuffer* pBuffers, const VkDeviceSize* pOffsets) {}
|
|
VKAPI_ATTR void VKAPI_CALL test_vkCmdDraw(VkCommandBuffer cmd_buf, uint32_t vertexCount, uint32_t instanceCount,
|
|
uint32_t firstVertex, uint32_t firstInstance) {}
|
|
TEST(Threading, InstanceCreateDestroyLoop) {
|
|
const auto processor_count = std::thread::hardware_concurrency();
|
|
|
|
FrameworkEnvironment env{false};
|
|
env.add_icd(TestICDDetails(TEST_ICD_PATH_VERSION_2_EXPORT_ICD_GPDPA));
|
|
uint32_t num_loops_create_destroy_instance = 500;
|
|
uint32_t num_loops_try_get_instance_proc_addr = 5;
|
|
uint32_t num_loops_try_get_device_proc_addr = 100;
|
|
auto& driver = env.get_test_icd();
|
|
|
|
driver.physical_devices.emplace_back("physical_device_0");
|
|
driver.physical_devices.back().known_device_functions.push_back(
|
|
{"vkCmdBindPipeline", to_vkVoidFunction(test_vkCmdBindPipeline)});
|
|
|
|
std::vector<std::thread> instance_creation_threads;
|
|
std::vector<std::thread> function_query_threads;
|
|
for (uint32_t i = 0; i < processor_count; i++) {
|
|
instance_creation_threads.emplace_back(create_destroy_instance_loop_with_function_queries, &env,
|
|
num_loops_create_destroy_instance, num_loops_try_get_instance_proc_addr,
|
|
num_loops_try_get_device_proc_addr);
|
|
}
|
|
for (uint32_t i = 0; i < processor_count; i++) {
|
|
instance_creation_threads[i].join();
|
|
}
|
|
}
|
|
|
|
TEST(Threading, DeviceCreateDestroyLoop) {
|
|
const auto processor_count = std::thread::hardware_concurrency();
|
|
|
|
FrameworkEnvironment env{false};
|
|
env.add_icd(TestICDDetails(TEST_ICD_PATH_VERSION_2_EXPORT_ICD_GPDPA));
|
|
|
|
uint32_t num_loops_create_destroy_device = 1000;
|
|
uint32_t num_loops_try_get_device_proc_addr = 5;
|
|
auto& driver = env.get_test_icd();
|
|
|
|
driver.physical_devices.emplace_back("physical_device_0");
|
|
driver.physical_devices.back().known_device_functions.push_back(
|
|
{"vkCmdBindPipeline", to_vkVoidFunction(test_vkCmdBindPipeline)});
|
|
driver.physical_devices.back().known_device_functions.push_back(
|
|
{"vkCmdBindDescriptorSets", to_vkVoidFunction(test_vkCmdBindDescriptorSets)});
|
|
driver.physical_devices.back().known_device_functions.push_back(
|
|
{"vkCmdBindVertexBuffers", to_vkVoidFunction(test_vkCmdBindVertexBuffers)});
|
|
driver.physical_devices.back().known_device_functions.push_back(
|
|
{"vkCmdBindIndexBuffer", to_vkVoidFunction(test_vkCmdBindIndexBuffer)});
|
|
driver.physical_devices.back().known_device_functions.push_back({"vkCmdDraw", to_vkVoidFunction(test_vkCmdDraw)});
|
|
|
|
std::vector<std::thread> device_creation_threads;
|
|
|
|
for (uint32_t i = 0; i < processor_count; i++) {
|
|
device_creation_threads.emplace_back(create_destroy_device_loop, &env, num_loops_create_destroy_device,
|
|
num_loops_try_get_device_proc_addr);
|
|
}
|
|
for (uint32_t i = 0; i < processor_count; i++) {
|
|
device_creation_threads[i].join();
|
|
}
|
|
}
|