diff --git a/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php b/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php index 0e9cad98df..40be930544 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php +++ b/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.php @@ -131,7 +131,7 @@ class NetworkInterface extends BaseModel /* flush actions that need to be applied, for which we need history (config reflects running config) */ $todo = [ 'pending' => $this->interface->$key->toLegacy(), - 'pending_action' => 'update' + 'pending_action' => 'update', ]; $changed = false; if ($intf->if != $interfaces[$key]['if']) { @@ -141,7 +141,7 @@ class NetworkInterface extends BaseModel if ($prop === 'dhcp6_norequest_dns' && !isset($intf->$prop)) { $curval = '0'; /* actually stored as dhcp6_request_dns in our model */ } elseif (!isset($intf->$prop)) { - $curval = $this->interface->$key->$prop instanceof BooleanField ? '0' : ''; + $curval = ($this->interface->$key->$prop instanceof BooleanField) ? '0' : ''; } else { $curval = $intf->$prop; } @@ -174,7 +174,7 @@ class NetworkInterface extends BaseModel if ($node !== null) { $this->store_if_todo($newIdentifier, [ 'pending' => $node->toLegacy(), - 'pending_action' => 'update' + 'pending_action' => 'update', ]); /* We want the node to return the new network identifier as the uuid not diff --git a/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.xml b/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.xml index 87e3c2ea00..828b6efd76 100644 --- a/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.xml +++ b/src/opnsense/mvc/app/models/OPNsense/Interfaces/NetworkInterface.xml @@ -149,7 +149,6 @@ - Y 0 64