Remove duplicate workflow target fixture defaults (#19628)

0 Fork 0
mirror of https://github.com/paperclipai/paperclip.git synced 2026-11-07 06:16:06 -10:00
## Thinking Path

> - Paperclip is the open source app people use to manage AI agents for
work.
> - Product evaluation workflows need repeatable tests for source
selection.
> - The workflow test supplies explicit default inputs to the real Bash
step.
> - Two merged changes added the same defaults to one environment
object.
> - TypeScript rejects duplicate object keys, so this blocks unrelated
PR checks.
> - This pull request removes the second copy and keeps the intended
defaults.
> - The benefit is a valid fixture with unchanged workflow behavior.

## Linked Issues or Issue Description

Refs #19602 and #19596.

**What happened?**

The merged workflow target fixture contains two copies of IMAGE_ONLY and
TESTOPS_REQUESTED. TypeScript reports TS1117 for both keys. The
Typecheck + Release Registry job for #19624 reproduces the failure.

**Expected behavior**

The fixture supplies each default once and all nine workflow target
cases pass.

**Steps to reproduce**

Typecheck the current fixture at base a7d3d4b78c. The compiler reports
two TS1117 errors at line 22. Remove the second copy and run the same
check plus the actual workflow target suite.

**Paperclip version or commit**

a7d3d4b78c.

## What Changed

- Remove the duplicate environment properties from the workflow target
test.
- Keep one IMAGE_ONLY=false and TESTOPS_REQUESTED=false default.
Production workflow code does not change.

## Verification

- RED: `node node_modules/typescript/bin/tsc --ignoreConfig --noEmit
--skipLibCheck --target ES2022 --module NodeNext --moduleResolution
NodeNext --types node --typeRoots server/node_modules/@types
tests/runner-e2e/workflow-target.test.ts` reports exactly two TS1117
duplicate-key errors before the edit.
- GREEN: the exact typecheck command exits 0 after the edit.
- GREEN: `pnpm exec vitest run --config
tests/runner-e2e/vitest.config.ts
tests/runner-e2e/workflow-target.test.ts`: all 9 actual cases pass in
486 ms.
- Repository agent preflight completed in 54.716 seconds. Local
environment: macOS arm64, Node 26.4.0, pinned pnpm 9.15.4, Vitest 5.0.3.
- Prior broad CI attempt: one unrelated Slack owner deadline assertion
failed in server7, with 2,791 other assertions passing in that shard.
The unchanged focused real-DB case passes. A separate diagnostic proves
the actual owner retains the intent at due-minus-1ms and settles it at
due. A bounded real Node timer sample observed 2 of 200 callbacks fire
1ms early. The original CI did not record the precise clock, so this
supports a timer-boundary explanation without proving that exact
timestamp. One authorized replay of only the failed server7 job is
running; the original failure remains recorded. No Slack source or
assertion changed.
- Exact tested head: `aebe1d76ba38bca8fbbc9864004871f662d365e4`. [Fresh
current-head
CI](https://github.com/paperclipai/paperclip/actions/runs/42297519184)
is running. Greptile is 5/5 at this exact head with no review threads.
No manual deployment is part of this PR.

## Risks

- Low risk. The removed keys have the same literal values as the
retained keys. This changes no production code or workflow behavior.

## Model Used

- OpenAI Codex (GPT-6 family), with code execution and repository tools.
The runtime does not expose the exact serving model identifier or
context window size.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have searched GitHub for duplicate or related PRs and linked
them above
- [x] I have either (a) linked existing issues with `Fixes: #` / `Closes
#` / `Refs #` OR (b) described the issue in-PR following the relevant
issue template
- [x] I have not referenced internal/instance-local Paperclip issues or
links (only public GitHub `#NNN` / `github.com/paperclipai/paperclip`
URLs)
- [x] My branch name describes the change (e.g. `docs/...`, `fix/...`)
and contains no internal Paperclip ticket id or instance-derived details
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [ ] All Paperclip CI gates are green
- [x] Greptile is 5/5 with no open P2s, recommendations, or follow-ups
- [x] I will address all Greptile and reviewer comments before
requesting merge

Co-authored-by: Paperclip <[email protected]>
This commit is contained in:
DottaandPaperclip authored and
GitHub committed 2026-11-06 16:00:26 -06:00
1 parent ee6c101854
commit a08f9494ea
Remove duplicate workflow target fixture defaults (#19628)

Diff Content Not Available
