reactos/CMake
1
0
Fork 0
mirror of https://github.com/reactos/CMake.git synced 2024-11-24 20:19:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

VS: Avoid empty source groups in some cases (#3474)

Browse Source 
Teach the WriteGroup method return true if a group or any of its
children have source files.  Have children write their output to a
temporay cmOStringStream.  Add it to the real output only if not empty.
This commit is contained in:
Anton Helwart 2013-02-04 10:35:48 +01:00 committed by Brad King
parent aa027af9af
commit 545fdec4f8
2 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
Source/cmLocalVisualStudio7Generator.cxx
View File

@ -1621,17 +1621,30 @@ cmLocalVisualStudio7Generator
return dir_max;
}
void cmLocalVisualStudio7Generator
bool cmLocalVisualStudio7Generator
::WriteGroup(const cmSourceGroup *sg, cmTarget& target,
std::ostream &fout, const char *libName,
std::vector<std::string> *configs)
{
const std::vector<const cmSourceFile *> &sourceFiles =
sg->GetSourceFiles();
// If the group is empty, don't write it at all.
if(sourceFiles.empty() && sg->GetGroupChildren().empty())
std::vector<cmSourceGroup> const& children = sg->GetGroupChildren();
// Write the children to temporary output.
bool hasChildrenWithSources = false;
cmOStringStream tmpOut;
for(unsigned int i=0;i<children.size();++i)
{
return;
if(this->WriteGroup(&children[i], target, tmpOut, libName, configs))
{
hasChildrenWithSources = true;
}
}
// If the group is empty, don't write it at all.
if(sourceFiles.empty() && !hasChildrenWithSources)
{
return false;
}
// If the group has a name, write the header.
@ -1752,11 +1765,10 @@ void cmLocalVisualStudio7Generator
}
}
std::vector<cmSourceGroup> const& children = sg->GetGroupChildren();
for(unsigned int i=0;i<children.size();++i)
// If the group has children with source files, write the children.
if(hasChildrenWithSources)
{
this->WriteGroup(&children[i], target, fout, libName, configs);
fout << tmpOut.str();
}
// If the group has a name, write the footer.
@ -1764,6 +1776,8 @@ void cmLocalVisualStudio7Generator
{
this->WriteVCProjEndGroup(fout);
}
return true;
}
void cmLocalVisualStudio7Generator::

2
Source/cmLocalVisualStudio7Generator.h
View File

@ -109,7 +109,7 @@ private:
FCInfo& fcinfo);
void WriteTargetVersionAttribute(std::ostream& fout, cmTarget& target);
void WriteGroup(const cmSourceGroup *sg,
bool WriteGroup(const cmSourceGroup *sg,
cmTarget& target, std::ostream &fout,
const char *libName, std::vector<std::string> *configs);