reactos/CMake
1
0
Fork 0
mirror of https://github.com/reactos/CMake.git synced 2024-11-24 03:59:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

MSBuild: Fix python mutable default data structure

Browse Source 
Change default value of arguments to be None and instantiate new
object inside function.
This commit is contained in:
Brendon Go 2020-03-05 20:42:46 -05:00
parent e484b4289d
commit 98e735903a
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Source/cmConvertMSBuildXMLToJSON.py
View File

@ -35,12 +35,14 @@ def vsflags(*args):
return values
def read_msbuild_xml(path, values={}):
def read_msbuild_xml(path, values=None):
"""Reads the MS Build XML file at the path and returns its contents.
Keyword arguments:
values -- The map to append the contents to (default {})
"""
if values is None:
values = {}
# Attempt to read the file contents
try:
@ -76,12 +78,15 @@ def read_msbuild_xml(path, values={}):
return values
def read_msbuild_json(path, values=[]):
def read_msbuild_json(path, values=None):
"""Reads the MS Build JSON file at the path and returns its contents.
Keyword arguments:
values -- The list to append the contents to (default [])
"""
if values is None:
values = []
if not os.path.exists(path):
logging.info('Could not find MS Build JSON file at %s', path)
return values