From a980fdc96a07bc469e77b37067dc76020d6e02f9 Mon Sep 17 00:00:00 2001 From: Alexander Neundorf Date: Mon, 20 Mar 2006 12:29:56 -0500 Subject: [PATCH] BUG: don't include MacroLibrary.cmake, but add a cmake module which implements ADD_FILE_DEPENDENCIES() ENH: mark the variables from FindPNG.cmake as advanced Alex --- Modules/AddFileDependencies.cmake | 16 ++++++++++++++++ Modules/FindPNG.cmake | 8 ++++---- Modules/KDE3Macros.cmake | 4 ++-- 3 files changed, 22 insertions(+), 6 deletions(-) create mode 100644 Modules/AddFileDependencies.cmake diff --git a/Modules/AddFileDependencies.cmake b/Modules/AddFileDependencies.cmake new file mode 100644 index 0000000000..0ea64708a1 --- /dev/null +++ b/Modules/AddFileDependencies.cmake @@ -0,0 +1,16 @@ +# - ADD_FILE_DEPENDENCIES(source_file depend_files...) +# Adds the given files as dependencies to source_file +# + +MACRO(ADD_FILE_DEPENDENCIES _file) + + GET_SOURCE_FILE_PROPERTY(_deps ${_file} OBJECT_DEPENDS) + IF (_deps) + SET(_deps ${_deps} ${ARGN}) + ELSE (_deps) + SET(_deps ${ARGN}) + ENDIF (_deps) + + SET_SOURCE_FILES_PROPERTIES(${_file} PROPERTIES OBJECT_DEPENDS "${_deps}") + +ENDMACRO(ADD_FILE_DEPENDENCIES) diff --git a/Modules/FindPNG.cmake b/Modules/FindPNG.cmake index 861d47196a..f078242346 100644 --- a/Modules/FindPNG.cmake +++ b/Modules/FindPNG.cmake @@ -24,8 +24,7 @@ IF(ZLIB_FOUND) PATHS /usr/lib /usr/local/lib ) - IF (PNG_LIBRARY) - IF (PNG_PNG_INCLUDE_DIR) + IF (PNG_LIBRARY AND PNG_PNG_INCLUDE_DIR) # png.h includes zlib.h. Sigh. SET(PNG_INCLUDE_DIR ${PNG_PNG_INCLUDE_DIR} ${ZLIB_INCLUDE_DIR} ) SET(PNG_LIBRARIES ${PNG_LIBRARY} ${ZLIB_LIBRARY}) @@ -39,7 +38,8 @@ IF(ZLIB_FOUND) ENDIF(BUILD_SHARED_LIBS) ENDIF (CYGWIN) - ENDIF (PNG_PNG_INCLUDE_DIR) - ENDIF (PNG_LIBRARY) + ENDIF (PNG_LIBRARY AND PNG_PNG_INCLUDE_DIR) ENDIF(ZLIB_FOUND) + +MARK_AS_ADVANCED(PNG_PNG_INCLUDE_DIR PNG_LIBRARY ) diff --git a/Modules/KDE3Macros.cmake b/Modules/KDE3Macros.cmake index 99dfb5f74b..17e4384067 100644 --- a/Modules/KDE3Macros.cmake +++ b/Modules/KDE3Macros.cmake @@ -18,7 +18,7 @@ #neundorf@kde.org -INCLUDE(MacroLibrary) +INCLUDE(AddFileDependencies) #create the kidl and skeletion file for dcop stuff #usage: KDE_ADD_COP_SKELS(foo_SRCS ${dcop_headers}) @@ -226,7 +226,7 @@ MACRO(KDE3_AUTOMOC) DEPENDS ${_header} ) - MACRO_ADD_FILE_DEPENDENCIES(${_abs_FILE} ${_moc}) + ADD_FILE_DEPENDENCIES(${_abs_FILE} ${_moc}) ENDFOREACH (_current_MOC_INC) ENDIF(_match)