reactos/CMake
1
0
Fork 0
mirror of https://github.com/reactos/CMake.git synced 2024-11-24 03:59:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update cpplint support to return 0 and mark warnings for CDash.

Browse Source 
This commit makes cpplint act like the other compiler mirroring tools. It
will always return 0 even if it reports warnings and will only return non
zero if there is a problem running the command. In addition, it will now
add some extra text to allow CTest to recognize the warnings and report
them correctly to CDash.
This commit is contained in:
Bill Hoffman 2017-11-30 17:36:43 -05:00
parent 8b5ae1c1d3
commit bfcc20343c
5 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/cmcmd.cxx
View File

@ -270,10 +270,12 @@ static int HandleCppLint(const std::string& runCmd,
<< "\n";
return 1;
}
std::cerr << "Warning: cpplint diagnostics:\n";
// Output the output from cpplint to stderr
std::cerr << stdOut;
return ret;
// always return 0 so the build can continue as cpplint returns non-zero
// for any warning
return 0;
}
static int HandleCppCheck(const std::string& runCmd,

2
Tests/RunCMake/Cpplint/C-error-Build-result.txt
View File

@ -1 +1 @@
[^0]
0

2
Tests/RunCMake/Cpplint/C-error-launch-Build-result.txt
View File

@ -1 +1 @@
[^0]
0

2
Tests/RunCMake/Cpplint/CXX-error-Build-result.txt
View File

@ -1 +1 @@
[^0]
0

2
Tests/RunCMake/Cpplint/CXX-error-launch-Build-result.txt
View File

@ -1 +1 @@
[^0]
0