reactos/CMake
1
0
Fork 0
mirror of https://github.com/reactos/CMake.git synced 2024-12-04 09:54:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

cmake: Teach -E remove_directory to remove directory symlinks

Browse Source 
If the argument to `remove_directory` is a symlink to a directory,
remove the symlink instead.

Issue: #19533
This commit is contained in:
Jon Chronopoulos 2019-08-26 14:21:12 +10:00 committed by Brad King
parent 2a1be178de
commit e6c9a8bac3
6 changed files with 34 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Source/cmcmd.cxx
View File

@ -676,10 +676,17 @@ int cmcmd::ExecuteCMakeCommand(std::vector<std::string> const& args)
// If an error occurs, we want to continue removing directories.
bool return_value = false;
for (auto const& arg : cmMakeRange(args).advance(2)) {
if (cmSystemTools::FileIsDirectory(arg) &&
!cmSystemTools::RemoveADirectory(arg)) {
std::cerr << "Error removing directory \"" << arg << "\".\n";
return_value = true;
if (cmSystemTools::FileIsDirectory(arg)) {
if (cmSystemTools::FileIsSymlink(arg)) {
if (!cmSystemTools::RemoveFile(arg)) {
std::cerr << "Error removing directory symlink \"" << arg
<< "\".\n";
return_value = true;
}
} else if (!cmSystemTools::RemoveADirectory(arg)) {
std::cerr << "Error removing directory \"" << arg << "\".\n";
return_value = true;
}
}
}
return return_value;

6
Tests/RunCMake/CommandLine/E_remove_directory-symlink-dir-check.cmake Normal file
View File

@ -0,0 +1,6 @@
if(EXISTS ${out}/link_dir)
set(RunCMake_TEST_FAILED "did not remove ${out}/link_dir")
endif()
if(NOT EXISTS ${out}/dir)
set(RunCMake_TEST_FAILED "should not have removed ${out}/dir")
endif()

0
Tests/RunCMake/CommandLine/E_remove_directory-symlink-dir-stderr.txt Normal file
View File

6
Tests/RunCMake/CommandLine/E_remove_directory-symlink-file-check.cmake Normal file
View File

@ -0,0 +1,6 @@
if(NOT EXISTS ${outfile})
set(RunCMake_TEST_FAILED "removed non-directory ${outfile}")
endif()
if(NOT EXISTS ${out}/link_file_for_test.txt)
set(RunCMake_TEST_FAILED "removed non-directory symlink ${out}/link_file_for_test.txt")
endif()

0
Tests/RunCMake/CommandLine/E_remove_directory-symlink-file-stderr.txt Normal file
View File

11
Tests/RunCMake/CommandLine/RunCMakeTest.cmake
View File

@ -348,6 +348,17 @@ run_cmake_command(E_make_directory-two-directories-and-file
${CMAKE_COMMAND} -E make_directory ${out}/d1 ${out}/d2 ${outfile})
run_cmake_command(E_remove_directory-two-directories-and-file
${CMAKE_COMMAND} -E remove_directory ${out}/d1 ${out}/d2 ${outfile})
if(UNIX)
file(MAKE_DIRECTORY ${out}/dir)
file(CREATE_LINK ${out}/dir ${out}/link_dir SYMBOLIC)
file(CREATE_LINK ${outfile} ${out}/link_file_for_test.txt SYMBOLIC)
run_cmake_command(E_remove_directory-symlink-dir
${CMAKE_COMMAND} -E remove_directory ${out}/link_dir)
run_cmake_command(E_remove_directory-symlink-file
${CMAKE_COMMAND} -E remove_directory ${out}/link_file_for_test.txt)
endif()
unset(out)
unset(outfile)