mirror of
https://github.com/reactos/CMake.git
synced 2024-12-13 14:27:23 +00:00
7c36d2067b
Since commit v3.4.0-rc1~321^2~2 (Genex: Store a backtrace, not a pointer to one, 2015-07-08) we treat cmListFileBacktrace instances as lightweight values. This was true at the time only because the backtrace information was kept in the cmState snapshot hierarchy. However, that forced us to accumulate a lot of otherwise short-lived snapshots just to have the backtrace fields available for reference by cmListFileBacktrace instances. Recent refactoring made backtrace instances independent of the snapshot hierarchy to avoid accumulating short-lived snapshots. This came at the cost of making backtrace values heavy again, leading to lots of string coying and slower execution. Fix this by refactoring cmListFileBacktrace to provide value semantics with efficient shared storage underneath. Teach cmMakefile to maintain its call stack using an instance of cmListFileBacktrace. This approach allows the current backtrace to be efficiently saved whenever it is needed. Also teach cmListFileBacktrace the notion of a file-level scope. This is useful for messages about the whole file (e.g. during parsing) that are not specific to any line within it. Push the CMakeLists.txt scope for each directory and never pop it. This ensures that we always have some context information and simplifies cmMakefile::IssueMessage. Push/pop a file-level scope as each included file is processed. This supersedes cmParseFileScope and improves diagnostic message context information in a few places. Fix the corresponding test cases to expect the improved output. |
||
|---|---|---|
| .. | ||
| dir1 | ||
| CMakeLists.txt | ||
| dir-in-macro-generate-time-result.txt | ||
| dir-in-macro-generate-time-stderr.txt | ||
| dir-in-macro-generate-time.cmake | ||
| dir-in-macro-include.cmake | ||
| NotClosed-result.txt | ||
| NotClosed-stderr.txt | ||
| NotClosed.cmake | ||
| NotOpened-result.txt | ||
| NotOpened-stderr.txt | ||
| NotOpened.cmake | ||
| parent-dir-generate-time-result.txt | ||
| parent-dir-generate-time.cmake | ||
| RunCMakeTest.cmake | ||