mirror of
https://github.com/reactos/CMake.git
synced 2024-11-24 03:59:58 +00:00
c621839bd9
Add a new property flag for a target which contains a message regarding deprecation status. Add a warning at "Generate" time if a linked target is marked as deprecated. Expand ExportImport test to ensure that new property is being set and passed correctly. Ensure that the message is shown during the "Generate" step run of the ExportImport test.
113 lines
3.2 KiB
C++
113 lines
3.2 KiB
C++
/* Distributed under the OSI-approved BSD 3-Clause License. See accompanying
|
|
file Copyright.txt or https://cmake.org/licensing for details. */
|
|
|
|
#include "cmTargetPropertyComputer.h"
|
|
|
|
#include <cctype>
|
|
#include <sstream>
|
|
#include <unordered_set>
|
|
|
|
#include "cmMessageType.h"
|
|
#include "cmMessenger.h"
|
|
#include "cmPolicies.h"
|
|
#include "cmStateSnapshot.h"
|
|
#include "cmStringAlgorithms.h"
|
|
|
|
bool cmTargetPropertyComputer::HandleLocationPropertyPolicy(
|
|
std::string const& tgtName, cmMessenger* messenger,
|
|
cmListFileBacktrace const& context)
|
|
{
|
|
std::ostringstream e;
|
|
const char* modal = nullptr;
|
|
MessageType messageType = MessageType::AUTHOR_WARNING;
|
|
switch (context.GetBottom().GetPolicy(cmPolicies::CMP0026)) {
|
|
case cmPolicies::WARN:
|
|
e << cmPolicies::GetPolicyWarning(cmPolicies::CMP0026) << "\n";
|
|
modal = "should";
|
|
case cmPolicies::OLD:
|
|
break;
|
|
case cmPolicies::REQUIRED_ALWAYS:
|
|
case cmPolicies::REQUIRED_IF_USED:
|
|
case cmPolicies::NEW:
|
|
modal = "may";
|
|
messageType = MessageType::FATAL_ERROR;
|
|
}
|
|
|
|
if (modal) {
|
|
e << "The LOCATION property " << modal << " not be read from target \""
|
|
<< tgtName
|
|
<< "\". Use the target name directly with "
|
|
"add_custom_command, or use the generator expression $<TARGET_FILE>, "
|
|
"as appropriate.\n";
|
|
messenger->IssueMessage(messageType, e.str(), context);
|
|
}
|
|
|
|
return messageType != MessageType::FATAL_ERROR;
|
|
}
|
|
|
|
bool cmTargetPropertyComputer::WhiteListedInterfaceProperty(
|
|
const std::string& prop)
|
|
{
|
|
if (cmHasLiteralPrefix(prop, "INTERFACE_")) {
|
|
return true;
|
|
}
|
|
if (cmHasLiteralPrefix(prop, "_")) {
|
|
return true;
|
|
}
|
|
if (std::islower(prop[0])) {
|
|
return true;
|
|
}
|
|
static std::unordered_set<std::string> const builtIns{
|
|
"COMPATIBLE_INTERFACE_BOOL",
|
|
"COMPATIBLE_INTERFACE_NUMBER_MAX",
|
|
"COMPATIBLE_INTERFACE_NUMBER_MIN",
|
|
"COMPATIBLE_INTERFACE_STRING",
|
|
"DEPRECATION",
|
|
"EXPORT_NAME",
|
|
"EXPORT_PROPERTIES",
|
|
"IMPORTED",
|
|
"IMPORTED_GLOBAL",
|
|
"MANUALLY_ADDED_DEPENDENCIES",
|
|
"NAME",
|
|
"PRIVATE_HEADER",
|
|
"PUBLIC_HEADER",
|
|
"TYPE"
|
|
};
|
|
|
|
if (builtIns.count(prop)) {
|
|
return true;
|
|
}
|
|
|
|
if (prop == "IMPORTED_CONFIGURATIONS" || prop == "IMPORTED_LIBNAME" ||
|
|
cmHasLiteralPrefix(prop, "IMPORTED_LIBNAME_") ||
|
|
cmHasLiteralPrefix(prop, "MAP_IMPORTED_CONFIG_")) {
|
|
return true;
|
|
}
|
|
|
|
// This property should not be allowed but was incorrectly added in
|
|
// CMake 3.8. We can't remove it from the whitelist without breaking
|
|
// projects that try to set it. One day we could warn about this, but
|
|
// for now silently accept it.
|
|
if (prop == "NO_SYSTEM_FROM_IMPORTED") {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool cmTargetPropertyComputer::PassesWhitelist(
|
|
cmStateEnums::TargetType tgtType, std::string const& prop,
|
|
cmMessenger* messenger, cmListFileBacktrace const& context)
|
|
{
|
|
if (tgtType == cmStateEnums::INTERFACE_LIBRARY &&
|
|
!WhiteListedInterfaceProperty(prop)) {
|
|
std::ostringstream e;
|
|
e << "INTERFACE_LIBRARY targets may only have whitelisted properties. "
|
|
"The property \""
|
|
<< prop << "\" is not allowed.";
|
|
messenger->IssueMessage(MessageType::FATAL_ERROR, e.str(), context);
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|