From 5995c2abafe77800d589280e0e681707be26ad65 Mon Sep 17 00:00:00 2001 From: Colin Finck Date: Thu, 28 Jan 2016 08:01:23 +0000 Subject: [PATCH] [RELEASE_ENGINEERING] - Fix the echo commands (strings should preferably be inside quote marks, and this is mandatory when the string has e.g. parentheses or sub-quotes inside it). - Add terminating newlines in the Readme.txt and in the script files. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Patch by Hermès Note to myself: Better test your changes next time, even small one-liner changes of an echo command.. svn path=/trunk/Release_Engineering/; revision=2260 --- Release_Configure | 6 +++--- Release_ISOs | 4 ++-- Release_Source | 4 ++-- VM-Templates/QEMU/Readme.txt | 2 +- VM-Templates/QEMU/boot.bat | 2 +- VM-Templates/QEMU/install.bat | 2 +- VM-Templates/VBox/Readme.txt | 2 +- VM-Templates/VMware/Readme.txt | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Release_Configure b/Release_Configure index 4736c4b..428f27e 100755 --- a/Release_Configure +++ b/Release_Configure @@ -4,7 +4,7 @@ # Sanity checks if [ "$ROS_ARCH" = "" ]; then - echo Please run this script inside RosBE! + echo "Please run this script inside RosBE!" exit 1 fi @@ -15,14 +15,14 @@ echo # Ask for the version while [ "$version" = "" ]; do - echo What ReactOS version number do you want to release? (e.g. "0.4.0" or "0.4.0-RC1") + echo "What ReactOS version number do you want to release? (e.g. \"0.4.0\" or \"0.4.0-RC1\")" read version echo done # Ask for the branch name while [ "$branch_name" = "" ]; do - echo What is the name of the SVN branch? (e.g. "ros-branch-0_4_0") + echo "What is the name of the SVN branch? (e.g. \"ros-branch-0_4_0\")" read branch_name echo done diff --git a/Release_ISOs b/Release_ISOs index 5bcca15..1e72dbd 100755 --- a/Release_ISOs +++ b/Release_ISOs @@ -4,12 +4,12 @@ # Sanity checks if ! source ./Release_Config; then - echo Please run Release_Configure first! + echo "Please run Release_Configure first!" exit 1 fi if [ "$ROS_ARCH" = "" ]; then - echo Please run this script inside RosBE! + echo "Please run this script inside RosBE!" exit 1 fi diff --git a/Release_Source b/Release_Source index 9abd02c..08ea8a0 100755 --- a/Release_Source +++ b/Release_Source @@ -4,12 +4,12 @@ # Sanity checks if ! source ./Release_Config; then - echo Please run Release_Configure first! + echo "Please run Release_Configure first!" exit 1 fi if [ "$ROS_ARCH" = "" ]; then - echo Please run this script inside RosBE! + echo "Please run this script inside RosBE!" exit 1 fi diff --git a/VM-Templates/QEMU/Readme.txt b/VM-Templates/QEMU/Readme.txt index e502921..ffa44ad 100644 --- a/VM-Templates/QEMU/Readme.txt +++ b/VM-Templates/QEMU/Readme.txt @@ -45,4 +45,4 @@ Otherwise modify the command line accordingly. After you unmounted the changed hard disk, you can boot it by executing the following command: - qemu -m 128 -hda ReactOS.hd \ No newline at end of file + qemu -m 128 -hda ReactOS.hd diff --git a/VM-Templates/QEMU/boot.bat b/VM-Templates/QEMU/boot.bat index 29b0cbb..9b8a483 100644 --- a/VM-Templates/QEMU/boot.bat +++ b/VM-Templates/QEMU/boot.bat @@ -1,3 +1,3 @@ @echo off cd files -qemu -L . -m 128 -hda ReactOS.vmdk -net nic,model=ne2k_pci -net user -serial file:CON \ No newline at end of file +qemu -L . -m 128 -hda ReactOS.vmdk -net nic,model=ne2k_pci -net user -serial file:CON diff --git a/VM-Templates/QEMU/install.bat b/VM-Templates/QEMU/install.bat index 06577c2..694c37e 100644 --- a/VM-Templates/QEMU/install.bat +++ b/VM-Templates/QEMU/install.bat @@ -1,3 +1,3 @@ @echo off cd files -qemu -L . -m 128 -hda ReactOS.vmdk -net nic,model=ne2k_pci -net user -cdrom ReactOS.iso -boot d \ No newline at end of file +qemu -L . -m 128 -hda ReactOS.vmdk -net nic,model=ne2k_pci -net user -cdrom ReactOS.iso -boot d diff --git a/VM-Templates/VBox/Readme.txt b/VM-Templates/VBox/Readme.txt index b730558..22bef3c 100644 --- a/VM-Templates/VBox/Readme.txt +++ b/VM-Templates/VBox/Readme.txt @@ -6,4 +6,4 @@ machine. You need VirtualBox from http://www.virtualbox.org to use it. If you want to access files of the virtual hard disk, Windows users can get the VMware DiskMount Utility available from -http://downloads.vmware.com/d/details/disk_mount_utility_5_5_driver_tools/JSpiZGR0cGJkd2U= \ No newline at end of file +http://downloads.vmware.com/d/details/disk_mount_utility_5_5_driver_tools/JSpiZGR0cGJkd2U= diff --git a/VM-Templates/VMware/Readme.txt b/VM-Templates/VMware/Readme.txt index 4cfff6e..dec7e66 100644 --- a/VM-Templates/VMware/Readme.txt +++ b/VM-Templates/VMware/Readme.txt @@ -7,4 +7,4 @@ machine. You need a VMware product from http://www.vmware.com to use it. If you want to access files of the virtual hard disk, you can use the VMware DiskMount Utility bundled with some VMware products. It is also available as a separate download at -http://downloads.vmware.com/d/details/disk_mount_utility_5_5_driver_tools/JSpiZGR0cGJkd2U= \ No newline at end of file +http://downloads.vmware.com/d/details/disk_mount_utility_5_5_driver_tools/JSpiZGR0cGJkd2U=