reactos/ninja
1
0
Fork 0
mirror of https://github.com/reactos/ninja.git synced 2024-11-26 21:20:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix misleading usage of return type of Open*Log

Browse Source 
In an earlier version of 791c887e22 those
functions returned LoadStatus, too, but it was changed back to bool.
This commit is contained in:
Jan Niklas Hasse 2021-04-09 13:45:25 +02:00
parent 3d33ca89d2
commit 721f5e9342
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ninja.cc
View File

@ -136,11 +136,11 @@ struct NinjaMain : public BuildLogUser {
int ToolWinCodePage(const Options* options, int argc, char* argv[]);
/// Open the build log.
/// @return LOAD_ERROR on error.
/// @return false on error.
bool OpenBuildLog(bool recompact_only = false);
/// Open the deps log: load it, then open for writing.
/// @return LOAD_ERROR on error.
/// @return false on error.
bool OpenDepsLog(bool recompact_only = false);
/// Ensure the build directory exists, creating it if necessary.
@ -894,8 +894,8 @@ int NinjaMain::ToolRecompact(const Options* options, int argc, char* argv[]) {
if (!EnsureBuildDirExists())
return 1;
if (OpenBuildLog(/*recompact_only=*/true) == LOAD_ERROR ||
OpenDepsLog(/*recompact_only=*/true) == LOAD_ERROR)
if (!OpenBuildLog(/*recompact_only=*/true) ||
!OpenDepsLog(/*recompact_only=*/true))
return 1;
return 0;