reactos/ninja
1
0
Fork 0
mirror of https://github.com/reactos/ninja.git synced 2024-12-11 05:13:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix potential buffer overrun

Browse Source 
This commit rearranges record size comparison and fread() to make sure
fread() only reads the data that can fit into the buffer.
This commit is contained in:
Logan Chien 2017-10-16 14:04:34 +08:00
parent 887eccf1fd
commit 7c80007b55
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/deps_log.cc
View File

@ -209,7 +209,7 @@ bool DepsLog::Load(const string& path, State* state, string* err) {
bool is_deps = (size >> 31) != 0;
size = size & 0x7FFFFFFF;
if (fread(buf, size, 1, f) < 1 || size > kMaxRecordSize) {
if (size > kMaxRecordSize || fread(buf, size, 1, f) < 1) {
read_failed = true;
break;
}