syzkaller/.golangci.yml

# Copyright 2019 syzkaller project authors. All rights reserved.
# Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.

run:
  deadline: 8m
  skip-dirs:
    - pkg/kd
    - tools/syz-trace2syz
  # Autogenerated files take too much time and memory to load,
  # even if we skip them with skip-dirs.
  # So we define this tag and use it in the autogenerated files.
  build-tags:
    - codeanalysis

output:
  print-linter-name: false

linters:
  enable:
    - lll
    - vet
    - gofmt
    - golint
    - structcheck
    - unconvert
    - deadcode
    - goconst
    - unused
    - gosimple
    - varcheck
    - misspell
    - gocyclo
    - vetshadow
    - megacheck
    - stylecheck
    - govet
    - whitespace
    - nestif
    - goprintffuncname
    - godot
    - gocognit
    - funlen
    - dupl
  disable:
    - bodyclose
    - depguard
    - dogsled
    - gochecknoglobals
    - gochecknoinits
    - godox
    - goimports
    - gomnd
    - gomodguard
    - gosec
    - maligned
    - rowserrcheck
    - testpackage
    - typecheck
    - ineffassign
    # errcheck would be good to enable, but we need to fix existing warnings first.
    - errcheck
    - interfacer
    - unparam
    - nakedret
    - prealloc
    - scopelint
    - gocritic
    - wsl

linters-settings:
  lll:
    line-length: 120
  gocyclo:
    # TODO: consider reducing this value.
    min-complexity: 24
  dupl:
    threshold: 60
  goconst:
    min-len: 3
    min-occurrences: 3
  nestif:
    # TODO: consider reducing this value.
    min-complexity: 12
  godot:
    check-all: true
  gocognit:
    # TODO: consider reducing this value.
    min-complexity: 70
  funlen:
    # TODO: consider reducing these value.
    lines: 140
    statements: 80

issues:
  exclude-use-default: false
  max-same-issues: 0
  exclude:
    - "exported .* should have comment"
    - "comment on .* should be of the form"
    - "at least one file in a package should have a package comment"
  exclude-rules:
    - path: (pkg/csource/generated.go|pkg/build/linux_generated.go)
      linters:
        - lll
    - path: (sys/.*/init.*|sys/targets/common.go)
      text: "don't use ALL_CAPS in Go names|should not use ALL_CAPS in Go names"
    - path: (prog/.*)
      text: "methods on the same type should have the same receiver name"
    - path: (dashboard/app/.*_test\.go)
      linters:
        - dupl
    - path: (prog/.*_test\.go)
      linters:
        - goconst
    - path: (.*_test\.go)
      text: "Function '.*' is too long"
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`# Copyright 2019 syzkaller project authors. All rights reserved.`
			`# Use of this source code is governed by Apache 2 LICENSE that can be found in the LICENSE file.`

			`run:`
			`deadline: 8m`
			`skip-dirs:`
			`- pkg/kd`
tools/syz-trace2syz: disable golangci-lint A new version of golangci-lint started failing trying to build syz-trace2syz (because we already ignore some files). Ignore the rest of files to fix the failure. 2019-10-08 10:26:27 +00:00			`- tools/syz-trace2syz`
.golangci.yml: add codeanalysis build tag Using a build tag to exclude files for golangci-lint reduces memory consumption (it does not parse them). The naive attempt with skip-dirs did not work. So add codeanalysis build tag and use it in auto-generated files. Update #977 2019-05-15 08:04:22 +00:00			`# Autogenerated files take too much time and memory to load,`
			`# even if we skip them with skip-dirs.`
			`# So we define this tag and use it in the autogenerated files.`
			`build-tags:`
			`- codeanalysis`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00
all: fix new golangci-lint warnings Newer version started producing more warnings. Fix them. 2020-03-13 07:26:02 +00:00			`output:`
			`print-linter-name: false`

.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`linters:`
			`enable:`
			`- lll`
.golangci.yml: update Enable more linters. Tune settings for existings. Fix excludes. Update #977 2019-04-23 13:58:23 +00:00			`- vet`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`- gofmt`
			`- golint`
			`- structcheck`
			`- unconvert`
			`- deadcode`
			`- goconst`
			`- unused`
			`- gosimple`
			`- varcheck`
			`- misspell`
			`- gocyclo`
			`- vetshadow`
			`- megacheck`
.golangci.yml: update Enable more linters. Tune settings for existings. Fix excludes. Update #977 2019-04-23 13:58:23 +00:00			`- stylecheck`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`- govet`
.golangci.yml: enable whitespace checker Points to bad empty lines very precisely. 2020-06-04 19:39:24 +00:00			`- whitespace`
.golangci.yml: enable nestif checker Prevents functions with too many nested if's. 2020-06-04 19:47:34 +00:00			`- nestif`
.golangci.yml: enable goprintffuncname checker Only 1 warning. Good to fix and enable before we get more. 2020-06-04 20:13:13 +00:00			`- goprintffuncname`
.golangci.yml: enable godot checker A good one. Lots of fixed comments are contributed by episodic contributors. So it's good to catch these earlier. 2020-06-04 20:20:22 +00:00			`- godot`
.golangci.yml: enable gocognit checker Finds too complex functions. Similar to gocyclo, but uses somewhat different metric. 2020-06-04 20:35:04 +00:00			`- gocognit`
.golangci.yml: enable funlen checker Checks for too long functions (based on lines and statements). 2020-06-04 21:07:55 +00:00			`- funlen`
.golangci.yml: reenable dupl checker At some point it was enabled, but then somehow got disabled. Re-enable and fix some regressions. 2020-06-04 21:29:54 +00:00			`- dupl`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`disable:`
.golangci.yml: explicitly list disabled checkers These are disabled by default, so this does not change behavior. But it's good to see whole list and this makes it clear that they are not missed accidentially. 2020-06-04 20:08:21 +00:00			`- bodyclose`
			`- depguard`
			`- dogsled`
			`- gochecknoglobals`
			`- gochecknoinits`
			`- godox`
			`- goimports`
			`- gomnd`
			`- gomodguard`
			`- gosec`
			`- maligned`
			`- rowserrcheck`
			`- testpackage`
.golangci.yml: update Enable more linters. Tune settings for existings. Fix excludes. Update #977 2019-04-23 13:58:23 +00:00			`- typecheck`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`- ineffassign`
.golangci.yml: explicitly list disabled checkers These are disabled by default, so this does not change behavior. But it's good to see whole list and this makes it clear that they are not missed accidentially. 2020-06-04 20:08:21 +00:00			`# errcheck would be good to enable, but we need to fix existing warnings first.`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`- errcheck`
.golangci.yml: update Enable more linters. Tune settings for existings. Fix excludes. Update #977 2019-04-23 13:58:23 +00:00			`- interfacer`
			`- unparam`
			`- nakedret`
			`- prealloc`
			`- scopelint`
			`- gocritic`
.golangci.yml: explicitly list disabled checkers These are disabled by default, so this does not change behavior. But it's good to see whole list and this makes it clear that they are not missed accidentially. 2020-06-04 20:08:21 +00:00			`- wsl`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00
			`linters-settings:`
			`lll:`
			`line-length: 120`
			`gocyclo:`
.golangci.yml: enable gocognit checker Finds too complex functions. Similar to gocyclo, but uses somewhat different metric. 2020-06-04 20:35:04 +00:00			`# TODO: consider reducing this value.`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`min-complexity: 24`
			`dupl:`
			`threshold: 60`
.golangci.yml: update Enable more linters. Tune settings for existings. Fix excludes. Update #977 2019-04-23 13:58:23 +00:00			`goconst:`
.golangci.yml: make goconst checker more strict 2020-06-06 09:34:20 +00:00			`min-len: 3`
			`min-occurrences: 3`
.golangci.yml: enable nestif checker Prevents functions with too many nested if's. 2020-06-04 19:47:34 +00:00			`nestif:`
.golangci.yml: enable gocognit checker Finds too complex functions. Similar to gocyclo, but uses somewhat different metric. 2020-06-04 20:35:04 +00:00			`# TODO: consider reducing this value.`
.golangci.yml: enable nestif checker Prevents functions with too many nested if's. 2020-06-04 19:47:34 +00:00			`min-complexity: 12`
.golangci.yml: enable godot checker A good one. Lots of fixed comments are contributed by episodic contributors. So it's good to catch these earlier. 2020-06-04 20:20:22 +00:00			`godot:`
			`check-all: true`
.golangci.yml: enable gocognit checker Finds too complex functions. Similar to gocyclo, but uses somewhat different metric. 2020-06-04 20:35:04 +00:00			`gocognit:`
			`# TODO: consider reducing this value.`
			`min-complexity: 70`
.golangci.yml: enable funlen checker Checks for too long functions (based on lines and statements). 2020-06-04 21:07:55 +00:00			`funlen:`
			`# TODO: consider reducing these value.`
.golangci.yml: reduce function line count from 200 to 140 140 lines should be enough for everyone. 2020-06-06 12:21:54 +00:00			`lines: 140`
.golangci.yml: enable funlen checker Checks for too long functions (based on lines and statements). 2020-06-04 21:07:55 +00:00			`statements: 80`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00
			`issues:`
			`exclude-use-default: false`
all: fix new golangci-lint warnings Newer version started producing more warnings. Fix them. 2020-03-13 07:26:02 +00:00			`max-same-issues: 0`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`exclude:`
			`- "exported .* should have comment"`
			`- "comment on .* should be of the form"`
updated golangci.yml to exclude new errors 2019-09-17 10:24:38 +00:00			`- "at least one file in a package should have a package comment"`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`exclude-rules:`
.golangci.yml: enable lll for pkg/report/linux.go 2020-06-06 05:48:14 +00:00			`- path: (pkg/csource/generated.go\|pkg/build/linux_generated.go)`
.golangci.yml: add golangci-lint config Update #977 2019-03-28 14:31:54 +00:00			`linters:`
			`- lll`
.golangci.yml: update Enable more linters. Tune settings for existings. Fix excludes. Update #977 2019-04-23 13:58:23 +00:00			`- path: (sys/./init.\|sys/targets/common.go)`
.golangci.yml: reduce scope of suppressions Reduce scope of some suppressions (some are violated only in some packages). Remove some outdated, fix and enable the type switch warning. 2020-06-06 05:40:04 +00:00			`text: "don't use ALL_CAPS in Go names\|should not use ALL_CAPS in Go names"`
.golangci.yml: enable receiver name check for pkg/ast 2020-06-06 05:55:42 +00:00			`- path: (prog/.*)`
.golangci.yml: reduce scope of suppressions Reduce scope of some suppressions (some are violated only in some packages). Remove some outdated, fix and enable the type switch warning. 2020-06-06 05:40:04 +00:00			`text: "methods on the same type should have the same receiver name"`
.golangci.yml: reenable dupl checker At some point it was enabled, but then somehow got disabled. Re-enable and fix some regressions. 2020-06-04 21:29:54 +00:00			`- path: (dashboard/app/.*_test\.go)`
			`linters:`
			`- dupl`
.golangci.yml: make goconst checker more strict 2020-06-06 09:34:20 +00:00			`- path: (prog/.*_test\.go)`
			`linters:`
			`- goconst`
.golangci.yml: reduce function line count from 200 to 140 140 lines should be enough for everyone. 2020-06-06 12:21:54 +00:00			`- path: (.*_test\.go)`
			`text: "Function '.*' is too long"`