reactos/syzkaller
1
0
Fork 0
mirror of https://github.com/reactos/syzkaller.git synced 2025-02-20 03:21:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dashboard/dashapi: always zero reply

Browse Source 
json decoding behavior is somewhat surprising
(see // https://github.com/golang/go/issues/21092).
This behavior is especially easy to hit in tests
that reuse reply objects.
To avoid any surprises, we zero the reply.
This commit is contained in:
Dmitry Vyukov 2017-07-25 20:25:53 +02:00
parent 4f5ad2aa53
commit 841aeb0303
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dashboard/dashapi/dashapi.go
View File

@ -14,6 +14,7 @@ import (
"io/ioutil"
"net/http"
"net/url"
"reflect"
"strings"
)
@ -157,6 +158,16 @@ type (
)
func Query(client, addr, key, method string, ctor RequestCtor, doer RequestDoer, req, reply interface{}) error {
if reply != nil {
// json decoding behavior is somewhat surprising
// (see // https://github.com/golang/go/issues/21092).
// To avoid any surprises, we zero the reply.
typ := reflect.TypeOf(reply)
if typ.Kind() != reflect.Ptr {
return fmt.Errorf("resp must be a pointer")
}
reflect.ValueOf(reply).Elem().Set(reflect.New(typ.Elem()).Elem())
}
values := make(url.Values)
values.Add("client", client)
values.Add("key", key)