reactos/syzkaller
1
0
Fork 0
mirror of https://github.com/reactos/syzkaller.git synced 2025-02-10 13:54:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

prog: Fix page fault for syz-stress users.

Browse Source 
In resources.go, haveGettime is False when SyscallMap["clock_gettime"]
is nil.

In this code, there's a branch that's entered only if Gettime is False,
which appends SyscallMap["clock_gettime"] to resourceCtors.  That is, it
appends nil to resourceCtors, then iterates through resourceCtors and
tries to dereference the .Name of each time, in this case, nil.Name.

This was causing a page fault on Fuchsia.

I'm not certain how the "standard" flow is supposed to work, since it
seems like any code that enters the `if cantCreate == "" && !haveGettime`
should fail... but, removing that section causes test failures, so let's
just enforce that SyscallMap["clock_gettime"] is non-nil.

If there's a better way to solve this, I'm open to suggestions.
This commit is contained in:
Julia Hansbrough 2018-05-01 14:34:00 -07:00 committed by Dmitry Vyukov
parent d5b114b401
commit 9ce14f4b01
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
prog/resources.go
View File

@ -125,7 +125,7 @@ func (target *Target) TransitivelyEnabledCalls(enabled map[*Syscall]bool) (map[*
}
// We need to support structs as resources,
// but for now we just special-case timespec/timeval.
if cantCreate == "" && !haveGettime {
if cantCreate == "" && !haveGettime && target.SyscallMap["clock_gettime"] != nil {
ForeachType(c, func(typ Type) {
if a, ok := typ.(*StructType); ok && a.Dir() != DirOut && (a.Name() == "timespec" || a.Name() == "timeval") {
cantCreate = a.Name()