reactos/syzkaller
1
0
Fork 0
mirror of https://github.com/reactos/syzkaller.git synced 2024-11-27 21:30:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

pkg/compiler: detect unused template params

Browse Source
This commit is contained in:
Andrey Konovalov 2019-09-03 18:54:35 +02:00 committed by Dmitry Vyukov
parent 526709ff04
commit a50398545a
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/compiler/check.go
View File

@ -861,6 +861,7 @@ func (comp *compiler) checkTypeArgs(t *ast.Type, desc *typeDesc, flags checkFlag
return args
}
// TODO: add warning when template arg is not used
func (comp *compiler) replaceTypedef(ctx *checkCtx, t *ast.Type, flags checkFlags) {
typedefName := t.Ident
comp.usedTypedefs[typedefName] = true
@ -940,6 +941,7 @@ func (comp *compiler) instantiate(templ ast.Node, params []*ast.Ident, args []*a
for i, param := range params {
argMap[param.Name] = args[i]
}
argUsed := make(map[string]bool)
err0 := comp.errors
templ.Walk(ast.Recursive(func(n ast.Node) {
templArg, ok := n.(*ast.Type)
@ -947,6 +949,7 @@ func (comp *compiler) instantiate(templ ast.Node, params []*ast.Ident, args []*a
return
}
if concreteArg := argMap[templArg.Ident]; concreteArg != nil {
argUsed[templArg.Ident] = true
origArgs := templArg.Args
if len(origArgs) != 0 && len(concreteArg.Args) != 0 {
comp.error(templArg.Pos, "both template parameter %v and its usage"+
@ -965,11 +968,18 @@ func (comp *compiler) instantiate(templ ast.Node, params []*ast.Ident, args []*a
if len(templArg.Colon) != 0 {
col := templArg.Colon[0]
if concreteArg := argMap[col.Ident]; concreteArg != nil {
argUsed[col.Ident] = true
col.Ident = concreteArg.Ident
col.Pos = concreteArg.Pos
}
}
}))
for _, param := range params {
if !argUsed[param.Name] {
comp.error(argMap[param.Name].Pos,
"template argument %v is not used", param.Name)
}
}
return err0 == comp.errors
}

4
pkg/compiler/testdata/errors.txt vendored
View File

@ -298,7 +298,7 @@ type templ_struct1[STR] {
}
type templ_struct2[A] {
f B ### unknown type B
f B
}
type templ_base0[TYPE] {
@ -323,7 +323,7 @@ foo$202(a templ0) ### template templ0 needs 2 arguments instead of 0
foo$203(a type0[42]) ### type type0 is not a template
foo$204(a ptr[in, templ_struct0[42, int8]])
foo$205(a ptr[in, templ_struct0[int8, int8]])
foo$207(a ptr[in, templ_struct2[1]])
foo$207(a ptr[in, templ_struct2[1]]) ### template argument A is not used
# fmt