syz-manager: don't print empty tag on report page

This commit is contained in:
Andrey Konovalov 2017-07-19 17:35:40 +02:00
parent f9f0e027d8
commit d1e3265562

View File

@ -256,11 +256,15 @@ func (mgr *Manager) httpReport(w http.ResponseWriter, r *http.Request) {
log, _ := ioutil.ReadFile(filepath.Join(mgr.crashdir, crashID, "repro.stats.log")) log, _ := ioutil.ReadFile(filepath.Join(mgr.crashdir, crashID, "repro.stats.log"))
stats, _ := ioutil.ReadFile(filepath.Join(mgr.crashdir, crashID, "repro.stats")) stats, _ := ioutil.ReadFile(filepath.Join(mgr.crashdir, crashID, "repro.stats"))
fmt.Fprintf(w, "Syzkaller hit '%s' bug on commit %s.\n\n", trimNewLines(desc), trimNewLines(tag)) commitDesc := ""
if len(tag) != 0 {
commitDesc = fmt.Sprintf(" on commit %s.", trimNewLines(tag))
}
fmt.Fprintf(w, "Syzkaller hit '%s' bug%s.\n\n", trimNewLines(desc), commitDesc)
if len(rep) != 0 { if len(rep) != 0 {
guiltyFile := report.ExtractGuiltyFile(rep) guiltyFile := report.ExtractGuiltyFile(rep)
if guiltyFile != "" { if guiltyFile != "" {
fmt.Fprintf(w, "The guilty file is: %v.\n\n", guiltyFile) fmt.Fprintf(w, "Guilty file: %v\n\n", guiltyFile)
maintainers, err := report.GetMaintainers(mgr.cfg.Kernel_Src, guiltyFile) maintainers, err := report.GetMaintainers(mgr.cfg.Kernel_Src, guiltyFile)
if err == nil { if err == nil {
fmt.Fprintf(w, "Maintainers: %v\n\n", maintainers) fmt.Fprintf(w, "Maintainers: %v\n\n", maintainers)