reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2025-02-18 03:48:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

msxml3: Fix double-free of BSTR in domdoc tests.

Browse Source 
Using the _bstr_ allocator adds the returned string to a cache, so the
string shouldn't be freed with SysFreeString. Therefore, just replace
the lone call to _bstr_ in this function by a straight call to
SysAllocString.
This commit is contained in:
Rob Shearman 2009-12-02 14:21:54 +00:00 committed by Alexandre Julliard
parent b84201dca5
commit 211e4fc0fe
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dlls/msxml3/tests/domdoc.c
View File

@ -209,6 +209,9 @@ static const CHAR szBasicTransformOutput[] =
static const WCHAR szNonExistentFile[] = {
'c', ':', '\\', 'N', 'o', 'n', 'e', 'x', 'i', 's', 't', 'e', 'n', 't', '.', 'x', 'm', 'l', 0
};
static const WCHAR szNonExistentAttribute[] = {
'n','o','n','E','x','i','s','i','t','i','n','g','A','t','t','r','i','b','u','t','e',0
};
static const WCHAR szDocument[] = {
'#', 'd', 'o', 'c', 'u', 'm', 'e', 'n', 't', 0
};
@ -1110,7 +1113,7 @@ static void test_domnode( void )
SysFreeString( str );
attr = (IXMLDOMAttribute*)0xdeadbeef;
str = _bstr_("nonExisitingAttribute");
str = SysAllocString( szNonExistentAttribute );
r = IXMLDOMElement_getAttributeNode( element, str, &attr);
ok( r == S_FALSE, "getAttributeNode ret %08x\n", r );
ok( attr == NULL, "getAttributeNode ret %p, expected NULL\n", attr );