reactos/wine
1
0
Fork 0
mirror of https://github.com/reactos/wine.git synced 2024-12-02 08:46:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

shlwapi/tests: Prevent buffer overflow.

Browse Source
This commit is contained in:
Ge van Geldorp 2009-08-24 14:25:40 +02:00 committed by Alexandre Julliard
parent 1b0648229d
commit 2245e2c17e
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
dlls/shlwapi/tests/path.c
View File

@ -690,7 +690,7 @@ static void test_PathAppendA(void)
{
char path[MAX_PATH];
char too_long[LONG_LEN];
char one[HALF_LEN], two[HALF_LEN];
char half[HALF_LEN];
BOOL res;
lstrcpy(path, "C:\\one");
@ -803,16 +803,16 @@ static void test_PathAppendA(void)
"Expected length of path to be zero, got %i\n", lstrlen(path));
/* both params combined are too long */
memset(one, 'a', HALF_LEN);
one[HALF_LEN - 1] = '\0';
memset(two, 'b', HALF_LEN);
two[HALF_LEN - 1] = '\0';
memset(path, 'a', HALF_LEN);
path[HALF_LEN - 1] = '\0';
memset(half, 'b', HALF_LEN);
half[HALF_LEN - 1] = '\0';
SetLastError(0xdeadbeef);
res = PathAppendA(one, two);
res = PathAppendA(path, half);
ok(!res, "Expected failure\n");
ok(lstrlen(one) == 0 ||
broken(lstrlen(one) == (HALF_LEN - 1)), /* Win95 and some W2K */
"Expected length of one to be zero, got %i\n", lstrlen(one));
ok(lstrlen(path) == 0 ||
broken(lstrlen(path) == (HALF_LEN - 1)), /* Win95 and some W2K */
"Expected length of path to be zero, got %i\n", lstrlen(path));
ok(GetLastError() == 0xdeadbeef, "Expected 0xdeadbeef, got %d\n", GetLastError());
}